[V4,11/11] arb_arrays_of_arrays: builtin test

Message ID 1402749495-11964-2-git-send-email-t_arceri@yahoo.com.au
State New
Headers show

Commit Message

'Timothy Arceri' via Patchwork Forward June 14, 2014, 12:38 p.m.
Test results are from the following hardware/driver combinations:

AMD Radeon HD 6670 - Catalyst 13.251 OpenGL 4.3
Nvidia GeForce 210 - NVIDIA 331.20 OpenGL 3.3
Intel Ivy Bridge - Mesa 10.1(815e064) with ARB_arrays_of_arrays enabled

gl_TexCoord-invalid-multidim.vert
AMD: pass
Nvida: fail
Intel: pass

Signed-off-by: Timothy Arceri <t_arceri@yahoo.com.au>
---
 .../compiler/gl_TexCoord-invalid-multidim.vert          | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/gl_TexCoord-invalid-multidim.vert

Comments

Chris Forbes June 14, 2014, 9:29 p.m. | #1
s/Nvida/Nvidia/g in your commit messages

Otherwise, this series is

Reviewed-by: Chris Forbes <chrisf@ijw.co.nz>

On Sun, Jun 15, 2014 at 12:38 AM, Timothy Arceri <t_arceri@yahoo.com.au> wrote:
> Test results are from the following hardware/driver combinations:
>
> AMD Radeon HD 6670 - Catalyst 13.251 OpenGL 4.3
> Nvidia GeForce 210 - NVIDIA 331.20 OpenGL 3.3
> Intel Ivy Bridge - Mesa 10.1(815e064) with ARB_arrays_of_arrays enabled
>
> gl_TexCoord-invalid-multidim.vert
> AMD: pass
> Nvida: fail
> Intel: pass
>
> Signed-off-by: Timothy Arceri <t_arceri@yahoo.com.au>
> ---
>  .../compiler/gl_TexCoord-invalid-multidim.vert          | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/gl_TexCoord-invalid-multidim.vert
>
> diff --git a/tests/spec/arb_arrays_of_arrays/compiler/gl_TexCoord-invalid-multidim.vert b/tests/spec/arb_arrays_of_arrays/compiler/gl_TexCoord-invalid-multidim.vert
> new file mode 100644
> index 0000000..03f4e29
> --- /dev/null
> +++ b/tests/spec/arb_arrays_of_arrays/compiler/gl_TexCoord-invalid-multidim.vert
> @@ -0,0 +1,17 @@
> +/* [config]
> + * expect_result: fail
> + * glsl_version: 1.20
> + * require_extensions: GL_ARB_arrays_of_arrays
> + * [end config]
> + *
> + * From page 54 (page 60 of the PDF) of the GLSL 1.20 spec:
> + *
> + *     "The size [of gl_TexCoord] can be at most
> + *     gl_MaxTextureCoords."
> + */
> +#version 120
> +#extension GL_ARB_arrays_of_arrays: enable
> +
> +varying vec4 gl_TexCoord[gl_MaxTextureCoords][1];
> +
> +void main() { gl_Position = vec4(0.0); }
> --
> 1.9.3
>
> _______________________________________________
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit

Patch

diff --git a/tests/spec/arb_arrays_of_arrays/compiler/gl_TexCoord-invalid-multidim.vert b/tests/spec/arb_arrays_of_arrays/compiler/gl_TexCoord-invalid-multidim.vert
new file mode 100644
index 0000000..03f4e29
--- /dev/null
+++ b/tests/spec/arb_arrays_of_arrays/compiler/gl_TexCoord-invalid-multidim.vert
@@ -0,0 +1,17 @@ 
+/* [config]
+ * expect_result: fail
+ * glsl_version: 1.20
+ * require_extensions: GL_ARB_arrays_of_arrays
+ * [end config]
+ *
+ * From page 54 (page 60 of the PDF) of the GLSL 1.20 spec:
+ *
+ *     "The size [of gl_TexCoord] can be at most
+ *     gl_MaxTextureCoords."
+ */
+#version 120
+#extension GL_ARB_arrays_of_arrays: enable
+
+varying vec4 gl_TexCoord[gl_MaxTextureCoords][1];
+
+void main() { gl_Position = vec4(0.0); }