diff mbox series

[v3] tty: serial: imx: enable earlycon by default if IMX_SERIAL_CONSOLE is enabled

Message ID 20201105204026.1818219-1-l.stach@pengutronix.de
State Superseded
Headers show
Series [v3] tty: serial: imx: enable earlycon by default if IMX_SERIAL_CONSOLE is enabled | expand

Commit Message

Lucas Stach Nov. 5, 2020, 8:40 p.m. UTC
Since 699cc4dfd140 (tty: serial: imx: add imx earlycon driver), the earlycon
part of imx serial is a separate driver and isn't necessarily enabled anymore
when the console is enabled. This causes users to loose the earlycon
functionality when upgrading their kenrel configuration via oldconfig.

Enable earlycon by default when IMX_SERIAL_CONSOLE is enabled.

Fixes: 699cc4dfd140 (tty: serial: imx: add imx earlycon driver)
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
v2: add R-b from Fabio, fix typo in subject
v3: no changes, adding this note
---
 drivers/tty/serial/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Andy Duan Nov. 6, 2020, 1:28 a.m. UTC | #1
From: Lucas Stach <l.stach@pengutronix.de> Sent: Friday, November 6, 2020 4:40 AM

> Since 699cc4dfd140 (tty: serial: imx: add imx earlycon driver), the earlycon part

> of imx serial is a separate driver and isn't necessarily enabled anymore when the

> console is enabled. This causes users to loose the earlycon functionality when

> upgrading their kenrel configuration via oldconfig.

> 

> Enable earlycon by default when IMX_SERIAL_CONSOLE is enabled.

> 

> Fixes: 699cc4dfd140 (tty: serial: imx: add imx earlycon driver)

> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

> Reviewed-by: Fabio Estevam <festevam@gmail.com>

> ---

> v2: add R-b from Fabio, fix typo in subject

> v3: no changes, adding this note


Reviewed-by: Fugang Duan <fugang.duan@nxp.com>

> ---

>  drivers/tty/serial/Kconfig | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index

> 1044fc387691..28f22e58639c 100644

> --- a/drivers/tty/serial/Kconfig

> +++ b/drivers/tty/serial/Kconfig

> @@ -522,6 +522,7 @@ config SERIAL_IMX_EARLYCON

>         depends on OF

>         select SERIAL_EARLYCON

>         select SERIAL_CORE_CONSOLE

> +       default y if SERIAL_IMX_CONSOLE

>         help

>           If you have enabled the earlycon on the Freescale IMX

>           CPU you can make it the earlycon by answering Y to this option.

> --

> 2.20.1
diff mbox series

Patch

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 1044fc387691..28f22e58639c 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -522,6 +522,7 @@  config SERIAL_IMX_EARLYCON
 	depends on OF
 	select SERIAL_EARLYCON
 	select SERIAL_CORE_CONSOLE
+	default y if SERIAL_IMX_CONSOLE
 	help
 	  If you have enabled the earlycon on the Freescale IMX
 	  CPU you can make it the earlycon by answering Y to this option.