| Message ID | 20201105235703.1328115-1-lyude@redhat.com |
|---|---|
| State | Accepted |
| Commit | 991fcb77f490390bcad89fa67d95763c58cdc04c |
| Headers | show |
| Series | [v3] drm/edid: Fix uninitialized variable in drm_cvt_modes() | expand |
On Thu, Nov 5, 2020 at 6:57 PM Lyude Paul <lyude@redhat.com> wrote: > > Noticed this when trying to compile with -Wall on a kernel fork. We potentially > don't set width here, which causes the compiler to complain about width > potentially being uninitialized in drm_cvt_modes(). So, let's fix that. > > Changes since v1: > * Don't emit an error as this code isn't reachable, just mark it as such > Changes since v2: > * Remove now unused variable > > Signed-off-by: Lyude Paul <lyude@redhat.com> > > Cc: <stable@vger.kernel.org> # v5.9+ > Fixes: 3f649ab728cd ("treewide: Remove uninitialized_var() usage") > Signed-off-by: Lyude Paul <lyude@redhat.com> For the very little it's worth, Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu> > --- > drivers/gpu/drm/drm_edid.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 631125b46e04..b84efd538a70 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3114,6 +3114,8 @@ static int drm_cvt_modes(struct drm_connector *connector, > case 0x0c: > width = height * 15 / 9; > break; > + default: > + unreachable(); > } > > for (j = 1; j < 5; j++) { > -- > 2.28.0 >
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 631125b46e04..b84efd538a70 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3114,6 +3114,8 @@ static int drm_cvt_modes(struct drm_connector *connector, case 0x0c: width = height * 15 / 9; break; + default: + unreachable(); } for (j = 1; j < 5; j++) {