msm_sdcc: remove needless cache flush after dma_unmap_sg()

Message ID AANLkTi=EW1Jv0U4XyTnYeyqg7rMY=cwmCaMrBRBKgvwv@mail.gmail.com
State Accepted, archived
Headers show

Commit Message

Linus Walleij March 4, 2011, 10:28 a.m.
---------- Forwarded message ----------
From: Linus Walleij <linus.walleij@linaro.org>
Date: Wed, Feb 16, 2011 at 11:28 PM
Subject: [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg()
To: linux-mmc@vger.kernel.org
Cc: Sahitya Tummala <stummala@codeaurora.org>, San Mehat
<san@google.com>, Linus Walleij <linus.walleij@linaro.org>


dma_unmap_sg() already flushes the cache, I don't get what this
code is doing here.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/mmc/host/msm_sdcc.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

--
1.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
index 153ab97..67b0881 100644
--- a/drivers/mmc/host/msm_sdcc.c
+++ b/drivers/mmc/host/msm_sdcc.c
@@ -266,14 +266,6 @@  msmsdcc_dma_complete_tlet(unsigned long data)
       dma_unmap_sg(mmc_dev(host->mmc), host->dma.sg, host->dma.num_ents,
                    host->dma.dir);

-       if (host->curr.user_pages) {
-               struct scatterlist *sg = host->dma.sg;
-               int i;
-
-               for (i = 0; i < host->dma.num_ents; i++)
-                       flush_dcache_page(sg_page(sg++));
-       }
-
       host->dma.sg = NULL;
       host->dma.busy = 0;