diff mbox

firmware: fix the compiller warning

Message ID 53A3B665.3080308@huawei.com
State New
Headers show

Commit Message

Ding Tianhong June 20, 2014, 4:19 a.m. UTC
When I compile the kernel, found this warning:

In file included from arch/arm64/kernel/efi-stub.c:44:0:
arch/arm64/kernel/../../../drivers/firmware/efi/fdt.c: In function update_fdt:
arch/arm64/kernel/../../../drivers/firmware/efi/fdt.c:66:22: warning: unused variable name [-Wunused-variable]
   const char *type, *name;

so remove the unused variable and clean this warning.

Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
 drivers/firmware/efi/fdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matt Fleming June 20, 2014, 9:03 a.m. UTC | #1
On Fri, 20 Jun, at 12:19:49PM, Ding Tianhong wrote:
> When I compile the kernel, found this warning:
> 
> In file included from arch/arm64/kernel/efi-stub.c:44:0:
> arch/arm64/kernel/../../../drivers/firmware/efi/fdt.c: In function update_fdt:
> arch/arm64/kernel/../../../drivers/firmware/efi/fdt.c:66:22: warning: unused variable name [-Wunused-variable]
>    const char *type, *name;
> 
> so remove the unused variable and clean this warning.
> 
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
> ---
>  drivers/firmware/efi/fdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, for the report, but I've already queued up a fix from Catalin
and sent a pull request to the tip folks,

 http://marc.info/?l=linux-kernel&m=140325482303647
diff mbox

Patch

diff --git a/drivers/firmware/efi/fdt.c b/drivers/firmware/efi/fdt.c
index 5c6a8e8..82d7741 100644
--- a/drivers/firmware/efi/fdt.c
+++ b/drivers/firmware/efi/fdt.c
@@ -63,7 +63,7 @@  static efi_status_t update_fdt(efi_system_table_t *sys_table, void *orig_fdt,
 	 */
 	prev = 0;
 	for (;;) {
-		const char *type, *name;
+		const char *type;
 		int len;
 
 		node = fdt_next_node(fdt, prev, NULL);