diff mbox

[2/2] sparse warning: Make local functions static

Message ID 1403286379-52829-2-git-send-email-mike.holmes@linaro.org
State Rejected
Headers show

Commit Message

Mike Holmes June 20, 2014, 5:46 p.m. UTC
Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 test/generator/odp_generator.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Anders Roxell June 22, 2014, 11:11 p.m. UTC | #1
On 2014-06-20 13:46, Mike Holmes wrote:
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>

Reviewed-by: Anders Roxell <anders.roxell@linaro.org>

> ---
>  test/generator/odp_generator.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/test/generator/odp_generator.c b/test/generator/odp_generator.c
> index ca84e4c..fd85455 100644
> --- a/test/generator/odp_generator.c
> +++ b/test/generator/odp_generator.c
> @@ -61,7 +61,7 @@ typedef struct {
>  /**
>   * counters
>  */
> -struct {
> +static struct {
>  	odp_atomic_u64_t seq;	/**< ip seq to be send */
>  	odp_atomic_u64_t ip;	/**< ip packets */
>  	odp_atomic_u64_t udp;	/**< udp packets */
> @@ -105,7 +105,7 @@ static void tv_sub(struct timeval *recvtime, struct timeval *sendtime);
>   * @param paddr ip address for odp_packet
>   * @return 1 success, 0 failed
>  */
> -int scan_ip(char *buf, unsigned int *paddr)
> +static int scan_ip(char *buf, unsigned int *paddr)
>  {
>  	int part1, part2, part3, part4;
>  	char tail = 0;
> @@ -146,7 +146,7 @@ int scan_ip(char *buf, unsigned int *paddr)
>   * @param  des mac for odp_packet
>   * @return 1 success, 0 failed
>   */
> -int scan_mac(char *in, odp_ethaddr_t *des)
> +static int scan_mac(char *in, odp_ethaddr_t *des)
>  {
>  	int field;
>  	int i;
> @@ -909,7 +909,7 @@ static void usage(char *progname)
>   *@param recvtime start time
>   *@param sendtime end time
>  */
> -void tv_sub(struct timeval *recvtime, struct timeval *sendtime)
> +static void tv_sub(struct timeval *recvtime, struct timeval *sendtime)
>  {
>  	long sec = recvtime->tv_sec - sendtime->tv_sec;
>  	long usec = recvtime->tv_usec - sendtime->tv_usec;
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/test/generator/odp_generator.c b/test/generator/odp_generator.c
index ca84e4c..fd85455 100644
--- a/test/generator/odp_generator.c
+++ b/test/generator/odp_generator.c
@@ -61,7 +61,7 @@  typedef struct {
 /**
  * counters
 */
-struct {
+static struct {
 	odp_atomic_u64_t seq;	/**< ip seq to be send */
 	odp_atomic_u64_t ip;	/**< ip packets */
 	odp_atomic_u64_t udp;	/**< udp packets */
@@ -105,7 +105,7 @@  static void tv_sub(struct timeval *recvtime, struct timeval *sendtime);
  * @param paddr ip address for odp_packet
  * @return 1 success, 0 failed
 */
-int scan_ip(char *buf, unsigned int *paddr)
+static int scan_ip(char *buf, unsigned int *paddr)
 {
 	int part1, part2, part3, part4;
 	char tail = 0;
@@ -146,7 +146,7 @@  int scan_ip(char *buf, unsigned int *paddr)
  * @param  des mac for odp_packet
  * @return 1 success, 0 failed
  */
-int scan_mac(char *in, odp_ethaddr_t *des)
+static int scan_mac(char *in, odp_ethaddr_t *des)
 {
 	int field;
 	int i;
@@ -909,7 +909,7 @@  static void usage(char *progname)
  *@param recvtime start time
  *@param sendtime end time
 */
-void tv_sub(struct timeval *recvtime, struct timeval *sendtime)
+static void tv_sub(struct timeval *recvtime, struct timeval *sendtime)
 {
 	long sec = recvtime->tv_sec - sendtime->tv_sec;
 	long usec = recvtime->tv_usec - sendtime->tv_usec;