diff mbox series

[v2,04/18] arm: dts: hisi-x5hd2: Harmonize EHCI/OHCI DT nodes name

Message ID 20201111091552.15593-5-Sergey.Semin@baikalelectronics.ru
State New
Headers show
Series dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name | expand

Commit Message

Serge Semin Nov. 11, 2020, 9:15 a.m. UTC
In accordance with the Generic EHCI/OHCI bindings the corresponding node
name is suppose to comply with the Generic USB HCD DT schema, which
requires the USB nodes to have the name acceptable by the regexp:
"^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible
nodes are correctly named.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/boot/dts/hisi-x5hd2.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Wei Xu Nov. 25, 2020, 2:27 a.m. UTC | #1
Hi Serge,

On 2020/11/11 17:15, Serge Semin wrote:
> In accordance with the Generic EHCI/OHCI bindings the corresponding node

> name is suppose to comply with the Generic USB HCD DT schema, which

> requires the USB nodes to have the name acceptable by the regexp:

> "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible

> nodes are correctly named.

> 

> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

> ---

>  arch/arm/boot/dts/hisi-x5hd2.dtsi | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi

> index 3ee7967c202d..693b85b2cc7d 100644

> --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi

> +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi

> @@ -452,14 +452,14 @@ gmac1: ethernet@1841000 {

>  			status = "disabled";

>  		};

>  

> -		usb0: ehci@1890000 {

> +		usb0: usb@1890000 {

>  			compatible = "generic-ehci";

>  			reg = <0x1890000 0x1000>;

>  			interrupts = <0 66 4>;

>  			clocks = <&clock HIX5HD2_USB_CLK>;

>  		};

>  

> -		usb1: ohci@1880000 {

> +		usb1: usb@1880000 {

>  			compatible = "generic-ohci";

>  			reg = <0x1880000 0x1000>;

>  			interrupts = <0 67 4>;

> 


Thanks!
But a similar patch has been sent out earlier:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201012061225.1597-4-thunder.leizhen@huawei.com/

Best Regards,
Wei
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi
index 3ee7967c202d..693b85b2cc7d 100644
--- a/arch/arm/boot/dts/hisi-x5hd2.dtsi
+++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi
@@ -452,14 +452,14 @@  gmac1: ethernet@1841000 {
 			status = "disabled";
 		};
 
-		usb0: ehci@1890000 {
+		usb0: usb@1890000 {
 			compatible = "generic-ehci";
 			reg = <0x1890000 0x1000>;
 			interrupts = <0 66 4>;
 			clocks = <&clock HIX5HD2_USB_CLK>;
 		};
 
-		usb1: ohci@1880000 {
+		usb1: usb@1880000 {
 			compatible = "generic-ohci";
 			reg = <0x1880000 0x1000>;
 			interrupts = <0 67 4>;