| Message ID | 1403564794-15881-1-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On 06/23/2014 04:06 PM, Peter Maydell wrote: > The ld_code6() function is unused; remove it. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > We could use this for loads of 6-byte insns, but that would > imply a pointless reload of the first 2 bytes, which is > presumably why this function isn't actually used. Exactly so. Reviewed-by: Richard Henderson <rth@twiddle.net> r~
diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 8ca4824..e2a1d05 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@ -264,11 +264,6 @@ static inline uint64_t ld_code4(CPUS390XState *env, uint64_t pc) return (uint64_t)(uint32_t)cpu_ldl_code(env, pc); } -static inline uint64_t ld_code6(CPUS390XState *env, uint64_t pc) -{ - return (ld_code2(env, pc) << 32) | ld_code4(env, pc + 2); -} - static int get_mem_index(DisasContext *s) { switch (s->tb->flags & FLAG_MASK_ASC) {
The ld_code6() function is unused; remove it. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- We could use this for loads of 6-byte insns, but that would imply a pointless reload of the first 2 bytes, which is presumably why this function isn't actually used. --- target-s390x/translate.c | 5 ----- 1 file changed, 5 deletions(-)