diff mbox series

[8/8] mhi: pci_generic: Increase controller timeout value

Message ID 1605279602-18749-9-git-send-email-loic.poulain@linaro.org
State Superseded
Headers show
Series mhi: pci_generic: Misc improvements | expand

Commit Message

Loic Poulain Nov. 13, 2020, 3 p.m. UTC
On cold boot, device can take slightly more than 5 seconds to start.
Increase the timeout to prevent MHI power-up issues.

Signed-off-by: Loic Poulain <loic.poulain@linaro.org>

---
 drivers/bus/mhi/pci_generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

Comments

Bhaumik Bhatt Nov. 13, 2020, 5:08 p.m. UTC | #1
On 2020-11-13 07:00, Loic Poulain wrote:
> On cold boot, device can take slightly more than 5 seconds to start.

> Increase the timeout to prevent MHI power-up issues.

> 

> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>

Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org>

> ---

>  drivers/bus/mhi/pci_generic.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/bus/mhi/pci_generic.c 

> b/drivers/bus/mhi/pci_generic.c

> index 6cc7bb9..7f0068c 100644

> --- a/drivers/bus/mhi/pci_generic.c

> +++ b/drivers/bus/mhi/pci_generic.c

> @@ -162,7 +162,7 @@ static const struct mhi_event_config

> modem_qcom_v1_mhi_events[] = {

> 

>  static const struct mhi_controller_config modem_qcom_v1_mhiv_config = 

> {

>  	.max_channels = 128,

> -	.timeout_ms = 5000,

> +	.timeout_ms = 8000,

>  	.num_channels = ARRAY_SIZE(modem_qcom_v1_mhi_channels),

>  	.ch_cfg = modem_qcom_v1_mhi_channels,

>  	.num_events = ARRAY_SIZE(modem_qcom_v1_mhi_events),


-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project
Hemant Kumar Nov. 25, 2020, 8:23 p.m. UTC | #2
On 11/13/20 7:00 AM, Loic Poulain wrote:
> On cold boot, device can take slightly more than 5 seconds to start.

> Increase the timeout to prevent MHI power-up issues.

> 

> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>

> ---

>   drivers/bus/mhi/pci_generic.c | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c

> index 6cc7bb9..7f0068c 100644

> --- a/drivers/bus/mhi/pci_generic.c

> +++ b/drivers/bus/mhi/pci_generic.c

> @@ -162,7 +162,7 @@ static const struct mhi_event_config modem_qcom_v1_mhi_events[] = {

>   

>   static const struct mhi_controller_config modem_qcom_v1_mhiv_config = {

>   	.max_channels = 128,

> -	.timeout_ms = 5000,

> +	.timeout_ms = 8000,

>   	.num_channels = ARRAY_SIZE(modem_qcom_v1_mhi_channels),

>   	.ch_cfg = modem_qcom_v1_mhi_channels,

>   	.num_events = ARRAY_SIZE(modem_qcom_v1_mhi_events),

> 


Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
diff mbox series

Patch

diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 6cc7bb9..7f0068c 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -162,7 +162,7 @@  static const struct mhi_event_config modem_qcom_v1_mhi_events[] = {
 
 static const struct mhi_controller_config modem_qcom_v1_mhiv_config = {
 	.max_channels = 128,
-	.timeout_ms = 5000,
+	.timeout_ms = 8000,
 	.num_channels = ARRAY_SIZE(modem_qcom_v1_mhi_channels),
 	.ch_cfg = modem_qcom_v1_mhi_channels,
 	.num_events = ARRAY_SIZE(modem_qcom_v1_mhi_events),