From patchwork Wed Jun 25 12:38:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 32474 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f197.google.com (mail-ie0-f197.google.com [209.85.223.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1E5B420C88 for ; Wed, 25 Jun 2014 12:40:49 +0000 (UTC) Received: by mail-ie0-f197.google.com with SMTP id lx4sf10325191iec.0 for ; Wed, 25 Jun 2014 05:40:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:from:to:date:in-reply-to :references:organization:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=gWRiGPcba7dxqNMkdq554pkWJHXf2dUbi8b4LRlqlsQ=; b=ilaDTfygDN/I4inbHWUcury/QJLHFyjNIv9cNc1O1vWvN6WN/K66DoetFtEcI3cpih Wk1/ZxgUyAtSBIqdWz8AP03f6HXSGIxncKs8yGbVXi+vlHP7qxI0JMzEjzVLSXGB5GK1 o1NPT7XmBqcLIbZ6MbxmMlAp70Ii0UD//r+CmQTvFSrgoXShqiBFvqCdlO/gGuwxmi4M 6pmgNvHwIX8fO0nkALWMcB6L0EEELA3vLrURk/tJ7mGvqn3JoHSm+Cv+uoWlRyiCe2lh DnR4gCAfVmbiOQNtK3y6A+wKwevfttqJ2ExCKEjv0NIJnRF00V66Yr4FZnwcxn9d7BxC WaNg== X-Gm-Message-State: ALoCoQmUPBfugyg8iYqytHzgeSSEf56AENqPSnJOdd1U4G8zDo7NZnxSVZd2gJ5+FWC9xSR2c/Kv X-Received: by 10.50.148.1 with SMTP id to1mr17221458igb.0.1403700049568; Wed, 25 Jun 2014 05:40:49 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.81.39 with SMTP id e36ls1858501qgd.24.gmail; Wed, 25 Jun 2014 05:40:49 -0700 (PDT) X-Received: by 10.58.48.193 with SMTP id o1mr161207ven.68.1403700049478; Wed, 25 Jun 2014 05:40:49 -0700 (PDT) Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com [209.85.128.172]) by mx.google.com with ESMTPS id yf19si2152945vdb.30.2014.06.25.05.40.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 25 Jun 2014 05:40:49 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.172 as permitted sender) client-ip=209.85.128.172; Received: by mail-ve0-f172.google.com with SMTP id jz11so1916087veb.3 for ; Wed, 25 Jun 2014 05:40:49 -0700 (PDT) X-Received: by 10.58.209.7 with SMTP id mi7mr52930vec.80.1403700049414; Wed, 25 Jun 2014 05:40:49 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp286648vcb; Wed, 25 Jun 2014 05:40:49 -0700 (PDT) X-Received: by 10.50.134.73 with SMTP id pi9mr26904958igb.25.1403700048654; Wed, 25 Jun 2014 05:40:48 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id rv8si3313910igb.32.2014.06.25.05.40.47 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 25 Jun 2014 05:40:48 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WzmTc-0002iG-BX; Wed, 25 Jun 2014 12:39:00 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WzmTb-0002hp-AI for xen-devel@lists.xen.org; Wed, 25 Jun 2014 12:38:59 +0000 Received: from [193.109.254.147:47814] by server-15.bemta-14.messagelabs.com id 2F/9F-15813-2E2CAA35; Wed, 25 Jun 2014 12:38:58 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-4.tower-27.messagelabs.com!1403699936!13613895!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 14932 invoked from network); 25 Jun 2014 12:38:57 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 25 Jun 2014 12:38:57 -0000 X-IronPort-AV: E=Sophos;i="5.01,546,1400025600"; d="scan'208";a="147155649" Received: from accessns.citrite.net (HELO FTLPEX01CL03.citrite.net) ([10.9.154.239]) by FTLPIPO01.CITRIX.COM with ESMTP; 25 Jun 2014 12:38:56 +0000 Received: from kazak.uk.xensource.com (10.80.2.80) by FTLPEX01CL03.citrite.net (10.13.107.80) with Microsoft SMTP Server id 14.3.181.6; Wed, 25 Jun 2014 08:38:54 -0400 Message-ID: <1403699934.18068.4.camel@kazak.uk.xensource.com> From: Ian Campbell To: Jim Fehlig Date: Wed, 25 Jun 2014 13:38:54 +0100 In-Reply-To: <53AA3F89.6050904@suse.com> References: <1403018758.25074.5.camel@kazak.uk.xensource.com> <1403018809-25509-7-git-send-email-ian.campbell@citrix.com> <1403019217.25074.10.camel@kazak.uk.xensource.com> <53A89C03.7030002@suse.com> <53AA3F89.6050904@suse.com> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.12.2-1 MIME-Version: 1.0 X-Originating-IP: [10.80.2.80] X-DLP: MIA1 Cc: LibVir , ian.jackson@eu.citrix.com, xen-devel@lists.xen.org Subject: Re: [Xen-devel] [PATCH RFC OSSTEST 7/9] Toolstack: Abstract away migration support check. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: On Tue, 2014-06-24 at 21:18 -0600, Jim Fehlig wrote: > Something like the attached patch (compile-tested only). You'll need an > updated libvirt.git master to apply cleanly. Thanks. Building on ARM I get: libxl/libxl_driver.c:4346:1: error: 'libxlDomainMigrateBegin3Params' defined but not used [-Werror=unused-function] libxl/libxl_driver.c:4384:1: error: 'libxlDomainMigratePrepare3Params' defined but not used [-Werror=unused-function] libxl/libxl_driver.c:4433:1: error: 'libxlDomainMigratePerform3Params' defined but not used [-Werror=unused-function] libxl/libxl_driver.c:4488:1: error: 'libxlDomainMigrateFinish3Params' defined but not used [-Werror=unused-function] libxl/libxl_driver.c:4539:1: error: 'libxlDomainMigrateConfirm3Params' defined but not used [-Werror=unused-function] The fixup is obvious (I didn't bother with commit message etc since I expect you'll want to fold it in): commit 69606cdba69afdd5e2eea0096596ae3beaa34890 Author: Ian Campbell Date: Wed Jun 25 11:48:45 2014 +0100 fixup diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index f90bf64..03d397e 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -4342,6 +4342,7 @@ libxlNodeDeviceReset(virNodeDevicePtr dev) return ret; } +#ifndef LIBXL_HAVE_NO_SUSPEND_RESUME static char * libxlDomainMigrateBegin3Params(virDomainPtr domain, virTypedParameterPtr params, @@ -4561,7 +4562,7 @@ libxlDomainMigrateConfirm3Params(virDomainPtr domain, return libxlDomainMigrationConfirm(driver, vm, flags, cancelled); } - +#endif /* ifndef LIBXL_HAVE_NO_SUSPEND_RESUME */ static virDriver libxlDriver = { .no = VIR_DRV_LIBXL,