diff mbox series

[2/2] drm/ingenic: depend on COMMON_CLK to fix compile tests

Message ID 20201116175301.402787-2-krzk@kernel.org
State New
Headers show
Series None | expand

Commit Message

Krzysztof Kozlowski Nov. 16, 2020, 5:53 p.m. UTC
The Ingenic DRM uses Common Clock Framework thus it cannot be built on
platforms without it (e.g. compile test on MIPS with RALINK and
SOC_RT305X):

    /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/ingenic/ingenic-drm-drv.o: in function `ingenic_drm_bind.isra.0':
    ingenic-drm-drv.c:(.text+0x1600): undefined reference to `clk_get_parent'
    /usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0): undefined reference to `clk_get_parent'

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/gpu/drm/ingenic/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Dec. 4, 2020, 8:18 a.m. UTC | #1
On Mon, Nov 16, 2020 at 07:54:03PM +0000, Paul Cercueil wrote:
> Hi Krzysztof,
> 
> Le lun. 16 nov. 2020 à 18:53, Krzysztof Kozlowski <krzk@kernel.org> a écrit
> :
> > The Ingenic DRM uses Common Clock Framework thus it cannot be built on
> > platforms without it (e.g. compile test on MIPS with RALINK and
> > SOC_RT305X):
> > 
> >     /usr/bin/mips-linux-gnu-ld:
> > drivers/gpu/drm/ingenic/ingenic-drm-drv.o: in function
> > `ingenic_drm_bind.isra.0':
> >     ingenic-drm-drv.c:(.text+0x1600): undefined reference to
> > `clk_get_parent'
> >     /usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0):
> > undefined reference to `clk_get_parent'
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Acked-by: Paul Cercueil <paul@crapouillou.net>

Thanks for the ack.

David and Daniel,
I think there is no dedicated maintainer for Ingenic DRM, so can you
pick it up directly?

Best regards,
Krzysztof
Paul Cercueil Dec. 4, 2020, 10:07 a.m. UTC | #2
Hi Krzysztof,

Le ven. 4 déc. 2020 à 10:18, Krzysztof Kozlowski <krzk@kernel.org> a 
écrit :
> On Mon, Nov 16, 2020 at 07:54:03PM +0000, Paul Cercueil wrote:

>>  Hi Krzysztof,

>> 

>>  Le lun. 16 nov. 2020 à 18:53, Krzysztof Kozlowski 

>> <krzk@kernel.org> a écrit

>>  :

>>  > The Ingenic DRM uses Common Clock Framework thus it cannot be 

>> built on

>>  > platforms without it (e.g. compile test on MIPS with RALINK and

>>  > SOC_RT305X):

>>  >

>>  >     /usr/bin/mips-linux-gnu-ld:

>>  > drivers/gpu/drm/ingenic/ingenic-drm-drv.o: in function

>>  > `ingenic_drm_bind.isra.0':

>>  >     ingenic-drm-drv.c:(.text+0x1600): undefined reference to

>>  > `clk_get_parent'

>>  >     /usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0):

>>  > undefined reference to `clk_get_parent'

>>  >

>>  > Reported-by: kernel test robot <lkp@intel.com>

>>  > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

>> 

>>  Acked-by: Paul Cercueil <paul@crapouillou.net>

> 

> Thanks for the ack.

> 

> David and Daniel,

> I think there is no dedicated maintainer for Ingenic DRM, so can you

> pick it up directly?


I am. Pushed to drm-misc-next, thanks!

-Paul
diff mbox series

Patch

diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
index 477d5387e43e..3b57f8be007c 100644
--- a/drivers/gpu/drm/ingenic/Kconfig
+++ b/drivers/gpu/drm/ingenic/Kconfig
@@ -4,6 +4,7 @@  config DRM_INGENIC
 	depends on DRM
 	depends on CMA
 	depends on OF
+	depends on COMMON_CLK
 	select DRM_BRIDGE
 	select DRM_PANEL_BRIDGE
 	select DRM_KMS_HELPER