From patchwork Thu Jun 26 18:45:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Rae X-Patchwork-Id: 32592 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f198.google.com (mail-ie0-f198.google.com [209.85.223.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A5EAB201EF for ; Thu, 26 Jun 2014 18:46:32 +0000 (UTC) Received: by mail-ie0-f198.google.com with SMTP id y20sf22015595ier.5 for ; Thu, 26 Jun 2014 11:46:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=GxOmLVlAFZeMRrxu1aSwC96jOiCTmvHzZw1gMmHHa8Y=; b=Y11q60LlrDneKfTRePZVlmJ2xNfibXjZiGfW+Eryu5AotdP68Wgvb3J1TuC+LwX/Qm oM1X7A/tby7JLCmghiVymFGtsuVbjImwNv3/wn/LNyRi3wZwdyX444+vWDsJ2R5X4UUO 1pTS/0Yw50RWNCi4dg4mqbAY/a8FzAQOSDmNwYD2vW6GY9O8udeq1pf+6wRbOFEtRxjm D+IgQa4FrI9PyQ/f4c1EL9ZCTI7pnQByu7ITU1XnvJ2btgMFHV+zc20mgzcFWzsaE6Cb sHjvlMxX7ZAF/61Tli/smOua3iSRrhZ3hWWRCfgLkkW69T6jkd/d1l+U1vwELzXRvGnf 9Aiw== X-Gm-Message-State: ALoCoQmrgE4WJ/yOgW8ZmWNsFPn8+7ja28pFX9QT2KCei1P/TbgWA7Tk27htQGiHRggd8JSz+NpJ X-Received: by 10.182.241.169 with SMTP id wj9mr8827546obc.14.1403808392145; Thu, 26 Jun 2014 11:46:32 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.100.208 with SMTP id s74ls327801qge.68.gmail; Thu, 26 Jun 2014 11:46:32 -0700 (PDT) X-Received: by 10.53.1.164 with SMTP id bh4mr2044054vdd.89.1403808392057; Thu, 26 Jun 2014 11:46:32 -0700 (PDT) Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by mx.google.com with ESMTPS id wz6si5166355vcb.13.2014.06.26.11.46.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Jun 2014 11:46:32 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.173 as permitted sender) client-ip=209.85.128.173; Received: by mail-ve0-f173.google.com with SMTP id db11so4177923veb.18 for ; Thu, 26 Jun 2014 11:46:32 -0700 (PDT) X-Received: by 10.220.174.137 with SMTP id t9mr15606240vcz.12.1403808391979; Thu, 26 Jun 2014 11:46:31 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp51233vcb; Thu, 26 Jun 2014 11:46:31 -0700 (PDT) X-Received: by 10.152.244.162 with SMTP id xh2mr12779628lac.30.1403808390799; Thu, 26 Jun 2014 11:46:30 -0700 (PDT) Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id uw4si11224993wjc.48.2014.06.26.11.46.30 for ; Thu, 26 Jun 2014 11:46:30 -0700 (PDT) Received-SPF: none (google.com: u-boot-bounces@lists.denx.de does not designate permitted sender hosts) client-ip=85.214.87.163; Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 257D4A7757; Thu, 26 Jun 2014 20:46:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yRFMWEHXwOOC; Thu, 26 Jun 2014 20:46:23 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 49927A7773; Thu, 26 Jun 2014 20:46:18 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C9E5AA775A for ; Thu, 26 Jun 2014 20:46:13 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uRd0UlMZ1kcR for ; Thu, 26 Jun 2014 20:46:13 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-gw3-out.broadcom.com (mail-gw3-out.broadcom.com [216.31.210.64]) by theia.denx.de (Postfix) with ESMTP id 4C30EA775E for ; Thu, 26 Jun 2014 20:45:53 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.01,554,1400050800"; d="scan'208";a="36176659" Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57]) by mail-gw3-out.broadcom.com with ESMTP; 26 Jun 2014 11:52:12 -0700 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 26 Jun 2014 11:45:52 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.3.174.1; Thu, 26 Jun 2014 11:45:52 -0700 Received: from mail.broadcom.com (lbrmn-vmlnx03.ric.broadcom.com [10.136.4.105]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 4C0459FA14; Thu, 26 Jun 2014 11:45:41 -0700 (PDT) From: Steve Rae To: Rob Herring , Sebastian Siewior Date: Thu, 26 Jun 2014 11:45:18 -0700 Message-ID: <1403808318-16215-5-git-send-email-srae@broadcom.com> X-Mailer: git-send-email 1.8.5 In-Reply-To: <1403808318-16215-1-git-send-email-srae@broadcom.com> References: <1403808318-16215-1-git-send-email-srae@broadcom.com> MIME-Version: 1.0 Cc: Marek Vasut , Steve Rae , Pantelis Antoniou , u-boot@lists.denx.de, Tom Rini Subject: [U-Boot] [PATCH v2 4/4] usb/gadget: fastboot: minor cleanup X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: srae@broadcom.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 - update static function - additional debugging statements Signed-off-by: Steve Rae --- Changes in v2: - new in v2 drivers/usb/gadget/f_fastboot.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c index 89c2d3e..3e6e47f 100644 --- a/drivers/usb/gadget/f_fastboot.c +++ b/drivers/usb/gadget/f_fastboot.c @@ -293,7 +293,7 @@ static int fastboot_add(struct usb_configuration *c) } DECLARE_GADGET_BIND_CALLBACK(usb_dnl_fastboot, fastboot_add); -int fastboot_tx_write(const char *buffer, unsigned int buffer_size) +static int fastboot_tx_write(const char *buffer, unsigned int buffer_size) { struct usb_request *in_req = fastboot_func->in_req; int ret; @@ -338,6 +338,7 @@ static void cb_getvar(struct usb_ep *ep, struct usb_request *req) strcpy(response, "OKAY"); strsep(&cmd, ":"); if (!cmd) { + printf("%s: missing var\n", __func__); fastboot_tx_write_str("FAILmissing var"); return; } @@ -358,6 +359,7 @@ static void cb_getvar(struct usb_ep *ep, struct usb_request *req) else strcpy(response, "FAILValue not set"); } else { + printf("%s: unknown variable: %s\n", __func__, cmd); strcpy(response, "FAILVariable not implemented"); } fastboot_tx_write_str(response); @@ -531,10 +533,12 @@ static void rx_handler_command(struct usb_ep *ep, struct usb_request *req) } } - if (!func_cb) + if (!func_cb) { + printf("%s: unknown command: %s\n", __func__, cmdbuf); fastboot_tx_write_str("FAILunknown command"); - else + } else { func_cb(ep, req); + } if (req->status == 0) { *cmdbuf = '\0';