diff mbox

[Xen-devel,RFC,01/19] HACK: Add -fshort-wchar to global build

Message ID 1403918735-30027-2-git-send-email-roy.franz@linaro.org
State New
Headers show

Commit Message

Roy Franz June 28, 2014, 1:25 a.m. UTC
The EFI related code needs to be buil with "-fshort-wchar", as EFI
defines 16 bit wide characters and uses them in various APIs.
This fixes the prelink target build failures in the arch/x86 directory,
and is needed for the ARM EFI stub files as well.  The prelink build
failures may only happen during parallel builds.

This will be removed as part of getting the x86 and ARM archs to share
code and have it built correctly.

Signed-off-by: Roy Franz <roy.franz@linaro.org>
---
 Config.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jan Beulich June 30, 2014, 11:13 a.m. UTC | #1
>>> On 28.06.14 at 03:25, <roy.franz@linaro.org> wrote:
> The EFI related code needs to be buil with "-fshort-wchar", as EFI
> defines 16 bit wide characters and uses them in various APIs.
> This fixes the prelink target build failures in the arch/x86 directory,
> and is needed for the ARM EFI stub files as well.  The prelink build
> failures may only happen during parallel builds.
> 
> This will be removed as part of getting the x86 and ARM archs to share
> code and have it built correctly.

And I'm sure if you ordered things suitable this could be avoided.
IOW I'm not seeing this change go in.

Jan
diff mbox

Patch

diff --git a/Config.mk b/Config.mk
index 5e03e87..b323c59 100644
--- a/Config.mk
+++ b/Config.mk
@@ -189,6 +189,8 @@  CFLAGS += -std=gnu99
 
 CFLAGS += -Wall -Wstrict-prototypes
 
+CFLAGS += -fshort-wchar
+
 # Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...'
 # and is over-zealous with the printf format lint
 # and is a bit too fierce about unused return values