diff mbox

[RFC] Bluetooth: Fallback to SCO on error code 0x10 (Connection Accept Timeout).

Message ID 1404107701-19096-1-git-send-email-kiran.kumar@linaro.org
State New
Headers show

Commit Message

Kiran Kumar Raparthy June 30, 2014, 5:55 a.m. UTC 
From: Nick Pelly <npelly@google.com>

Fallback to SCO on error code 0x10 (Connection Accept Timeout).

This is to support the Motorola HF850 carkit which reports the error code 0x10
for an eSCO attempt, even though it advertises eSCO support.

With this patch we will retry with a SCO connection, which succeeds.

This is one of the number of patches from the Android AOSP common.git tree,
which is used on almost all Android devices.  I wanted to submit it for review
to see if it should go upstream.

Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Gustavo Padovan <gustavo@padovan.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: linux-bluetooth@vger.kernel.org
Cc: John Stultz <john.stultz@linaro.org>
Signed-off-by: Nick Pelly <npelly@google.com>
[kiran: Added context to commit message]
Signed-off-by: Kiran Kumar Raparthy <kiran.kumar@linaro.org>
---
 net/bluetooth/hci_event.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Marcel Holtmann July 1, 2014, 9:47 a.m. UTC | #1 
Hi Kiran,

> Fallback to SCO on error code 0x10 (Connection Accept Timeout).

no need to duplicate the subject line here.

> This is to support the Motorola HF850 carkit which reports the error code 0x10
> for an eSCO attempt, even though it advertises eSCO support.
> 
> With this patch we will retry with a SCO connection, which succeeds.
> 
> This is one of the number of patches from the Android AOSP common.git tree,
> which is used on almost all Android devices.  I wanted to submit it for review
> to see if it should go upstream.

such comments for the reviews belong after the diffstat.

> 
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Gustavo Padovan <gustavo@padovan.org>
> Cc: Johan Hedberg <johan.hedberg@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: linux-bluetooth@vger.kernel.org
> Cc: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Nick Pelly <npelly@google.com>
> [kiran: Added context to commit message]
> Signed-off-by: Kiran Kumar Raparthy <kiran.kumar@linaro.org>

I said this before and let me repeat this, please only submit this to linux-bluetooth mailing list. There is no point in spamming LKML or netdev since nobody there will actually review your patch.

> ---
> net/bluetooth/hci_event.c | 1 +
> 1 file changed, 1 insertion(+)

Patch has been applied to bluetooth-next tree.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 15010a2..754a136 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -3223,6 +3223,7 @@  static void hci_sync_conn_complete_evt(struct hci_dev *hdev,
 		hci_conn_add_sysfs(conn);
 		break;
 
+	case 0x10:	/* Connection Accept Timeout */
 	case 0x0d:	/* Connection Rejected due to Limited Resources */
 	case 0x11:	/* Unsupported Feature or Parameter Value */
 	case 0x1c:	/* SCO interval rejected */