diff mbox series

selftests/seccomp: powerpc: Fix typo in macro variable name

Message ID 20201117210104.1000661-1-keescook@chromium.org
State Accepted
Commit f5098e34dd4c774c3040e417960f1637e5daade8
Headers show
Series selftests/seccomp: powerpc: Fix typo in macro variable name | expand

Commit Message

Kees Cook Nov. 17, 2020, 9:01 p.m. UTC
A typo sneaked into the powerpc selftest. Fix the name so it builds again.

Fixes: 46138329faea ("selftests/seccomp: powerpc: Fix seccomp return value testing")
Signed-off-by: Kees Cook <keescook@chromium.org>
---
 tools/testing/selftests/seccomp/seccomp_bpf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Ellerman Nov. 19, 2020, 6:03 a.m. UTC | #1
Kees Cook <keescook@chromium.org> writes:
> A typo sneaked into the powerpc selftest. Fix the name so it builds again.

>

> Fixes: 46138329faea ("selftests/seccomp: powerpc: Fix seccomp return value testing")

> Signed-off-by: Kees Cook <keescook@chromium.org>

> ---

>  tools/testing/selftests/seccomp/seccomp_bpf.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)


I hit that and thought I'd sent a patch for it, but seems I never
actually sent it.

So thanks. I assume Shuah will take it.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>


cheers


> diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c

> index 76c458055c54..26c72f2b61b1 100644

> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c

> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c

> @@ -1758,10 +1758,10 @@ TEST_F(TRACE_poke, getpid_runs_normally)

>  		 * and the code is stored as a positive value.	\

>  		 */						\

>  		if (_result < 0) {				\

> -			SYSCALL_RET(_regs) = -result;		\

> +			SYSCALL_RET(_regs) = -_result;		\

>  			(_regs).ccr |= 0x10000000;		\

>  		} else {					\

> -			SYSCALL_RET(_regs) = result;		\

> +			SYSCALL_RET(_regs) = _result;		\

>  			(_regs).ccr &= ~0x10000000;		\

>  		}						\

>  	} while (0)

> -- 

> 2.25.1
diff mbox series

Patch

diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
index 76c458055c54..26c72f2b61b1 100644
--- a/tools/testing/selftests/seccomp/seccomp_bpf.c
+++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
@@ -1758,10 +1758,10 @@  TEST_F(TRACE_poke, getpid_runs_normally)
 		 * and the code is stored as a positive value.	\
 		 */						\
 		if (_result < 0) {				\
-			SYSCALL_RET(_regs) = -result;		\
+			SYSCALL_RET(_regs) = -_result;		\
 			(_regs).ccr |= 0x10000000;		\
 		} else {					\
-			SYSCALL_RET(_regs) = result;		\
+			SYSCALL_RET(_regs) = _result;		\
 			(_regs).ccr &= ~0x10000000;		\
 		}						\
 	} while (0)