From patchwork Tue Jul 1 09:51:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sekhar Nori X-Patchwork-Id: 32863 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f72.google.com (mail-qg0-f72.google.com [209.85.192.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5046F20672 for ; Tue, 1 Jul 2014 09:51:56 +0000 (UTC) Received: by mail-qg0-f72.google.com with SMTP id q107sf7610294qgd.11 for ; Tue, 01 Jul 2014 02:51:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:cc:subject:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=xenCKz0MdT6+aZPrWnZ3EXjUyvLznaQJxpvbuiLzB0k=; b=DurzMNsAijrIqExJS25C7MQU/ddv06DbdE0aPNkeQLpfRkXSQHS4TtYqN5atURwgy+ fmzTTHwUMuh/UdcLmaxHkitoLwMjU4Xs61L+wvXsuUa++7NfjkjB8VeIj9kIRYIg0Wfr RBhM5gpK65gR1WTFHMCYqayC+h64hmSwQ7NasU2DlOjMuJGMAwhtFUXrk1MXgX2MK0xZ dAW1HCEPbw8eMuJR7yz1cyYwT5Iakkyz1Nxc+sv+TkEbw/sK1jJnZ22QFajTBii62u9k B/wZoRcocfv9/aWKnCiT+yfbA/MRuD1Uyu1OhmeEuSbGv//SLDWJUjY4XVkRwAHrtNGZ G3sw== X-Gm-Message-State: ALoCoQkl580trWOa4oZp2IgYPa7cNDyKJKd1H40GLPGoDNCEArv1ukm+YgO7w4Q3qv6AXz5KBPo4 X-Received: by 10.224.97.8 with SMTP id j8mr24545157qan.0.1404208315929; Tue, 01 Jul 2014 02:51:55 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.94.163 with SMTP id g32ls555778qge.17.gmail; Tue, 01 Jul 2014 02:51:55 -0700 (PDT) X-Received: by 10.221.49.200 with SMTP id vb8mr29828034vcb.17.1404208315828; Tue, 01 Jul 2014 02:51:55 -0700 (PDT) Received: from mail-ve0-f175.google.com (mail-ve0-f175.google.com [209.85.128.175]) by mx.google.com with ESMTPS id cn9si11198707vcb.71.2014.07.01.02.51.55 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 01 Jul 2014 02:51:55 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.175 as permitted sender) client-ip=209.85.128.175; Received: by mail-ve0-f175.google.com with SMTP id jx11so9287425veb.6 for ; Tue, 01 Jul 2014 02:51:55 -0700 (PDT) X-Received: by 10.220.69.72 with SMTP id y8mr43455243vci.21.1404208315759; Tue, 01 Jul 2014 02:51:55 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp202625vcb; Tue, 1 Jul 2014 02:51:55 -0700 (PDT) X-Received: by 10.68.230.194 with SMTP id ta2mr59265984pbc.51.1404208315012; Tue, 01 Jul 2014 02:51:55 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gu3si26333321pbb.232.2014.07.01.02.51.54; Tue, 01 Jul 2014 02:51:54 -0700 (PDT) Received-SPF: none (google.com: linux-omap-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755948AbaGAJvw (ORCPT + 6 others); Tue, 1 Jul 2014 05:51:52 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:35811 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755731AbaGAJvv (ORCPT ); Tue, 1 Jul 2014 05:51:51 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s619pjLi010329; Tue, 1 Jul 2014 04:51:45 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s619pjCA020439; Tue, 1 Jul 2014 04:51:45 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.174.1; Tue, 1 Jul 2014 04:51:45 -0500 Received: from [172.24.190.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s619pgUv009955; Tue, 1 Jul 2014 04:51:43 -0500 Message-ID: <53B284AE.3070302@ti.com> Date: Tue, 1 Jul 2014 15:21:42 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Nick Dyer CC: Stephen Warren , , Linux OMAP List , Dmitry Torokhov Subject: atmel_mxt_ts: defaulting irqflags to IRQF_TRIGGER_FALLING Sender: linux-omap-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: nsekhar@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.175 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Nick, I have been using your for-next branch to base my development of touchscreen support on TI's DRA7x EVM. With the recent updates, it has worked out great and once I got the configuration right, it was just a question of adding DT data for the platform. Now, there is one problem with Stephen's patch defaulting the irqflags to IRQF_TRIGGER_FALLING. The interrupt controller I am using (ARM GIC) does not seem to support that and the device fails to probe: [ 1.932798] genirq: Setting trigger mode 2 for irq 151 failed (gic_set_type+0x0/0xf0) [ 1.941340] atmel_mxt_ts 0-004a: Failed to register interrupt [ 1.947452] atmel_mxt_ts: probe of 0-004a failed with error -22 Attached patch does the trick for me: Can you switch to leaving the platform to specify flags (at least for the DT case)? Thanks, Sekhar --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 71154c2..f2d3f72 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -3155,9 +3155,6 @@ static struct mxt_platform_data *mxt_parse_dt(struct i2c_client *client) pdata->gpio_reset = of_get_named_gpio_flags(dev->of_node, "atmel,reset-gpio", 0, NULL); - /* Default to this. Properties can be added to configure it later */ - pdata->irqflags = IRQF_TRIGGER_FALLING; - of_property_read_string(dev->of_node, "atmel,cfg_name", &pdata->cfg_name);