diff mbox

[Xen-devel,v2] xen/arm: Small fixes after GICv2 changes by commit ee65c87

Message ID 1404307160-4883-1-git-send-email-julien.grall@linaro.org
State Accepted, archived
Headers show

Commit Message

Julien Grall July 2, 2014, 1:19 p.m. UTC 
The commit ee65c87 moves the GICv2 code in a separate file. Even though this
patch is only deals with code movement, a comment was modify for no reason.

Also rename gicv_v2_init into gicv2v_setup which is what the function does
and less confusing with the other function called gicv2_init.

Signed-off-by: Julien Grall <julien.grall@linaro.org>

---
    Changes in v2:
        - Update the caller of gic_v2_init
---
 xen/arch/arm/gic-v2.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Ian Campbell July 3, 2014, 11:14 a.m. UTC | #1 
On Wed, 2014-07-02 at 14:19 +0100, Julien Grall wrote:
> The commit ee65c87 moves the GICv2 code in a separate file. Even though this
> patch is only deals with code movement, a comment was modify for no reason.
> 
> Also rename gicv_v2_init into gicv2v_setup which is what the function does
> and less confusing with the other function called gicv2_init.
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>

Acked + applied. Thanks.
diff mbox

Patch

diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
index 695c232..cc60af8 100644
--- a/xen/arch/arm/gic-v2.c
+++ b/xen/arch/arm/gic-v2.c
@@ -372,12 +372,12 @@  static void gicv2_clear_lr(int lr)
     writel_relaxed(0, GICH + GICH_LR + lr * 4);
 }
 
-static int gicv_v2_init(struct domain *d)
+static int gicv2v_setup(struct domain *d)
 {
     int ret;
 
     /*
-     * Domain 0 gets the hardware address.
+     * The hardware domain gets the hardware address.
      * Guests get the virtual platform layout.
      */
     if ( is_hardware_domain(d) )
@@ -566,7 +566,7 @@  const static struct gic_hw_operations gicv2_ops = {
     .save_state          = gicv2_save_state,
     .restore_state       = gicv2_restore_state,
     .dump_state          = gicv2_dump_state,
-    .gicv_setup          = gicv_v2_init,
+    .gicv_setup          = gicv2v_setup,
     .gic_host_irq_type   = &gicv2_host_irq_type,
     .gic_guest_irq_type  = &gicv2_guest_irq_type,
     .eoi_irq             = gicv2_eoi_irq,