diff mbox series

[11/40] drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra param description

Message ID 20201123111919.233376-12-lee.jones@linaro.org
State New
Headers show
Series Rid W=1 warnings from GPU | expand

Commit Message

Lee Jones Nov. 23, 2020, 11:18 a.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c:28: warning: Function parameter or member 'hw_blk' not described in 'dpu_hw_blk_init'
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c:120: warning: Excess function parameter 'free_blk' description in 'dpu_hw_blk_put'

Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.25.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

Abhinav Kumar Nov. 23, 2020, 9:06 p.m. UTC | #1
On 2020-11-23 03:18, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c:28: warning: Function

> parameter or member 'hw_blk' not described in 'dpu_hw_blk_init'

>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c:120: warning: Excess

> function parameter 'free_blk' description in 'dpu_hw_blk_put'

> 

> Cc: Rob Clark <robdclark@gmail.com>

> Cc: Sean Paul <sean@poorly.run>

> Cc: David Airlie <airlied@linux.ie>

> Cc: Daniel Vetter <daniel@ffwll.ch>

> Cc: linux-arm-msm@vger.kernel.org

> Cc: dri-devel@lists.freedesktop.org

> Cc: freedreno@lists.freedesktop.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>

> ---

>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c

> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c

> index ca26666d2af91..819b26e660b9c 100644

> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c

> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c

> @@ -19,6 +19,7 @@ static LIST_HEAD(dpu_hw_blk_list);

> 

>  /**

>   * dpu_hw_blk_init - initialize hw block object

> + * @hw_blk: pointer to hw block object

>   * @type: hw block type - enum dpu_hw_blk_type

>   * @id: instance id of the hw block

>   * @ops: Pointer to block operations

> @@ -114,7 +115,6 @@ struct dpu_hw_blk *dpu_hw_blk_get(struct

> dpu_hw_blk *hw_blk, u32 type, int id)

>  /**

>   * dpu_hw_blk_put - put hw_blk to free pool if decremented refcount is 

> zero

>   * @hw_blk: hw block to be freed

> - * @free_blk: function to be called when reference count goes to zero

>   */

>  void dpu_hw_blk_put(struct dpu_hw_blk *hw_blk)

>  {

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
index ca26666d2af91..819b26e660b9c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
@@ -19,6 +19,7 @@  static LIST_HEAD(dpu_hw_blk_list);
 
 /**
  * dpu_hw_blk_init - initialize hw block object
+ * @hw_blk: pointer to hw block object
  * @type: hw block type - enum dpu_hw_blk_type
  * @id: instance id of the hw block
  * @ops: Pointer to block operations
@@ -114,7 +115,6 @@  struct dpu_hw_blk *dpu_hw_blk_get(struct dpu_hw_blk *hw_blk, u32 type, int id)
 /**
  * dpu_hw_blk_put - put hw_blk to free pool if decremented refcount is zero
  * @hw_blk: hw block to be freed
- * @free_blk: function to be called when reference count goes to zero
  */
 void dpu_hw_blk_put(struct dpu_hw_blk *hw_blk)
 {