From patchwork Sat Jul 5 17:01:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 33120 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f197.google.com (mail-qc0-f197.google.com [209.85.216.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 7EE2B20C88 for ; Sat, 5 Jul 2014 17:02:05 +0000 (UTC) Received: by mail-qc0-f197.google.com with SMTP id i8sf9228028qcq.8 for ; Sat, 05 Jul 2014 10:02:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:cc:subject:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=TZfNWgMMBsr+vQCwkmoTWHZDrZW1ocEYz5Sl/MBQTNw=; b=PW60kSARRbBhdpG+1PmQfYzBhPHJOPJIl37EIiBzOZ6mRV6vPLukJ/CENG5pEHkQQc c8uhrVXoGq9xUnnlXJViP0r7XeMRBEGedOgzdMAfxLcPxdWRwtXnwd1cqmDcIAxGitFe umayMBcG0xSr11JfqwQtGEGW/1Xjj1zi7ya8rgntr+F3Awo2BZQlJEwjJOjRo+IxXKp2 rNax/aJRaO2nblF+Vr5PVoQ0oTyIATrXeJebiB/S+l1UymBg7068WW+GHhi95HYSYSnM w9N1yNBpBYZybX9FK73i/G7GNgpVBgnBbmi4l2Y2bpWd9p7AmIa7/txRvP2me9zE78tH 0+Lg== X-Gm-Message-State: ALoCoQmcjyrVAWcXqu5r1fa4T92S4vY2ywCkqIwAtzUG0ekKwQCGTfVVPXkQg1igwOdhYtktogvz X-Received: by 10.58.152.143 with SMTP id uy15mr9105843veb.27.1404579725010; Sat, 05 Jul 2014 10:02:05 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.41.100 with SMTP id y91ls1256102qgy.60.gmail; Sat, 05 Jul 2014 10:02:04 -0700 (PDT) X-Received: by 10.220.92.193 with SMTP id s1mr1367008vcm.34.1404579724881; Sat, 05 Jul 2014 10:02:04 -0700 (PDT) Received: from mail-ve0-f171.google.com (mail-ve0-f171.google.com [209.85.128.171]) by mx.google.com with ESMTPS id dx8si16819577vdb.24.2014.07.05.10.02.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 05 Jul 2014 10:02:04 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.171 as permitted sender) client-ip=209.85.128.171; Received: by mail-ve0-f171.google.com with SMTP id jz11so2629039veb.30 for ; Sat, 05 Jul 2014 10:02:04 -0700 (PDT) X-Received: by 10.220.166.9 with SMTP id k9mr16191642vcy.20.1404579724628; Sat, 05 Jul 2014 10:02:04 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp537475vcb; Sat, 5 Jul 2014 10:02:04 -0700 (PDT) X-Received: by 10.181.11.232 with SMTP id el8mr25804504wid.57.1404579723518; Sat, 05 Jul 2014 10:02:03 -0700 (PDT) Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id mb9si43487321wjb.22.2014.07.05.10.02.02 for ; Sat, 05 Jul 2014 10:02:03 -0700 (PDT) Received-SPF: none (google.com: alsa-devel-bounces@alsa-project.org does not designate permitted sender hosts) client-ip=77.48.224.243; Received: by alsa0.perex.cz (Postfix, from userid 1000) id A317B265543; Sat, 5 Jul 2014 19:02:01 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=disabled version=3.2.4 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 9E846265535; Sat, 5 Jul 2014 19:01:50 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0CA70265537; Sat, 5 Jul 2014 19:01:49 +0200 (CEST) Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id C5E4C265532 for ; Sat, 5 Jul 2014 19:01:40 +0200 (CEST) Received: from cpc11-sgyl31-2-0-cust672.sgyl.cable.virginm.net ([94.175.94.161] helo=debutante.sirena.org.uk) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1X3TL8-0006pt-2g; Sat, 05 Jul 2014 17:01:34 +0000 Received: from broonie by debutante.sirena.org.uk with local (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1X3TL5-0002Da-7h; Sat, 05 Jul 2014 18:01:27 +0100 From: Mark Brown To: alsa-devel@alsa-project.org Date: Sat, 5 Jul 2014 18:01:26 +0100 Message-Id: <1404579686-8491-1-git-send-email-broonie@kernel.org> X-Mailer: git-send-email 2.0.0 X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Cc: linaro-kernel@lists.linaro.org, Mark Brown , Lars-Peter Clausen , =?UTF-8?q?Daniel=20Gl=C3=B6ckner?= Subject: [alsa-devel] [PATCH] ASoC: s6105-ipcam: Fix build for I2C dependencies X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: broonie@kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Mark Brown The s6105-ipcam driver calls i2c_register_board_info() which means that not only does it need I2C to be enabled to be built but since that symbol is not exported it means that the driver also can't be linked as a module. Use a bool instead of a tristate and add a dependency on I2C to fix these issues. Commit b5dd60fd263 (ASoC: s6000: Allow to build when COMPILE_TEST is enabled) made this problem more visible since it enabled build of the driver on more common architectures but this has always been an issue. Signed-off-by: Mark Brown --- sound/soc/s6000/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/s6000/Kconfig b/sound/soc/s6000/Kconfig index 4823e1e4daef..f244a2566f20 100644 --- a/sound/soc/s6000/Kconfig +++ b/sound/soc/s6000/Kconfig @@ -15,8 +15,9 @@ config SND_S6000_SOC_I2S tristate config SND_S6000_SOC_S6IPCAM - tristate "SoC Audio support for Stretch 6105 IP Camera" - depends on SND_S6000_SOC + bool "SoC Audio support for Stretch 6105 IP Camera" + depends on SND_S6000_SOC=y + depends on I2C=y depends on XTENSA_PLATFORM_S6105 || COMPILE_TEST select SND_S6000_SOC_I2S select SND_SOC_TLV320AIC3X