| Message ID | 1405014566-17547-1-git-send-email-steve.mcintyre@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 2014-07-10 18:49, steve.mcintyre@linaro.org wrote: > From: Steve McIntyre <steve.mcintyre@linaro.org> > > Add some documentation describing the minimum requirements and > recommended versions of tools and libraries for building ODP. > > This initial checkin just mentions the Linux kernel and autotools. > > Signed-off-by: Steve McIntyre <steve.mcintyre@linaro.org> > --- Another nit: I guess Maxim will take care of this before he applies the patch or do you want to fix it? $ git am ~/incoming/lng-odp_PATCH_v3_List_required-suggested_dependencies_for_ Applying: List required/suggested dependencies for building ODP /home/anders/src/odp/.git/rebase-apply/patch:31: new blank line at EOF. + warning: 1 line adds whitespace errors. Cheers, Anders > DEPENDENCIES | 19 +++++++++++++++++++ > README | 1 + > 2 files changed, 20 insertions(+) > create mode 100644 DEPENDENCIES > > diff --git a/DEPENDENCIES b/DEPENDENCIES > new file mode 100644 > index 0000000..a806b4d > --- /dev/null > +++ b/DEPENDENCIES > @@ -0,0 +1,19 @@ > +Prerequisites for building the OpenDataPlane (ODP) API > + > +1. Linux kernel >= 3.0 > + > + Version 3.0+ needed for the sendmmsg() interface > + > +2. autotools > + > + automake > + autoconf > + autoconf-archive > + libtool > + > + On Debian/Ubuntu systems: > + $ sudo apt-get install automake autoconf autoconf-archive libtool > + > + On CentOS/RedHat/Fedora systems: > + $ sudo yum install automake autoconf autoconf-archive libtool libtoolize > + > diff --git a/README b/README > index 36545dd..7ecc655 100644 > --- a/README > +++ b/README > @@ -19,6 +19,7 @@ Main git repository: > build directory. > For cross compiling set up appropriate CC: > make CC=armeb-linux-gnueabihf-gcc > + For a list of build dependencies, read DEPENDENCIES > > Make command options: > ODP_RELOC compile library with position independent code; > -- > 1.7.10.4 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp
Regarding whitespace, we should post some useful info on how to deal with this in the CONTRIBUTING section of the ODP web site. for emacs users, the command Meta-X delete-trailing-whitespace will tidy up a buffer being edited to ensure that these nits go away (execute this before saving the file and then doing your patch creation). I'm not a vim user, but a Google search reveals a number of ways to do this including this command: :%s/\s\+$// which should do the same. On Thu, Jul 10, 2014 at 4:10 PM, Anders Roxell <anders.roxell@linaro.org> wrote: > On 2014-07-10 18:49, steve.mcintyre@linaro.org wrote: > > From: Steve McIntyre <steve.mcintyre@linaro.org> > > > > Add some documentation describing the minimum requirements and > > recommended versions of tools and libraries for building ODP. > > > > This initial checkin just mentions the Linux kernel and autotools. > > > > Signed-off-by: Steve McIntyre <steve.mcintyre@linaro.org> > > --- > > Another nit: > I guess Maxim will take care of this before he applies the patch or do > you want to fix it? > > $ git am > ~/incoming/lng-odp_PATCH_v3_List_required-suggested_dependencies_for_ > Applying: List required/suggested dependencies for building ODP > /home/anders/src/odp/.git/rebase-apply/patch:31: new blank line at EOF. > + > warning: 1 line adds whitespace errors. > > > Cheers, > Anders > > > DEPENDENCIES | 19 +++++++++++++++++++ > > README | 1 + > > 2 files changed, 20 insertions(+) > > create mode 100644 DEPENDENCIES > > > > diff --git a/DEPENDENCIES b/DEPENDENCIES > > new file mode 100644 > > index 0000000..a806b4d > > --- /dev/null > > +++ b/DEPENDENCIES > > @@ -0,0 +1,19 @@ > > +Prerequisites for building the OpenDataPlane (ODP) API > > + > > +1. Linux kernel >= 3.0 > > + > > + Version 3.0+ needed for the sendmmsg() interface > > + > > +2. autotools > > + > > + automake > > + autoconf > > + autoconf-archive > > + libtool > > + > > + On Debian/Ubuntu systems: > > + $ sudo apt-get install automake autoconf autoconf-archive libtool > > + > > + On CentOS/RedHat/Fedora systems: > > + $ sudo yum install automake autoconf autoconf-archive libtool > libtoolize > > + > > diff --git a/README b/README > > index 36545dd..7ecc655 100644 > > --- a/README > > +++ b/README > > @@ -19,6 +19,7 @@ Main git repository: > > build directory. > > For cross compiling set up appropriate CC: > > make CC=armeb-linux-gnueabihf-gcc > > + For a list of build dependencies, read DEPENDENCIES > > > > Make command options: > > ODP_RELOC compile library with position independent code; > > -- > > 1.7.10.4 > > > > > > _______________________________________________ > > lng-odp mailing list > > lng-odp@lists.linaro.org > > http://lists.linaro.org/mailman/listinfo/lng-odp > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
Bill can you send a patch to odp/CONTRIBUTING to add that ? On 10 July 2014 17:26, Bill Fischofer <bill.fischofer@linaro.org> wrote: > Regarding whitespace, we should post some useful info on how to deal with > this in the CONTRIBUTING section of the ODP web site. > > for emacs users, the command > > Meta-X delete-trailing-whitespace > > will tidy up a buffer being edited to ensure that these nits go away > (execute this before saving the file and then doing your patch creation). > > I'm not a vim user, but a Google search reveals a number of ways to do > this including this command: > > :%s/\s\+$// > > which should do the same. > > > On Thu, Jul 10, 2014 at 4:10 PM, Anders Roxell <anders.roxell@linaro.org> > wrote: > >> On 2014-07-10 18:49, steve.mcintyre@linaro.org wrote: >> > From: Steve McIntyre <steve.mcintyre@linaro.org> >> > >> > Add some documentation describing the minimum requirements and >> > recommended versions of tools and libraries for building ODP. >> > >> > This initial checkin just mentions the Linux kernel and autotools. >> > >> > Signed-off-by: Steve McIntyre <steve.mcintyre@linaro.org> >> > --- >> >> Another nit: >> I guess Maxim will take care of this before he applies the patch or do >> you want to fix it? >> >> $ git am >> ~/incoming/lng-odp_PATCH_v3_List_required-suggested_dependencies_for_ >> Applying: List required/suggested dependencies for building ODP >> /home/anders/src/odp/.git/rebase-apply/patch:31: new blank line at EOF. >> + >> warning: 1 line adds whitespace errors. >> >> >> Cheers, >> Anders >> >> > DEPENDENCIES | 19 +++++++++++++++++++ >> > README | 1 + >> > 2 files changed, 20 insertions(+) >> > create mode 100644 DEPENDENCIES >> > >> > diff --git a/DEPENDENCIES b/DEPENDENCIES >> > new file mode 100644 >> > index 0000000..a806b4d >> > --- /dev/null >> > +++ b/DEPENDENCIES >> > @@ -0,0 +1,19 @@ >> > +Prerequisites for building the OpenDataPlane (ODP) API >> > + >> > +1. Linux kernel >= 3.0 >> > + >> > + Version 3.0+ needed for the sendmmsg() interface >> > + >> > +2. autotools >> > + >> > + automake >> > + autoconf >> > + autoconf-archive >> > + libtool >> > + >> > + On Debian/Ubuntu systems: >> > + $ sudo apt-get install automake autoconf autoconf-archive libtool >> > + >> > + On CentOS/RedHat/Fedora systems: >> > + $ sudo yum install automake autoconf autoconf-archive libtool >> libtoolize >> > + >> > diff --git a/README b/README >> > index 36545dd..7ecc655 100644 >> > --- a/README >> > +++ b/README >> > @@ -19,6 +19,7 @@ Main git repository: >> > build directory. >> > For cross compiling set up appropriate CC: >> > make CC=armeb-linux-gnueabihf-gcc >> > + For a list of build dependencies, read DEPENDENCIES >> > >> > Make command options: >> > ODP_RELOC compile library with position independent code; >> > -- >> > 1.7.10.4 >> > >> > >> > _______________________________________________ >> > lng-odp mailing list >> > lng-odp@lists.linaro.org >> > http://lists.linaro.org/mailman/listinfo/lng-odp >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp > >
Never Mind as I read into my mail today you already did :) On 11 July 2014 06:34, Mike Holmes <mike.holmes@linaro.org> wrote: > Bill can you send a patch to odp/CONTRIBUTING to add that ? > > > On 10 July 2014 17:26, Bill Fischofer <bill.fischofer@linaro.org> wrote: > >> Regarding whitespace, we should post some useful info on how to deal with >> this in the CONTRIBUTING section of the ODP web site. >> >> for emacs users, the command >> >> Meta-X delete-trailing-whitespace >> >> will tidy up a buffer being edited to ensure that these nits go away >> (execute this before saving the file and then doing your patch creation). >> >> I'm not a vim user, but a Google search reveals a number of ways to do >> this including this command: >> >> :%s/\s\+$// >> >> which should do the same. >> >> >> On Thu, Jul 10, 2014 at 4:10 PM, Anders Roxell <anders.roxell@linaro.org> >> wrote: >> >>> On 2014-07-10 18:49, steve.mcintyre@linaro.org wrote: >>> > From: Steve McIntyre <steve.mcintyre@linaro.org> >>> > >>> > Add some documentation describing the minimum requirements and >>> > recommended versions of tools and libraries for building ODP. >>> > >>> > This initial checkin just mentions the Linux kernel and autotools. >>> > >>> > Signed-off-by: Steve McIntyre <steve.mcintyre@linaro.org> >>> > --- >>> >>> Another nit: >>> I guess Maxim will take care of this before he applies the patch or do >>> you want to fix it? >>> >>> $ git am >>> ~/incoming/lng-odp_PATCH_v3_List_required-suggested_dependencies_for_ >>> Applying: List required/suggested dependencies for building ODP >>> /home/anders/src/odp/.git/rebase-apply/patch:31: new blank line at EOF. >>> + >>> warning: 1 line adds whitespace errors. >>> >>> >>> Cheers, >>> Anders >>> >>> > DEPENDENCIES | 19 +++++++++++++++++++ >>> > README | 1 + >>> > 2 files changed, 20 insertions(+) >>> > create mode 100644 DEPENDENCIES >>> > >>> > diff --git a/DEPENDENCIES b/DEPENDENCIES >>> > new file mode 100644 >>> > index 0000000..a806b4d >>> > --- /dev/null >>> > +++ b/DEPENDENCIES >>> > @@ -0,0 +1,19 @@ >>> > +Prerequisites for building the OpenDataPlane (ODP) API >>> > + >>> > +1. Linux kernel >= 3.0 >>> > + >>> > + Version 3.0+ needed for the sendmmsg() interface >>> > + >>> > +2. autotools >>> > + >>> > + automake >>> > + autoconf >>> > + autoconf-archive >>> > + libtool >>> > + >>> > + On Debian/Ubuntu systems: >>> > + $ sudo apt-get install automake autoconf autoconf-archive libtool >>> > + >>> > + On CentOS/RedHat/Fedora systems: >>> > + $ sudo yum install automake autoconf autoconf-archive libtool >>> libtoolize >>> > + >>> > diff --git a/README b/README >>> > index 36545dd..7ecc655 100644 >>> > --- a/README >>> > +++ b/README >>> > @@ -19,6 +19,7 @@ Main git repository: >>> > build directory. >>> > For cross compiling set up appropriate CC: >>> > make CC=armeb-linux-gnueabihf-gcc >>> > + For a list of build dependencies, read DEPENDENCIES >>> > >>> > Make command options: >>> > ODP_RELOC compile library with position independent code; >>> > -- >>> > 1.7.10.4 >>> > >>> > >>> > _______________________________________________ >>> > lng-odp mailing list >>> > lng-odp@lists.linaro.org >>> > http://lists.linaro.org/mailman/listinfo/lng-odp >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> http://lists.linaro.org/mailman/listinfo/lng-odp >>> >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> > > > -- > *Mike Holmes* > Linaro Technical Manager / Lead > LNG - ODP >
Applied, thanks, Maxim. On 07/10/2014 09:49 PM, steve.mcintyre@linaro.org wrote: > From: Steve McIntyre <steve.mcintyre@linaro.org> > > Add some documentation describing the minimum requirements and > recommended versions of tools and libraries for building ODP. > > This initial checkin just mentions the Linux kernel and autotools. > > Signed-off-by: Steve McIntyre <steve.mcintyre@linaro.org> > --- > DEPENDENCIES | 19 +++++++++++++++++++ > README | 1 + > 2 files changed, 20 insertions(+) > create mode 100644 DEPENDENCIES > > diff --git a/DEPENDENCIES b/DEPENDENCIES > new file mode 100644 > index 0000000..a806b4d > --- /dev/null > +++ b/DEPENDENCIES > @@ -0,0 +1,19 @@ > +Prerequisites for building the OpenDataPlane (ODP) API > + > +1. Linux kernel >= 3.0 > + > + Version 3.0+ needed for the sendmmsg() interface > + > +2. autotools > + > + automake > + autoconf > + autoconf-archive > + libtool > + > + On Debian/Ubuntu systems: > + $ sudo apt-get install automake autoconf autoconf-archive libtool > + > + On CentOS/RedHat/Fedora systems: > + $ sudo yum install automake autoconf autoconf-archive libtool libtoolize > + > diff --git a/README b/README > index 36545dd..7ecc655 100644 > --- a/README > +++ b/README > @@ -19,6 +19,7 @@ Main git repository: > build directory. > For cross compiling set up appropriate CC: > make CC=armeb-linux-gnueabihf-gcc > + For a list of build dependencies, read DEPENDENCIES > > Make command options: > ODP_RELOC compile library with position independent code;
diff --git a/DEPENDENCIES b/DEPENDENCIES new file mode 100644 index 0000000..a806b4d --- /dev/null +++ b/DEPENDENCIES @@ -0,0 +1,19 @@ +Prerequisites for building the OpenDataPlane (ODP) API + +1. Linux kernel >= 3.0 + + Version 3.0+ needed for the sendmmsg() interface + +2. autotools + + automake + autoconf + autoconf-archive + libtool + + On Debian/Ubuntu systems: + $ sudo apt-get install automake autoconf autoconf-archive libtool + + On CentOS/RedHat/Fedora systems: + $ sudo yum install automake autoconf autoconf-archive libtool libtoolize + diff --git a/README b/README index 36545dd..7ecc655 100644 --- a/README +++ b/README @@ -19,6 +19,7 @@ Main git repository: build directory. For cross compiling set up appropriate CC: make CC=armeb-linux-gnueabihf-gcc + For a list of build dependencies, read DEPENDENCIES Make command options: ODP_RELOC compile library with position independent code;