diff mbox series

[v3,2/2] dt-bindings: watchdog: Add bindings for Intel Keem Bay SoC

Message ID c3ffd4c2becada82c631ca035a3a1a8f0bd38dc8.1606833303.git.vijayakannan.ayyathurai@intel.com
State Superseded
Headers show
Series Add drivers for Intel Keem Bay SoC watchdog | expand

Commit Message

Vijayakannan Ayyathurai Dec. 1, 2020, 3:10 p.m. UTC
From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>

Add Device Tree binding document for Watchdog IP in the Intel Keem Bay SoC.

Signed-off-by: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>
Acked-by: Mark Gross <mgross@linux.intel.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 .../bindings/watchdog/intel,keembay-wdt.yaml  | 57 +++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml

Comments

Rob Herring Dec. 7, 2020, 6:23 p.m. UTC | #1
On Tue, 01 Dec 2020 23:10:34 +0800, vijayakannan.ayyathurai@intel.com wrote:
> From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>

> 

> Add Device Tree binding document for Watchdog IP in the Intel Keem Bay SoC.

> 

> Signed-off-by: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>

> Acked-by: Mark Gross <mgross@linux.intel.com>

> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> ---

>  .../bindings/watchdog/intel,keembay-wdt.yaml  | 57 +++++++++++++++++++

>  1 file changed, 57 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml

> 



Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.
Vijayakannan Ayyathurai Dec. 8, 2020, 2:21 a.m. UTC | #2
Hi Rob,

> From: Rob Herring <robh@kernel.org>

> 

> > From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>

> >

> > Add Device Tree binding document for Watchdog IP in the Intel Keem Bay

> SoC.

> >

> > Signed-off-by: Vijayakannan Ayyathurai

> <vijayakannan.ayyathurai@intel.com>

> > Acked-by: Mark Gross <mgross@linux.intel.com>

> > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> > ---

> >  .../bindings/watchdog/intel,keembay-wdt.yaml  | 57 +++++++++++++++++++

> >  1 file changed, 57 insertions(+)

> >  create mode 100644

> Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml

> >

> 

> 

> Please add Acked-by/Reviewed-by tags when posting new versions. However,

> there's no need to repost patches *only* to add the tags. The upstream

> maintainer will do that for acks received on the version they apply.

> 

> If a tag was not added on purpose, please state why and what changed.


Sure. It is my mistake. I will add your tag, when posting the next version.

Thanks,
Vijay
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml b/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml
new file mode 100644
index 000000000000..1437ff8a122f
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml
@@ -0,0 +1,57 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/intel,keembay-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Intel Keem Bay SoC non-secure Watchdog Timer
+
+maintainers:
+  - Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>
+
+properties:
+  compatible:
+    enum:
+      - intel,keembay-wdt
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  interrupts:
+    items:
+      - description: interrupt specifier for threshold interrupt line
+      - description: interrupt specifier for timeout interrupt line
+
+  interrupt-names:
+    items:
+      - const: threshold
+      - const: timeout
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #define KEEM_BAY_A53_TIM
+
+    watchdog: watchdog@2033009c {
+        compatible = "intel,keembay-wdt";
+        reg = <0x2033009c 0x10>;
+        interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
+        interrupt-names = "threshold", "timeout";
+        clocks = <&scmi_clk KEEM_BAY_A53_TIM>;
+    };
+
+...