| Message ID | 20201203124803.23390-3-info@metux.net |
|---|---|
| State | New |
| Headers | show |
| Series | [01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call | expand |
diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h index f2143a6e0e99..bf6478ab05dd 100644 --- a/drivers/staging/gdm724x/gdm_lte.h +++ b/drivers/staging/gdm724x/gdm_lte.h @@ -11,7 +11,6 @@ #define MAX_NIC_TYPE 4 #define MAX_RX_SUBMIT_COUNT 3 -#define DRIVER_VERSION "3.7.17.0" enum TX_ERROR_CODE { TX_NO_ERROR = 0, diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c index dc4da66c3695..aa6f08396396 100644 --- a/drivers/staging/gdm724x/gdm_usb.c +++ b/drivers/staging/gdm724x/gdm_usb.c @@ -1003,6 +1003,5 @@ static void __exit gdm_usb_lte_exit(void) module_init(gdm_usb_lte_init); module_exit(gdm_usb_lte_exit); -MODULE_VERSION(DRIVER_VERSION); MODULE_DESCRIPTION("GCT LTE USB Device Driver"); MODULE_LICENSE("GPL");
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-kernel drivers, the kernel version matters. And the code has received lots of changes, without the version ever been touched (remained constant since landing in the mainline tree), so it doesn't seem to have any practical meaning anymore. Signed-off-by: Enrico Weigelt <info@metux.net> --- drivers/staging/gdm724x/gdm_lte.h | 1 - drivers/staging/gdm724x/gdm_usb.c | 1 - 2 files changed, 2 deletions(-)