| Message ID | 20201205164300.28581-1-mickeyr@marvell.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] MAINTAINERS: Add entry for Marvell Prestera Ethernet Switch driver | expand |
On Sat, 5 Dec 2020 18:43:00 +0200 Mickey Rachamim wrote: > Add maintainers info for new Marvell Prestera Ethernet switch driver. > > Signed-off-by: Mickey Rachamim <mickeyr@marvell.com> > --- > v2: > Update the maintainers list according to community recommendation. > > MAINTAINERS | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 061e64b2423a..c92b44754436 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10550,6 +10550,14 @@ S: Supported > F: Documentation/networking/device_drivers/ethernet/marvell/octeontx2.rst > F: drivers/net/ethernet/marvell/octeontx2/af/ > > +MARVELL PRESTERA ETHERNET SWITCH DRIVER > +M: Vadym Kochan <vkochan@marvell.com> > +M: Taras Chornyi <tchornyi@marvell.com> Just a heads up, again, we'll start removing maintainers who aren't participating, so Taras needs to be active. We haven't seen a single email from him so far AFAICT. > +L: netdev@vger.kernel.org nit: I don't think you need to list netdev, it'll get inherited from the general entry for networking drivers (you can test running get_maintainer.pl on a patch to the driver and see if it reports it). > +S: Supported > +W: http://www.marvell.com The website entry is for a project-specific website. If you have a link to a site with open resources about the chips/driver that'd be great, otherwise please drop it. Also https is expected these days ;) > +F: drivers/net/ethernet/marvell/prestera/ > + > MARVELL SOC MMC/SD/SDIO CONTROLLER DRIVER > M: Nicolas Pitre <nico@fluxnic.net> > S: Odd Fixes
Hi Jakub, thanks for the guidelines. > On Sat, 5 Dec 2020 18:43:00 +0200 Mickey Rachamim wrote: > > Add maintainers info for new Marvell Prestera Ethernet switch driver. > > > > Signed-off-by: Mickey Rachamim <mickeyr@marvell.com> > > --- > > v2: > > Update the maintainers list according to community recommendation. > > > > MAINTAINERS | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS index > > 061e64b2423a..c92b44754436 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -10550,6 +10550,14 @@ S: Supported > > F: Documentation/networking/device_drivers/ethernet/marvell/octeontx2.rst > > F: drivers/net/ethernet/marvell/octeontx2/af/ > > > > +MARVELL PRESTERA ETHERNET SWITCH DRIVER > > +M: Vadym Kochan <vkochan@marvell.com> > > +M: Taras Chornyi <tchornyi@marvell.com> > > Just a heads up, again, we'll start removing maintainers who aren't participating, so Taras needs to be active. We haven't seen a single email from him so far AFAICT. > Fully clear, Taras is an expert on Linux kernel code working on PLVision and under contract with Marvell. He will became active on contributions and reviews very soon. > > +L: netdev@vger.kernel.org > > nit: I don't think you need to list netdev, it'll get inherited from the general entry for networking drivers (you can test running get_maintainer.pl on a patch to the driver and see if it reports it). Right, will remove. > > +S: Supported > > +W: http://www.marvell.com > > The website entry is for a project-specific website. If you have a link to a site with open resources about the chips/driver that'd be great, otherwise please drop it. Also https is expected these days ;) Can I placed here the Github project link? https://github.com/Marvell-switching/switchdev-prestera
On Tue, 8 Dec 2020 09:22:52 +0000 Mickey Rachamim wrote: > > > +S: Supported > > > +W: http://www.marvell.com > > > > The website entry is for a project-specific website. If you have a link to a site with open resources about the chips/driver that'd be great, otherwise please drop it. Also https is expected these days ;) > > Can I placed here the Github project link? > https://github.com/Marvell-switching/switchdev-prestera Yes!
On Tue, 8 Dec 2020 08:39:17 -0800 Jakub Kicinski wrote: > On Tue, 8 Dec 2020 09:22:52 +0000 Mickey Rachamim wrote: > > > > +S: Supported > > > > +W: http://www.marvell.com > > > > > > The website entry is for a project-specific website. If you have a link to a site with open resources about the chips/driver that'd be great, otherwise please drop it. Also https is expected these days ;) > > > > Can I placed here the Github project link? > > https://github.com/Marvell-switching/switchdev-prestera > > Yes! Actually, what's the relationship of the code in this repo with the upstream code? Is this your queue of changes you plan to upstream? The lack of commit history is suspicious.
> On Tue, 8 Dec 2020 08:39:17 -0800 Jakub Kicinski wrote: > > On Tue, 8 Dec 2020 09:22:52 +0000 Mickey Rachamim wrote: > > > > > +S: Supported > > > > > +W: http://www.marvell.com > > > > > > > > The website entry is for a project-specific website. If you have a link to a site with open resources about the chips/driver that'd be great, otherwise please drop it. Also https is expected these days ;) > > > > > > Can I placed here the Github project link? > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Marvell-2Dswitching_switchdev-2Dprestera&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=UAkJRZWLEQnvkxZocwDW_EHhLuSp0So-iW__5LY5cr0&m=C_hG62w12Ol2aD-_5LJD1mYiSoQbGu7kv6oNTq8fMNY&s=jTvnRmsmtay1Vvp23V8G4qO2QWjxGCOcRl8V1v78jiM&e= > > > > Yes! > > Actually, what's the relationship of the code in this repo with the upstream code? Is this your queue of changes you plan to upstream? > The lack of commit history is suspicious. You can see that only yesterday (Dec 8th) we had the first official merge on this repo - this is the reason for the lack of commits. Marvell Switching group took strategic decision to open some aspects of the Prestera family devices with the Open Source community and this is the first step. As you realized - it will be used as a queue for all the features targeted to be upstreamed. New features are expected to be sent to net-next very soon. (Like ACL/LAG/LLDP etc...)
> You can see that only yesterday (Dec 8th) we had the first official > merge on this repo - this is the reason for the lack of commits. > Marvell Switching group took strategic decision to open some aspects > of the Prestera family devices with the Open Source community and > this is the first step. > As you realized - it will be used as a queue for all the features > targeted to be upstreamed. New features are expected to be sent to > net-next very soon. (Like ACL/LAG/LLDP etc...) Hi Mickey I would actually expect this repo to hold a linux tree, probably based on net-next, and with a number of patches on top adding Prestera features, one by one. Given your current structure, i don't see a direct path for this code into mainline. Andrew
Hi Andrew, > > You can see that only yesterday (Dec 8th) we had the first official > > merge on this repo - this is the reason for the lack of commits. > > Marvell Switching group took strategic decision to open some aspects > > of the Prestera family devices with the Open Source community and this > > is the first step. > > > As you realized - it will be used as a queue for all the features > > targeted to be upstreamed. New features are expected to be sent to > > net-next very soon. (Like ACL/LAG/LLDP etc...) > > Hi Mickey > > I would actually expect this repo to hold a linux tree, probably based on net-next, and with a number of patches on top adding Prestera features, one by one. A Buildroot based repo that includes specific platform patches will became public in the upcoming days. (As part of Marvell-Switching GitHub) > > Given your current structure, i don't see a direct path for this code into mainline. > Assuming the discussion is still on the 'W:' line; I went over tens of 'W:' lines in the ./MAINTAINERS file and unfortunately I couldn't see the above standard is really fulfilled. > Andrew > Mickey.
On Wed, Dec 09, 2020 at 09:38:52PM +0000, Mickey Rachamim wrote: > Hi Andrew, > > > > You can see that only yesterday (Dec 8th) we had the first official > > > merge on this repo - this is the reason for the lack of commits. > > > Marvell Switching group took strategic decision to open some aspects > > > of the Prestera family devices with the Open Source community and this > > > is the first step. > > > > > As you realized - it will be used as a queue for all the features > > > targeted to be upstreamed. New features are expected to be sent to > > > net-next very soon. (Like ACL/LAG/LLDP etc...) > > > > Hi Mickey > > > > I would actually expect this repo to hold a linux tree, probably based on net-next, and with a number of patches on top adding Prestera features, one by one. Hi Mickey Please get your mailer fixed. It seems to be re-wrapping other peoples text, which is bad. > A Buildroot based repo that includes specific platform patches will became public in the upcoming days. (As part of Marvell-Switching GitHub) And please wrap your own text at around 65 characters. Standard Netique RFC 1855 stuff. > > > > Given your current structure, i don't see a direct path for this code into mainline. > > > > Assuming the discussion is still on the 'W:' line; Nope. I'm still talking about this repo of driver code. It is one commit. Meaning you cannot do git-format patch git send-email --to=jakub --to=davem --cc=netdev *.patch So you are basically going to have to re-write the code into a set of patches. Which makes this repo pointless, in terms of kernel development work. And that is what MAINTAINERS is all about. Andrew
diff --git a/MAINTAINERS b/MAINTAINERS index 061e64b2423a..c92b44754436 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10550,6 +10550,14 @@ S: Supported F: Documentation/networking/device_drivers/ethernet/marvell/octeontx2.rst F: drivers/net/ethernet/marvell/octeontx2/af/ +MARVELL PRESTERA ETHERNET SWITCH DRIVER +M: Vadym Kochan <vkochan@marvell.com> +M: Taras Chornyi <tchornyi@marvell.com> +L: netdev@vger.kernel.org +S: Supported +W: http://www.marvell.com +F: drivers/net/ethernet/marvell/prestera/ + MARVELL SOC MMC/SD/SDIO CONTROLLER DRIVER M: Nicolas Pitre <nico@fluxnic.net> S: Odd Fixes
Add maintainers info for new Marvell Prestera Ethernet switch driver. Signed-off-by: Mickey Rachamim <mickeyr@marvell.com> --- v2: Update the maintainers list according to community recommendation. MAINTAINERS | 8 ++++++++ 1 file changed, 8 insertions(+)