| Message ID | 1406027485-15657-2-git-send-email-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | a31b0fa6ccd2baba682ec3c60ea5521ad10bbab4 |
| Headers | show |
On Tue, Jul 22, 2014 at 4:41 PM, Lee Jones <lee.jones@linaro.org> wrote: > This is part of an effort to clean-up the MFD subsystem. > <snip> > max77686->rtc_regmap = devm_regmap_init_i2c(max77686->rtc, Which kernel are you on? Because 3.16.rc6 does not match with these lines. Its something like this: 'max77686->regmap = devm_regmap_init_i2c(i2c, &max77686_regmap_config);' Sorry if I am missing something. > Please read the FAQ at http://www.tux.org/lkml/
On Tue, 22 Jul 2014, pramod gurav wrote: > On Tue, Jul 22, 2014 at 4:41 PM, Lee Jones <lee.jones@linaro.org> wrote: > > This is part of an effort to clean-up the MFD subsystem. > > > <snip> > > max77686->rtc_regmap = devm_regmap_init_i2c(max77686->rtc, > Which kernel are you on? Because 3.16.rc6 does not match with these > lines. Its something like this: > 'max77686->regmap = devm_regmap_init_i2c(i2c, > &max77686_regmap_config);' > > Sorry if I am missing something. It's based on the most recent MFD for-mfd-next branch. You're missing the following patches: mfd: max77686: Remove unneeded OOM error message mfd: max77686: Make error checking consistent mfd: max77686: Return correct error when pdata isn't found mfd: max77686: Make platform data over-rule DT mfd: max77686: Don't define dummy function if OF isn't enabled mfd: max77686: Add power management support mfd: max77686: Convert to use regmap_irq
On Tue, Jul 22, 2014 at 5:43 PM, Lee Jones <lee.jones@linaro.org> wrote: > On Tue, 22 Jul 2014, pramod gurav wrote: > > It's based on the most recent MFD for-mfd-next branch. > > You're missing the following patches: > > mfd: max77686: Remove unneeded OOM error message > mfd: max77686: Make error checking consistent > mfd: max77686: Return correct error when pdata isn't found > mfd: max77686: Make platform data over-rule DT > mfd: max77686: Don't define dummy function if OF isn't enabled > mfd: max77686: Add power management support > mfd: max77686: Convert to use regmap_irq > ok. Thanks. :) > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index 8650832..f2bd699 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -166,7 +166,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c, i2c_set_clientdata(max77686->rtc, max77686); max77686->rtc_regmap = devm_regmap_init_i2c(max77686->rtc, - &max77686_rtc_regmap_config); + &max77686_rtc_regmap_config); if (IS_ERR(max77686->rtc_regmap)) { ret = PTR_ERR(max77686->rtc_regmap); dev_err(max77686->dev, "failed to allocate RTC regmap: %d\n",
This is part of an effort to clean-up the MFD subsystem. +WARNING: line over 80 characters + &max77686_rtc_regmap_config); total: 0 errors, 1 warnings, 299 lines checked Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/mfd/max77686.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)