[v4,1/2] dt-bindings: watchdog: Add bindings for Intel Keem Bay SoC

Message ID 8c4dad4fb8ba644607aa9379d5ec70d8707d7e75.1608141131.git.vijayakannan.ayyathurai@intel.com
State New
Headers show
Series
  • [v4,1/2] dt-bindings: watchdog: Add bindings for Intel Keem Bay SoC
Related show

Commit Message

Ayyathurai, Vijayakannan Dec. 16, 2020, 6:32 p.m.
From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>

Add Device Tree binding document for Watchdog IP in the Intel Keem Bay SoC.

Acked-by: Mark Gross <mgross@linux.intel.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../bindings/watchdog/intel,keembay-wdt.yaml  | 57 +++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml

Comments

Guenter Roeck Jan. 23, 2021, 5:18 p.m. | #1
On Thu, Dec 17, 2020 at 02:32:47AM +0800, vijayakannan.ayyathurai@intel.com wrote:
> From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>

> 

> Add Device Tree binding document for Watchdog IP in the Intel Keem Bay SoC.

> 

> Acked-by: Mark Gross <mgross@linux.intel.com>

> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>

> Reviewed-by: Rob Herring <robh@kernel.org>


Reviewed-by: Guenter Roeck <linux@roeck-us.net>


> ---

>  .../bindings/watchdog/intel,keembay-wdt.yaml  | 57 +++++++++++++++++++

>  1 file changed, 57 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml

> 

> diff --git a/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml b/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml

> new file mode 100644

> index 000000000000..1437ff8a122f

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml

> @@ -0,0 +1,57 @@

> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/watchdog/intel,keembay-wdt.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title: Intel Keem Bay SoC non-secure Watchdog Timer

> +

> +maintainers:

> +  - Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>

> +

> +properties:

> +  compatible:

> +    enum:

> +      - intel,keembay-wdt

> +

> +  reg:

> +    maxItems: 1

> +

> +  clocks:

> +    maxItems: 1

> +

> +  interrupts:

> +    items:

> +      - description: interrupt specifier for threshold interrupt line

> +      - description: interrupt specifier for timeout interrupt line

> +

> +  interrupt-names:

> +    items:

> +      - const: threshold

> +      - const: timeout

> +

> +required:

> +  - compatible

> +  - reg

> +  - interrupts

> +  - interrupt-names

> +  - clocks

> +

> +additionalProperties: false

> +

> +examples:

> +  - |

> +    #include <dt-bindings/interrupt-controller/arm-gic.h>

> +    #include <dt-bindings/interrupt-controller/irq.h>

> +    #define KEEM_BAY_A53_TIM

> +

> +    watchdog: watchdog@2033009c {

> +        compatible = "intel,keembay-wdt";

> +        reg = <0x2033009c 0x10>;

> +        interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>,

> +                     <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;

> +        interrupt-names = "threshold", "timeout";

> +        clocks = <&scmi_clk KEEM_BAY_A53_TIM>;

> +    };

> +

> +...
Ayyathurai, Vijayakannan Jan. 25, 2021, 2:56 a.m. | #2
Hi Guenter,

> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck

> > From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>

> >

> > Add Device Tree binding document for Watchdog IP in the Intel Keem Bay

> SoC.

> >

> > Acked-by: Mark Gross <mgross@linux.intel.com>

> > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> > Signed-off-by: Vijayakannan Ayyathurai

> <vijayakannan.ayyathurai@intel.com>

> > Reviewed-by: Rob Herring <robh@kernel.org>

> 

> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> 


Thank you for reviewing this patch.

Thanks,
Vijay

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml b/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml
new file mode 100644
index 000000000000..1437ff8a122f
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/intel,keembay-wdt.yaml
@@ -0,0 +1,57 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/intel,keembay-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Intel Keem Bay SoC non-secure Watchdog Timer
+
+maintainers:
+  - Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>
+
+properties:
+  compatible:
+    enum:
+      - intel,keembay-wdt
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  interrupts:
+    items:
+      - description: interrupt specifier for threshold interrupt line
+      - description: interrupt specifier for timeout interrupt line
+
+  interrupt-names:
+    items:
+      - const: threshold
+      - const: timeout
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #define KEEM_BAY_A53_TIM
+
+    watchdog: watchdog@2033009c {
+        compatible = "intel,keembay-wdt";
+        reg = <0x2033009c 0x10>;
+        interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
+        interrupt-names = "threshold", "timeout";
+        clocks = <&scmi_clk KEEM_BAY_A53_TIM>;
+    };
+
+...