diff mbox series

[v2,2/9] configure: gate our use of GDB to 8.3.1 or above

Message ID 20201218112707.28348-3-alex.bennee@linaro.org
State Superseded
Headers show
Series gdbstub/next (cleanups, softmmu, SVE) | expand

Commit Message

Alex Bennée Dec. 18, 2020, 11:27 a.m. UTC 
The support of socket based debugging which we need for linux-user
testing is only really stable as of 8.3.1 so lets gate our use of GDB
on having a relatively modern version.

For direct testing you can just point to a locally compiled version of
gdb via configure, e.g.:

  ../../configure --gdb=$HOME/src/binutils-gdb.git/builds/all/install/bin/gdb

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20201214153012.12723-3-alex.bennee@linaro.org>

---
v2
  - reword intention
---
 configure | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
2.20.1
diff mbox series

Patch

diff --git a/configure b/configure
index 0e542b4c46..07df350e06 100755
--- a/configure
+++ b/configure
@@ -6676,8 +6676,11 @@  if test "$plugins" = "yes" ; then
     fi
 fi
 
-if test -n "$gdb_bin" ; then
-    echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
+if test -n "$gdb_bin"; then
+    gdb_version=$($gdb_bin --version | head -n 1)
+    if version_ge ${gdb_version##* } 8.3.1; then
+        echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
+    fi
 fi
 
 if test "$secret_keyring" = "yes" ; then