From patchwork Tue Aug 19 08:54:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Baldyga X-Patchwork-Id: 35579 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f69.google.com (mail-oa0-f69.google.com [209.85.219.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D879B20523 for ; Tue, 19 Aug 2014 09:02:50 +0000 (UTC) Received: by mail-oa0-f69.google.com with SMTP id i7sf42546477oag.0 for ; Tue, 19 Aug 2014 02:02:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=6cQnH3Y5t3wE2S31HsR7JPWXDpFKYyZukXUe+hnv10c=; b=T/h/fA0uiiWDsi4ymCtn/UGl7T/FuS7FQM+wUlWOx+DJHuyHz3vy9BrJyZD9EFSUHI TxI8e37KLD85cOX4IUskYbIXP5Ke/aSbhLk+tLTyCl+lwL0pmvhFc07+lrlSqp35Iy34 h3UjQYZeI+ubtc0AAXErnI8Ei6OYr9AK2qfbBYIh4pfdylFN2c5PCBGlrkNCzptyWccv wVgcYXeKbxWoIWEHEfa6rcE2c2qeqONobCu2X6PPLLb7zRnFjcoL46YSs8hLD++mxFSe GngR6Ykymm4i1KF9Qxlt413iVEQ3HAnHetiMGOatWgQpSGWvOH7urYH5XtJq8ZNHSuuP fhGg== X-Gm-Message-State: ALoCoQlMevr0iX3KzJK6K9KycIPA/dNU5sAhJswW6Kt8werKaUJwS+ju2jCPZn3Rybximn4f/KAc X-Received: by 10.182.111.170 with SMTP id ij10mr19972077obb.6.1408438970501; Tue, 19 Aug 2014 02:02:50 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.109.246 with SMTP id l109ls179613qgf.1.gmail; Tue, 19 Aug 2014 02:02:50 -0700 (PDT) X-Received: by 10.220.174.137 with SMTP id t9mr29223363vcz.12.1408438970376; Tue, 19 Aug 2014 02:02:50 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id h6si8346487vdw.73.2014.08.19.02.02.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 19 Aug 2014 02:02:50 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id hq11so7091904vcb.16 for ; Tue, 19 Aug 2014 02:02:50 -0700 (PDT) X-Received: by 10.52.239.108 with SMTP id vr12mr2223077vdc.30.1408438970276; Tue, 19 Aug 2014 02:02:50 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp221939vcb; Tue, 19 Aug 2014 02:02:49 -0700 (PDT) X-Received: by 10.68.115.48 with SMTP id jl16mr7415451pbb.78.1408438969060; Tue, 19 Aug 2014 02:02:49 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id zr6si25838957pac.49.2014.08.19.02.02.40 for ; Tue, 19 Aug 2014 02:02:41 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752987AbaHSI7p (ORCPT + 20 others); Tue, 19 Aug 2014 04:59:45 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:39648 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751879AbaHSI7h (ORCPT ); Tue, 19 Aug 2014 04:59:37 -0400 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NAJ0004UQB72H00@mailout4.samsung.com>; Tue, 19 Aug 2014 17:59:31 +0900 (KST) X-AuditID: cbfee61a-f79e46d00000134f-95-53f311f33273 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id D6.75.04943.3F113F35; Tue, 19 Aug 2014 17:59:31 +0900 (KST) Received: from AMDC2122.DIGITAL.local ([106.120.53.17]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NAJ0011RQ2NYC00@mmp2.samsung.com>; Tue, 19 Aug 2014 17:59:31 +0900 (KST) From: Robert Baldyga To: Paul.Zimmerman@synopsys.com Cc: gregkh@linuxfoundation.org, balbi@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, andrzej.p@samsung.com, Robert Baldyga Subject: [PATCH RESEND v3 08/12] usb: dwc2/gadget: do not call disconnect method in pullup Date: Tue, 19 Aug 2014 10:54:14 +0200 Message-id: <1408438458-3317-9-git-send-email-r.baldyga@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1408438458-3317-1-git-send-email-r.baldyga@samsung.com> References: <1408438458-3317-1-git-send-email-r.baldyga@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBLMWRmVeSWpSXmKPExsVy+t9jQd3Pgp+DDSZ/ErSY9bKdxeLg/XqL 5sXr2Swu75rDZrFoWSuzxdojd9ktHj3cymrx4PBOdgcOj/1z17B79G1ZxeixZf9nRo/jN7Yz eXzeJBfAGsVlk5Kak1mWWqRvl8CVsX76VvaCeWwVhw5XNTAuYu1i5OSQEDCR6P89gQXCFpO4 cG89WxcjF4eQwHRGiePvVrNDOO1MEgs+XGAHqWIT0JHY8n0CI4gtIiAvcX3jTRaQImaBQ4wS r+4cYwJJCAvESHxZ/gJsBYuAqsTkG2fYQGxeAReJp39/Qa2Tkzh5bDJYDaeAq8TbfbPAFggB 1WxuPcM2gZF3ASPDKkbR1ILkguKk9FxDveLE3OLSvHS95PzcTYzg8HomtYNxZYPFIUYBDkYl Hl6FLx+DhVgTy4orc4Gu4WBWEuF1fPEpWIg3JbGyKrUoP76oNCe1+BCjNAeLkjjvgVbrQCGB 9MSS1OzU1ILUIpgsEwenVANjRlnKVnaBeN8K5XqJl0ZOZ4Sj2961THNdpuiodbW3QMQ34cnn HW9UysKLy+p86jY/K9zLF93Cevtcj8w8t9fBJclxDOd5/67Y2qGxYUKvY77mtern1eeXWZrP X3swIeD8ywXbmjWvvjkRJtFabvh013G7bcXnt3XHzqlclMqg5ZZ5UUnn5i0lluKMREMt5qLi RAC0KvQyKwIAAA== Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linux-kernel-owner@vger.kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index c829c05..1d5e387 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2944,7 +2944,6 @@ static int s3c_hsotg_pullup(struct usb_gadget *gadget, int is_on) s3c_hsotg_phy_enable(hsotg); s3c_hsotg_core_init(hsotg); } else { - s3c_hsotg_disconnect(hsotg); s3c_hsotg_phy_disable(hsotg); }