diff mbox series

hid: sony: select CONFIG_CRC32

Message ID 20210103214159.1996262-1-arnd@kernel.org
State New
Headers show
Series hid: sony: select CONFIG_CRC32 | expand

Commit Message

Arnd Bergmann Jan. 3, 2021, 9:41 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>


Without crc32 support, this driver fails to link:

arm-linux-gnueabi-ld: drivers/hid/hid-sony.o: in function `sony_raw_event':
hid-sony.c:(.text+0x8f4): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: hid-sony.c:(.text+0x900): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/hid/hid-sony.o:hid-sony.c:(.text+0x4408): more undefined references to `crc32_le' follow

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.29.2

Comments

Jiri Kosina Jan. 4, 2021, 3:10 p.m. UTC | #1 
On Sun, 3 Jan 2021, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>

> 

> Without crc32 support, this driver fails to link:

> 

> arm-linux-gnueabi-ld: drivers/hid/hid-sony.o: in function `sony_raw_event':

> hid-sony.c:(.text+0x8f4): undefined reference to `crc32_le'

> arm-linux-gnueabi-ld: hid-sony.c:(.text+0x900): undefined reference to `crc32_le'

> arm-linux-gnueabi-ld: drivers/hid/hid-sony.o:hid-sony.c:(.text+0x4408): more undefined references to `crc32_le' follow

> 

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Applied, thanks Arnd.

-- 
Jiri Kosina
SUSE Labs
diff mbox series

Patch

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 7bdda1b5b221..09fa75a2b289 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -899,6 +899,7 @@  config HID_SONY
 	depends on NEW_LEDS
 	depends on LEDS_CLASS
 	select POWER_SUPPLY
+	select CRC32
 	help
 	Support for