From patchwork Wed Aug 20 16:59:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lina Iyer X-Patchwork-Id: 35694 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f197.google.com (mail-ie0-f197.google.com [209.85.223.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 7C3192055D for ; Wed, 20 Aug 2014 17:00:29 +0000 (UTC) Received: by mail-ie0-f197.google.com with SMTP id rp18sf12497018iec.8 for ; Wed, 20 Aug 2014 10:00:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=ZWELvzOhShx3iMpX+BOkKsb8DZJKYSDaYHZuh6/90T0=; b=aDy6p6yf6hTUma/n6gtl3EGshcYvDrmk0La9reylpFs8eT6v5lBPMOePlqY6MKANI6 PQSKV0ORBXtmn1YzRD9BPlTkf28oQNH393HKBujo9ZyYhsP7Sq0CikXUzKnDIBF/zJj3 Z5667tmgTFoWpdXm4ykNYUYXi3Nm9xAu6mX+q5AplYe8ZoeIX7wo5DDb1NleYfvFdNEc JtpkwQjOfDU00mLZcYe5QGfyDcPWeTt/uojoX4iFxA2Z4ndYSgI86gVM4iNqSIfbnpSt rE0qi7Pd296VCcrIj8R/quPnP3hjVlKjqDMRCKLfxPRTNEluZDZ5fN5mermsTb7D4B2k IXmQ== X-Gm-Message-State: ALoCoQkdbRSHVVn0+5hHLVCkCcYHZhlYp5UbEhkpD7O7WlWJisYWSNpgC1WSE52fqaayfAnnUwUx X-Received: by 10.182.186.4 with SMTP id fg4mr27305641obc.9.1408554028747; Wed, 20 Aug 2014 10:00:28 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.30.136 with SMTP id d8ls344306qgd.39.gmail; Wed, 20 Aug 2014 10:00:28 -0700 (PDT) X-Received: by 10.220.97.138 with SMTP id l10mr19319159vcn.25.1408554028572; Wed, 20 Aug 2014 10:00:28 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id a7si10885145vdb.93.2014.08.20.10.00.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 Aug 2014 10:00:28 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id hq11so9524037vcb.30 for ; Wed, 20 Aug 2014 10:00:28 -0700 (PDT) X-Received: by 10.220.118.136 with SMTP id v8mr7583776vcq.50.1408554028474; Wed, 20 Aug 2014 10:00:28 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp68854vcb; Wed, 20 Aug 2014 10:00:27 -0700 (PDT) X-Received: by 10.66.66.101 with SMTP id e5mr55457219pat.100.1408554027459; Wed, 20 Aug 2014 10:00:27 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ra8si32537714pbb.56.2014.08.20.10.00.19 for ; Wed, 20 Aug 2014 10:00:20 -0700 (PDT) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751625AbaHTRAL (ORCPT + 15 others); Wed, 20 Aug 2014 13:00:11 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:51774 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbaHTRAK (ORCPT ); Wed, 20 Aug 2014 13:00:10 -0400 Received: by mail-pa0-f53.google.com with SMTP id rd3so12685980pab.40 for ; Wed, 20 Aug 2014 10:00:07 -0700 (PDT) X-Received: by 10.70.0.201 with SMTP id 9mr17539467pdg.43.1408554005735; Wed, 20 Aug 2014 10:00:05 -0700 (PDT) Received: from localhost.localdomain (proxy6-global253.qualcomm.com. [199.106.103.253]) by mx.google.com with ESMTPSA id mz8sm34838221pdb.62.2014.08.20.10.00.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Aug 2014 10:00:05 -0700 (PDT) From: Lina Iyer To: khilman@linaro.org, tglx@linutronix.de, linux-pm@vger.kernel.org, daniel.lezcano@linaro.org, ulf.hansson@linaro.org Cc: Praveen Chidambaram , Lina Iyer Subject: [PATCH 2/2] arm64: irq: Notify affinity change when migrating IRQs during hotplug Date: Wed, 20 Aug 2014 10:59:48 -0600 Message-Id: <1408553988-63924-2-git-send-email-lina.iyer@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1408553988-63924-1-git-send-email-lina.iyer@linaro.org> References: <1408553988-63924-1-git-send-email-lina.iyer@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lina.iyer@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Praveen Chidambaram Hotplug causes IRQs affine to a core that is being taken down to migrate to an online core. This is done by directly calling the irq_set_affinity associated with the irq_chip structure. Instead using the irq_set_affinity_locked() api lets the notifications bubble through. Signed-off-by: Praveen Chidambaram Signed-off-by: Lina Iyer --- arch/arm64/kernel/irq.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/arm64/kernel/irq.c b/arch/arm64/kernel/irq.c index 0f08dfd..c623032 100644 --- a/arch/arm64/kernel/irq.c +++ b/arch/arm64/kernel/irq.c @@ -87,7 +87,6 @@ static bool migrate_one_irq(struct irq_desc *desc) { struct irq_data *d = irq_desc_get_irq_data(desc); const struct cpumask *affinity = d->affinity; - struct irq_chip *c; bool ret = false; /* @@ -106,12 +105,8 @@ static bool migrate_one_irq(struct irq_desc *desc) * selected as the target CPU otherwise */ affinity = cpu_online_mask; - c = irq_data_get_irq_chip(d); - if (!c->irq_set_affinity) - pr_debug("IRQ%u: unable to set affinity\n", d->irq); - else if (c->irq_set_affinity(d, affinity, true) == IRQ_SET_MASK_OK && ret) - cpumask_copy(d->affinity, affinity); - + ret = (irq_set_affinity_locked(d, affinity, true) == IRQ_SET_MASK_OK) + && ret; return ret; }