| Message ID | CAMh5ckdy=z8j7X5BXLtpnOz2-Ha7MZqN-DvJS0e1w4CdiLJ4EQ@mail.gmail.com |
|---|---|
| State | Accepted |
| Commit | 7c38e769d5c508939ce5dc26df72602f3c902342 |
| Headers | show |
| Series | HID: Ignore battery for Elan touchscreen on ASUS UX550 | expand |
On Mon, 4 Jan 2021, Seth Miller wrote: > Battery status is being reported for the Elan touchscreen on ASUS > UX550 laptops despite not having a batter. It always shows either 0 or > 1%. > > Signed-off-by: Seth Miller <miller.seth@gmail.com> Seth, thanks for the patch. It has, however, been line-wrapped by your mail client, so I can't apply it as-is. Could you please fix that up and resend? Thanks, -- Jiri Kosina SUSE Labs
On Fri, 2021-01-08 at 15:53 +0100, Jiri Kosina wrote: > On Mon, 4 Jan 2021, Seth Miller wrote: > > > Battery status is being reported for the Elan touchscreen on ASUS > > UX550 laptops despite not having a batter. It always shows either 0 > > or > > 1%. > > > > Signed-off-by: Seth Miller <miller.seth@gmail.com> > > Seth, thanks for the patch. It has, however, been line-wrapped by > your > mail client, so I can't apply it as-is. Could you please fix that up > and > resend? > > Thanks, > Jiri, My apologies for the formatting issues. I wasn't aware Gmail's client silently inserted line breaks in plain text emails. Hopefully Evolution can do a bit better. Signed-off-by: Seth Miller <miller.seth@gmail.com> --- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index f170feaac40b..94180c63571e 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -387,6 +387,7 @@ #define USB_DEVICE_ID_TOSHIBA_CLICK_L9W 0x0401 #define USB_DEVICE_ID_HP_X2 0x074d #define USB_DEVICE_ID_HP_X2_10_COVER 0x0755 +#define USB_DEVICE_ID_ASUS_UX550_TOUCHSCREEN 0x2706 #define USB_VENDOR_ID_ELECOM 0x056e #define USB_DEVICE_ID_ELECOM_BM084 0x0061 diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index 4dca11392459..32024905fd70 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -322,6 +322,8 @@ static const struct hid_device_id hid_battery_quirks[] = { { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DINOVO_EDGE_KBD), HID_BATTERY_QUIRK_IGNORE }, + { HID_USB_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ASUS_UX550_TOUCHSCREEN), + HID_BATTERY_QUIRK_IGNORE }, {} }; -- 2.29.2
On Fri, 8 Jan 2021, Seth Miller wrote: > Jiri, > My apologies for the formatting issues. I wasn't aware Gmail's client > silently inserted line breaks in plain text emails. Hopefully Evolution > can do a bit better. > > Signed-off-by: Seth Miller <miller.seth@gmail.com> Thanks. This one didn't have proper changelog :) but I've combined the two and applied. -- Jiri Kosina SUSE Labs
Thanks for the patience. I'm sure I'll get the next one right ;) -Seth On Fri, Jan 8, 2021 at 9:53 AM Jiri Kosina <jikos@kernel.org> wrote: > > On Fri, 8 Jan 2021, Seth Miller wrote: > > > Jiri, > > > My apologies for the formatting issues. I wasn't aware Gmail's client > > silently inserted line breaks in plain text emails. Hopefully Evolution > > can do a bit better. > > > > Signed-off-by: Seth Miller <miller.seth@gmail.com> > > Thanks. This one didn't have proper changelog :) but I've combined the two > and applied. > > -- > Jiri Kosina > SUSE Labs >
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 4c5f23640f9c..5ba0aa1d2335 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -389,6 +389,7 @@ #define USB_DEVICE_ID_TOSHIBA_CLICK_L9W 0x0401 #define USB_DEVICE_ID_HP_X2 0x074d #define USB_DEVICE_ID_HP_X2_10_COVER 0x0755 +#define USB_DEVICE_ID_ASUS_UX550_TOUCHSCREEN 0x2706 #define USB_VENDOR_ID_ELECOM 0x056e #define USB_DEVICE_ID_ELECOM_BM084 0x0061 diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index dc7f6b4a775c..f23027d2795b 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -322,6 +322,8 @@ static const struct hid_device_id hid_battery_quirks[] = { { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DINOVO_EDGE_KBD), HID_BATTERY_QUIRK_IGNORE }, + { HID_USB_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ASUS_UX550_TOUCHSCREEN), + HID_BATTERY_QUIRK_IGNORE }, {} };
Battery status is being reported for the Elan touchscreen on ASUS UX550 laptops despite not having a batter. It always shows either 0 or 1%. Signed-off-by: Seth Miller <miller.seth@gmail.com> --- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 2 ++ 2 files changed, 3 insertions(+)