diff mbox

bootstrap: add include m4 directory in bootstrap

Message ID 1408623658-2820-1-git-send-email-giladb@ezchip.com
State New
Headers show

Commit Message

Gilad Ben-Yossef Aug. 21, 2014, 12:20 p.m. UTC
From: Gilad Ben-Yossef <gilad@benyossef.com>

First time configure was failing due to missing Doxygen includes from
m4/ directory.

Include m4/ directory during bootstrap generation to get autoconf
to create a correct configure script.

Signed-off-by: Gilad Ben-Yossef <giladb@ezchip.com>
CC: Barry Spinney <spinney@tilera.com>
---
 bootstrap |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Anders Roxell Aug. 21, 2014, 6:58 p.m. UTC | #1
On 2014-08-21 15:20, Gilad Ben-Yossef wrote:
> From: Gilad Ben-Yossef <gilad@benyossef.com>
> 
> First time configure was failing due to missing Doxygen includes from
> m4/ directory.
> 
> Include m4/ directory during bootstrap generation to get autoconf
> to create a correct configure script.

Hi,

I couldn't reproduce the problem, what versions of autotools are you
using?
Are you using Ubuntu?
What version?

Cheers,
Anders

> 
> Signed-off-by: Gilad Ben-Yossef <giladb@ezchip.com>
> CC: Barry Spinney <spinney@tilera.com>
> ---
>  bootstrap |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/bootstrap b/bootstrap
> index 12f9388..cd759b0 100755
> --- a/bootstrap
> +++ b/bootstrap
> @@ -1,6 +1,6 @@
>  #! /bin/sh
>  set -x
> -aclocal -I config
> +aclocal -I config -I m4
>  libtoolize --copy
>  autoheader
>  automake --add-missing --copy
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
Gilad Ben-Yossef Aug. 22, 2014, 7:39 a.m. UTC | #2
Hi,

> > First time configure was failing due to missing Doxygen includes from
> > m4/ directory.
> >
> > Include m4/ directory during bootstrap generation to get autoconf
> > to create a correct configure script.
> 
> I couldn't reproduce the problem, what versions of autotools are you
> using?
Automake 1.11.1
Autoconf 2.63
> Are you using Ubuntu?
CentOS 6.5
> What version?

Here is what happens when you build without the fix (commit 26238333b5b0896366c844aeb7253e60abd99f5a) on this system:
giladb@nps06:~/src/odp$ ./bootstrap
+ aclocal -I config
+ libtoolize --copy
+ autoheader
+ automake --add-missing --copy
aminclude.am:15: DX_COND_doc does not appear in AM_CONDITIONAL
Makefile.am:6:   `aminclude.am' included from here
aminclude.am:21: DX_COND_html does not appear in AM_CONDITIONAL
Makefile.am:6:   `aminclude.am' included from here
aminclude.am:31: DX_COND_chm does not appear in AM_CONDITIONAL
Makefile.am:6:   `aminclude.am' included from here
aminclude.am:35: DX_COND_chi does not appear in AM_CONDITIONAL
Makefile.am:6:   `aminclude.am' included from here
aminclude.am:47: DX_COND_man does not appear in AM_CONDITIONAL
Makefile.am:6:   `aminclude.am' included from here
aminclude.am:57: DX_COND_rtf does not appear in AM_CONDITIONAL
Makefile.am:6:   `aminclude.am' included from here
aminclude.am:67: DX_COND_xml does not appear in AM_CONDITIONAL
Makefile.am:6:   `aminclude.am' included from here
aminclude.am:77: DX_COND_ps does not appear in AM_CONDITIONAL
Makefile.am:6:   `aminclude.am' included from here
aminclude.am:106: DX_COND_pdf does not appear in AM_CONDITIONAL
Makefile.am:6:   `aminclude.am' included from here
aminclude.am:135: DX_COND_latex does not appear in AM_CONDITIONAL
Makefile.am:6:   `aminclude.am' included from here
+ autoconf
giladb@nps06:~/src/odp$ ./configure 
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
[SNIP]
	checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
./configure: line 4922: syntax error near unexpected token `ON'
./configure: line 4922: `DX_HTML_FEATURE(ON)'

The reason I mentioned the repo I clone from in my previous reply (it never got to the mailing list) was because after this build error I ran into another (hence my other patch) and after fixing that it still does not build, so I was half expecting you guys to tell me I got the wrong repo/branch..
Thanks,
Gilad
Anders Roxell Aug. 22, 2014, 11:41 a.m. UTC | #3
On 2014-08-22 07:39, Gilad Ben Yossef wrote:
> Hi,
> 
> > > First time configure was failing due to missing Doxygen includes from
> > > m4/ directory.
> > >
> > > Include m4/ directory during bootstrap generation to get autoconf
> > > to create a correct configure script.
> > 
> > I couldn't reproduce the problem, what versions of autotools are you
> > using?
> Automake 1.11.1
> Autoconf 2.63
> > Are you using Ubuntu?
> CentOS 6.5
> > What version?
> 
> Here is what happens when you build without the fix (commit 26238333b5b0896366c844aeb7253e60abd99f5a) on this system:
> giladb@nps06:~/src/odp$ ./bootstrap
> + aclocal -I config
> + libtoolize --copy
> + autoheader
> + automake --add-missing --copy
> aminclude.am:15: DX_COND_doc does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:21: DX_COND_html does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:31: DX_COND_chm does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:35: DX_COND_chi does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:47: DX_COND_man does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:57: DX_COND_rtf does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:67: DX_COND_xml does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:77: DX_COND_ps does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:106: DX_COND_pdf does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:135: DX_COND_latex does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> + autoconf
> giladb@nps06:~/src/odp$ ./configure 
> checking for a BSD-compatible install... /usr/bin/install -c
> checking whether build environment is sane... yes
> checking for a thread-safe mkdir -p... /bin/mkdir -p
> [SNIP]
> 	checking minix/config.h presence... no
> checking for minix/config.h... no
> checking whether it is safe to define __EXTENSIONS__... yes
> checking for special C compiler options needed for large files... no
> checking for _FILE_OFFSET_BITS value needed for large files... no
> ./configure: line 4922: syntax error near unexpected token `ON'
> ./configure: line 4922: `DX_HTML_FEATURE(ON)'
> 
> The reason I mentioned the repo I clone from in my previous reply (it never got to the mailing list) was because after this build error I ran into another (hence my other patch) and after fixing that it still does not build, so I was half expecting you guys to tell me I got the wrong repo/branch..
> Thanks,
> Gilad

Aha... I have seen that on Ubuntu 12.04, it doesn't exist on Ubuntu
14.04.

To solve that we installed autoconf-archive...
However, If your fix solves that thats even better... I will have to
test that. =)

Cheers,
Anders
Anders Roxell Aug. 22, 2014, 12:34 p.m. UTC | #4
On 2014-08-22 07:39, Gilad Ben Yossef wrote:
> Hi,
> 
> > > First time configure was failing due to missing Doxygen includes from
> > > m4/ directory.
> > >
> > > Include m4/ directory during bootstrap generation to get autoconf
> > > to create a correct configure script.
> > 
> > I couldn't reproduce the problem, what versions of autotools are you
> > using?
> Automake 1.11.1
> Autoconf 2.63
> > Are you using Ubuntu?
> CentOS 6.5
> > What version?
> 
> Here is what happens when you build without the fix (commit 26238333b5b0896366c844aeb7253e60abd99f5a) on this system:
> giladb@nps06:~/src/odp$ ./bootstrap
> + aclocal -I config
> + libtoolize --copy
> + autoheader
> + automake --add-missing --copy
> aminclude.am:15: DX_COND_doc does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:21: DX_COND_html does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:31: DX_COND_chm does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:35: DX_COND_chi does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:47: DX_COND_man does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:57: DX_COND_rtf does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:67: DX_COND_xml does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:77: DX_COND_ps does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:106: DX_COND_pdf does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> aminclude.am:135: DX_COND_latex does not appear in AM_CONDITIONAL
> Makefile.am:6:   `aminclude.am' included from here
> + autoconf
> giladb@nps06:~/src/odp$ ./configure 
> checking for a BSD-compatible install... /usr/bin/install -c
> checking whether build environment is sane... yes
> checking for a thread-safe mkdir -p... /bin/mkdir -p
> [SNIP]
> 	checking minix/config.h presence... no
> checking for minix/config.h... no
> checking whether it is safe to define __EXTENSIONS__... yes
> checking for special C compiler options needed for large files... no
> checking for _FILE_OFFSET_BITS value needed for large files... no
> ./configure: line 4922: syntax error near unexpected token `ON'
> ./configure: line 4922: `DX_HTML_FEATURE(ON)'
> 
> The reason I mentioned the repo I clone from in my previous reply (it never got to the mailing list) was because after this build error I ran into another (hence my other patch) and after fixing that it still does not build, so I was half expecting you guys to tell me I got the wrong repo/branch..
> Thanks,
> Gilad

Hi again,

I've verified this now and it works...

Can you please update the DEPENDENCIES as well to remove
autoconf-archive in this patch?

Cheers,
Anders
diff mbox

Patch

diff --git a/bootstrap b/bootstrap
index 12f9388..cd759b0 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1,6 +1,6 @@ 
 #! /bin/sh
 set -x
-aclocal -I config
+aclocal -I config -I m4
 libtoolize --copy
 autoheader
 automake --add-missing --copy