diff mbox series

net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE

Message ID 20210107195818.3878-1-olek2@wp.pl
State New
Headers show
Series net: dsa: lantiq_gswip: Exclude RMII from modes that report 1 GbE | expand

Commit Message

Aleksander Jan Bajkowski Jan. 7, 2021, 7:58 p.m. UTC
Exclude RMII from modes that report 1 GbE support. Reduced MII supports
up to 100 MbE.

Fixes: 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
 drivers/net/dsa/lantiq_gswip.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Jakub Kicinski Jan. 8, 2021, 3:02 a.m. UTC | #1
On Thu, 7 Jan 2021 12:00:44 -0800 Florian Fainelli wrote:
> On 1/7/21 11:58 AM, Aleksander Jan Bajkowski wrote:

> > Exclude RMII from modes that report 1 GbE support. Reduced MII supports

> > up to 100 MbE.

> > 

> > Fixes: 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")


Please make sure that the hash is at least 12 chars in the future.

> > Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>  

> 

> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>


Applied, thanks!
diff mbox series

Patch

diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index 4b36d89bec06..662e68a0e7e6 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -1436,11 +1436,12 @@  static void gswip_phylink_validate(struct dsa_switch *ds, int port,
 	phylink_set(mask, Pause);
 	phylink_set(mask, Asym_Pause);
 
-	/* With the exclusion of MII and Reverse MII, we support Gigabit,
-	 * including Half duplex
+	/* With the exclusion of MII, Reverse MII and Reduced MII, we
+	 * support Gigabit, including Half duplex
 	 */
 	if (state->interface != PHY_INTERFACE_MODE_MII &&
-	    state->interface != PHY_INTERFACE_MODE_REVMII) {
+	    state->interface != PHY_INTERFACE_MODE_REVMII &&
+	    state->interface != PHY_INTERFACE_MODE_RMII) {
 		phylink_set(mask, 1000baseT_Full);
 		phylink_set(mask, 1000baseT_Half);
 	}