patman: implement 'reverse' in LogCmd()

Message ID 1408825737-13659-1-git-send-email-srae@broadcom.com
State New
Headers show

Commit Message

Steve Rae Aug. 23, 2014, 8:28 p.m.
- add missing capability 'git log --reverse'

Signed-off-by: Steve Rae <srae@broadcom.com>
- a recent change (cda2a61) broke patman, the "Changes in v?" tags
  are being applied to the wrong commits!
END

---

 tools/patman/gitutil.py | 2 ++
 1 file changed, 2 insertions(+)

Comments

Simon Glass Aug. 23, 2014, 10:18 p.m. | #1
Hi Steve,

On 23 August 2014 14:28, Steve Rae <srae@broadcom.com> wrote:
> - add missing capability 'git log --reverse'
>
> Signed-off-by: Steve Rae <srae@broadcom.com>
> - a recent change (cda2a61) broke patman, the "Changes in v?" tags
>   are being applied to the wrong commits!

Thanks for the patch. We already have one for this:

http://patchwork.ozlabs.org/patch/380068/

I'll organise a pull request soon and it will be fixed.

Regards,
Simon

Patch

diff --git a/tools/patman/gitutil.py b/tools/patman/gitutil.py
index 735c8dd..6af6c2a 100644
--- a/tools/patman/gitutil.py
+++ b/tools/patman/gitutil.py
@@ -36,6 +36,8 @@  def LogCmd(commit_range, git_dir=None, oneline=False, reverse=False,
     cmd += ['log', '--no-color']
     if oneline:
         cmd.append('--oneline')
+    if reverse:
+        cmd.append('--reverse')
     if use_no_decorate:
         cmd.append('--no-decorate')
     if count is not None: