| Message ID | 20210107052206.2599844-2-hsinyi@chromium.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] arm64: dts: mt8183: config dsi node | expand |
On Thu, Jan 07, 2021 at 01:22:06PM +0800, Hsin-Yi Wang wrote: > Similar to krane-sku176 but using a different panel source. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > Change: > v2: move compatible to board dts > --- > .../devicetree/bindings/arm/mediatek.yaml | 1 + > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ > 3 files changed, 25 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 53f0d4e3ea982..3276f7a2ce672 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -120,6 +120,7 @@ properties: > - const: mediatek,mt8183 > - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) > items: > + - const: google,krane-sku0 > - const: google,krane-sku176 > - const: google,krane > - const: mediatek,mt8183 This says you must have all 4 compatible strings in the order listed. That doesn't match your dts. I assume you want the first 2 under an 'enum' so there's 3 strings with the first one being sku0 or sku176? Rob
On Wed, Jan 13, 2021 at 11:20 AM Rob Herring <robh@kernel.org> wrote: > > On Thu, Jan 07, 2021 at 01:22:06PM +0800, Hsin-Yi Wang wrote: > > Similar to krane-sku176 but using a different panel source. > > > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > > --- > > Change: > > v2: move compatible to board dts > > --- > > .../devicetree/bindings/arm/mediatek.yaml | 1 + > > arch/arm64/boot/dts/mediatek/Makefile | 1 + > > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ > > 3 files changed, 25 insertions(+) > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > > > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > > index 53f0d4e3ea982..3276f7a2ce672 100644 > > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > > @@ -120,6 +120,7 @@ properties: > > - const: mediatek,mt8183 > > - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) > > items: > > + - const: google,krane-sku0 > > - const: google,krane-sku176 > > - const: google,krane > > - const: mediatek,mt8183 > > This says you must have all 4 compatible strings in the order listed. > That doesn't match your dts. I assume you want the first 2 under an > 'enum' so there's 3 strings with the first one being sku0 or sku176? > Right. I'll fix in the next version. Thanks > Rob
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index 53f0d4e3ea982..3276f7a2ce672 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -120,6 +120,7 @@ properties: - const: mediatek,mt8183 - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) items: + - const: google,krane-sku0 - const: google,krane-sku176 - const: google,krane - const: mediatek,mt8183 diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile index 18f7b46c4095b..deba27ab76574 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts new file mode 100644 index 0000000000000..fb5ee91b6fe0e --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2019 Google LLC + * + * Device-tree for Krane sku0. + * + * SKU is a 8-bit value (0x00 == 0): + * - Bits 7..4: Panel ID: 0x0 (AUO) + * - Bits 3..0: SKU ID: 0x0 (default) + */ + +/dts-v1/; +#include "mt8183-kukui-krane.dtsi" + +/ { + model = "MediaTek krane sku0 board"; + compatible = "google,krane-sku0", "google,krane", "mediatek,mt8183"; +}; + +&panel { + status = "okay"; + compatible = "auo,kd101n80-45na"; +};
Similar to krane-sku176 but using a different panel source. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- Change: v2: move compatible to board dts --- .../devicetree/bindings/arm/mediatek.yaml | 1 + arch/arm64/boot/dts/mediatek/Makefile | 1 + .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ 3 files changed, 25 insertions(+) create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts