diff mbox series

[v9,01/10] iommu: Remove obsolete comment

Message ID 20210108145217.2254447-2-jean-philippe@linaro.org
State New
Headers show
Series iommu: I/O page faults for SMMUv3 | expand

Commit Message

Jean-Philippe Brucker Jan. 8, 2021, 2:52 p.m. UTC
Commit 986d5ecc5699 ("iommu: Move fwspec->iommu_priv to struct
dev_iommu") removed iommu_priv from fwspec. Update the struct doc.

Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
---
 include/linux/iommu.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Jonathan Cameron Jan. 19, 2021, 11:11 a.m. UTC | #1
On Fri, 8 Jan 2021 15:52:09 +0100
Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:

> Commit 986d5ecc5699 ("iommu: Move fwspec->iommu_priv to struct

> dev_iommu") removed iommu_priv from fwspec. Update the struct doc.

> 

> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org


Hi Jean-Philippe,

Flags parameter doesn't have any docs in this structure and should
do given kernel-doc should be complete.  It probably spits out a warning
for this if you build with W=1

Not sure if it makes sense to fix that in this same patch, or as a different
one as the responsible patch is a different one.
Looks like that came in:
Commit 5702ee24182f ("ACPI/IORT: Check ATS capability in root complex nodes")

Also, good to get this patch merged asap so we cut down on the noise in the
interesting part of this series!

FWIW
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>


Jonathan


> ---

>  include/linux/iommu.h | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/include/linux/iommu.h b/include/linux/iommu.h

> index b3f0e2018c62..26bcde5e7746 100644

> --- a/include/linux/iommu.h

> +++ b/include/linux/iommu.h

> @@ -570,7 +570,6 @@ struct iommu_group *fsl_mc_device_group(struct device *dev);

>   * struct iommu_fwspec - per-device IOMMU instance data

>   * @ops: ops for this device's IOMMU

>   * @iommu_fwnode: firmware handle for this device's IOMMU

> - * @iommu_priv: IOMMU driver private data for this device

>   * @num_pasid_bits: number of PASID bits supported by this device

>   * @num_ids: number of associated device IDs

>   * @ids: IDs which this device may present to the IOMMU
Jean-Philippe Brucker Jan. 20, 2021, 5:41 p.m. UTC | #2
On Tue, Jan 19, 2021 at 11:11:44AM +0000, Jonathan Cameron wrote:
> On Fri, 8 Jan 2021 15:52:09 +0100

> Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:

> 

> > Commit 986d5ecc5699 ("iommu: Move fwspec->iommu_priv to struct

> > dev_iommu") removed iommu_priv from fwspec. Update the struct doc.

> > 

> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org

> 

> Hi Jean-Philippe,

> 

> Flags parameter doesn't have any docs in this structure and should

> do given kernel-doc should be complete.  It probably spits out a warning

> for this if you build with W=1


Ah right, I had a patch removing the flags field locally, but I'm not
planning to upstream that one anymore. I don't mind fixing up the comment
in next version.

Thanks,
Jean

> 

> Not sure if it makes sense to fix that in this same patch, or as a different

> one as the responsible patch is a different one.

> Looks like that came in:

> Commit 5702ee24182f ("ACPI/IORT: Check ATS capability in root complex nodes")

> 

> Also, good to get this patch merged asap so we cut down on the noise in the

> interesting part of this series!

> 

> FWIW

> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> 

> Jonathan
diff mbox series

Patch

diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index b3f0e2018c62..26bcde5e7746 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -570,7 +570,6 @@  struct iommu_group *fsl_mc_device_group(struct device *dev);
  * struct iommu_fwspec - per-device IOMMU instance data
  * @ops: ops for this device's IOMMU
  * @iommu_fwnode: firmware handle for this device's IOMMU
- * @iommu_priv: IOMMU driver private data for this device
  * @num_pasid_bits: number of PASID bits supported by this device
  * @num_ids: number of associated device IDs
  * @ids: IDs which this device may present to the IOMMU