From patchwork Tue Aug 26 18:47:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Rae X-Patchwork-Id: 36044 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f69.google.com (mail-qa0-f69.google.com [209.85.216.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C323020551 for ; Tue, 26 Aug 2014 18:46:22 +0000 (UTC) Received: by mail-qa0-f69.google.com with SMTP id v10sf43646121qac.8 for ; Tue, 26 Aug 2014 11:46:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=F9f94Vjnga3IFwlo6QJH4zh0nLQJp7cI9tKHx02MCak=; b=VH2nPJ6cFa8NbK6QJVgFAyKI48KJ9NO6tw4atBJzdL17ZQ3nt05ZGjUTrGIDZR6MXb BupjUTe7o0nHy7f1DizPI7yO73SS1ASToMcOS/KHcP8aGHRtjtnujMFjtcFdgEGESZ6X CdoD7xpUC0QH2qBlMkysxuk41wc8yzxh/mDxRYDBYn15s4wKlSuKuBgCXW8lNs9DHt6L 2tajw5jyVzNwNCjTyhGogX4fjJZmnEjtDXm5/QQYZQwM1XqOOz0BFnCDk020dkRluxlj nsPHoLlmt7EyoG4EtXRcMbYF+oqmY4CShzl2fiGzKUd+Mkc5TzW7cH/JZQOgn97j+jZ0 B12Q== X-Gm-Message-State: ALoCoQlTpcOrgc8hU5cknNemg41dloZBc35Zis5nVi4t0ipdz4tZszAMqzQsbh9jTSom0af6TXTU X-Received: by 10.52.1.233 with SMTP id 9mr10646849vdp.5.1409078782605; Tue, 26 Aug 2014 11:46:22 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.102.23 with SMTP id v23ls2691873qge.51.gmail; Tue, 26 Aug 2014 11:46:22 -0700 (PDT) X-Received: by 10.236.203.134 with SMTP id f6mr3973305yho.125.1409078782511; Tue, 26 Aug 2014 11:46:22 -0700 (PDT) Received: from mail-yh0-f43.google.com (mail-yh0-f43.google.com [209.85.213.43]) by mx.google.com with ESMTPS id i61si3284406yhd.31.2014.08.26.11.46.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 26 Aug 2014 11:46:22 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.213.43 as permitted sender) client-ip=209.85.213.43; Received: by mail-yh0-f43.google.com with SMTP id 29so12424623yhl.30 for ; Tue, 26 Aug 2014 11:46:22 -0700 (PDT) X-Received: by 10.220.59.65 with SMTP id k1mr25057880vch.22.1409078782412; Tue, 26 Aug 2014 11:46:22 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp221678vcb; Tue, 26 Aug 2014 11:46:21 -0700 (PDT) X-Received: by 10.180.37.241 with SMTP id b17mr23293928wik.70.1409078780387; Tue, 26 Aug 2014 11:46:20 -0700 (PDT) Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id pt8si5064209wjc.98.2014.08.26.11.46.19 for ; Tue, 26 Aug 2014 11:46:20 -0700 (PDT) Received-SPF: none (google.com: u-boot-bounces@lists.denx.de does not designate permitted sender hosts) client-ip=85.214.87.163; Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 954A5A74BE; Tue, 26 Aug 2014 20:46:19 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OMmXMRVj21Kb; Tue, 26 Aug 2014 20:46:19 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 848CBA7496; Tue, 26 Aug 2014 20:46:16 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 909CCA7496 for ; Tue, 26 Aug 2014 20:46:14 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jjCWrvLdx3yH for ; Tue, 26 Aug 2014 20:46:12 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-gw2-out.broadcom.com (mail-gw2-out.broadcom.com [216.31.210.63]) by theia.denx.de (Postfix) with ESMTP id 966AFA74A0 for ; Tue, 26 Aug 2014 20:46:11 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.04,405,1406617200"; d="scan'208";a="43697648" Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57]) by mail-gw2-out.broadcom.com with ESMTP; 26 Aug 2014 12:00:59 -0700 Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.3.174.1; Tue, 26 Aug 2014 11:46:10 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.3.174.1; Tue, 26 Aug 2014 11:46:10 -0700 Received: from mail.broadcom.com (lbrmn-vmlnx03.ric.broadcom.com [10.136.4.105]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 3FECA9F9FD; Tue, 26 Aug 2014 11:46:08 -0700 (PDT) From: Steve Rae To: Lukasz Majewski Date: Tue, 26 Aug 2014 11:47:28 -0700 Message-ID: <1409078850-7873-3-git-send-email-srae@broadcom.com> X-Mailer: git-send-email 1.8.5 In-Reply-To: <1409078850-7873-1-git-send-email-srae@broadcom.com> References: <1409078850-7873-1-git-send-email-srae@broadcom.com> MIME-Version: 1.0 Cc: Steve Rae , Marek Vasut , Pantelis Antoniou , u-boot@lists.denx.de, Tom Rini Subject: [U-Boot] [PATCH v6 2/4] usb/gadget: fastboot: add support for flash command X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: srae@broadcom.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.213.43 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 - implement 'fastboot flash' for eMMC devices Signed-off-by: Steve Rae Acked-by: Lukasz Majewski Reviewed-by: Marek Vasut --- Changes in v6: - fix spelling Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - update README.android-fastboot file README | 10 ++++++++++ doc/README.android-fastboot | 5 +++-- drivers/usb/gadget/f_fastboot.c | 31 +++++++++++++++++++++++++++++++ 3 files changed, 44 insertions(+), 2 deletions(-) diff --git a/README b/README index 14d6b22..5e8c9ed 100644 --- a/README +++ b/README @@ -1624,6 +1624,16 @@ The following options need to be configured: downloads. This buffer should be as large as possible for a platform. Define this to the size available RAM for fastboot. + CONFIG_FASTBOOT_FLASH + The fastboot protocol includes a "flash" command for writing + the downloaded image to a non-volatile storage device. Define + this to enable the "fastboot flash" command. + + CONFIG_FASTBOOT_FLASH_MMC_DEV + The fastboot "flash" command requires additional information + regarding the non-volatile storage device. Define this to + the eMMC device that fastboot should use to store the image. + - Journaling Flash filesystem support: CONFIG_JFFS2_NAND, CONFIG_JFFS2_NAND_OFF, CONFIG_JFFS2_NAND_SIZE, CONFIG_JFFS2_NAND_DEV diff --git a/doc/README.android-fastboot b/doc/README.android-fastboot index 4045727..1677609 100644 --- a/doc/README.android-fastboot +++ b/doc/README.android-fastboot @@ -6,8 +6,9 @@ Overview The protocol that is used over USB is described in README.android-fastboot-protocol in same directory. -The current implementation does not yet support the flash and erase -commands. +The current implementation does not yet support the erase command or the +"oem format" command, and there is minimal support for the flash command; +it only supports eMMC devices. Client installation =================== diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c index 7a1acb9..e2659fa 100644 --- a/drivers/usb/gadget/f_fastboot.c +++ b/drivers/usb/gadget/f_fastboot.c @@ -19,6 +19,9 @@ #include #include #include +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV +#include +#endif #define FASTBOOT_VERSION "0.4" @@ -469,6 +472,28 @@ static void cb_boot(struct usb_ep *ep, struct usb_request *req) fastboot_tx_write_str("OKAY"); } +#ifdef CONFIG_FASTBOOT_FLASH +static void cb_flash(struct usb_ep *ep, struct usb_request *req) +{ + char *cmd = req->buf; + char response[RESPONSE_LEN]; + + strsep(&cmd, ":"); + if (!cmd) { + printf("%s: missing partition name\n", __func__); + fastboot_tx_write_str("FAILmissing partition name"); + return; + } + + strcpy(response, "FAILno flash device defined"); +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV + fb_mmc_flash_write(cmd, (void *)CONFIG_USB_FASTBOOT_BUF_ADDR, + download_bytes, response); +#endif + fastboot_tx_write_str(response); +} +#endif + struct cmd_dispatch_info { char *cmd; void (*cb)(struct usb_ep *ep, struct usb_request *req); @@ -488,6 +513,12 @@ static const struct cmd_dispatch_info cmd_dispatch_info[] = { .cmd = "boot", .cb = cb_boot, }, +#ifdef CONFIG_FASTBOOT_FLASH + { + .cmd = "flash", + .cb = cb_flash, + }, +#endif }; static void rx_handler_command(struct usb_ep *ep, struct usb_request *req)