| Message ID | 1409141379-18946-1-git-send-email-broonie@kernel.org |
|---|---|
| State | New |
| Headers | show |
On 08/27/2014 03:09 PM, Mark Brown wrote: > From: Mark Brown <broonie@linaro.org> > > If the device can't support block writes then don't attempt to use raw > syncing which will automatically generate block writes for adjacent > registers, use the existing _single() block syncing implementation. > > Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > Signed-off-by: Mark Brown <broonie@linaro.org> > --- > drivers/base/regmap/regcache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > This works too with RT5642. It appeared page select for _regmap_write() is actually handled implicitly for certain cases. regmap_init() sets "map->reg_write = _regmap_bus_raw_write" in this case and _regmap_bus_raw_write() then calls _regmap_raw_write(). I guess that can be fixed when doing other cleanups or if some setup hits it. Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index 29b4128da0b0..5617da6dc898 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -698,7 +698,7 @@ int regcache_sync_block(struct regmap *map, void *block, unsigned int block_base, unsigned int start, unsigned int end) { - if (regmap_can_raw_write(map)) + if (regmap_can_raw_write(map) && !map->use_single_rw) return regcache_sync_block_raw(map, block, cache_present, block_base, start, end); else