diff mbox

[edk2] FW: SF.net SVN: edk2:[15938] trunk/edk2/BaseTools/Source/C/Makefiles/header. makefile

Message ID 0877601216922E4B83A7129715B5DA2BAC6EF7F0DF@GEORGE.Emea.Arm.com
State New
Headers show

Commit Message

Olivier Martin Sept. 1, 2014, 11:28 a.m. UTC
This commit breaks my BaseTools build:

gcc  -c -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -nostdlib -c -g  -I .. -I ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I . -I ../Include/X64/  BasePeCoff.c -o BasePeCoff.o
cc1: error: unrecognized command line option "-Wno-self-assign"

GCC version: gcc (Ubuntu 4.4.3-4ubuntu5.1) 4.4.3
Distribution: Ubuntu 10.04.3 LTS

I know I am using an old distribution...


-----Original Message-----
From: andrewfish@users.sourceforge.net [mailto:andrewfish@users.sourceforge.net]
Sent: 28 August 2014 06:14
To: edk2-commits@lists.sourceforge.net
Subject: SF.net SVN: edk2:[15938] trunk/edk2/BaseTools/Source/C/Makefiles/header. makefile

Revision: 15938
          http://sourceforge.net/p/edk2/code/15938
Author:   andrewfish
Date:     2014-08-28 05:13:37 +0000 (Thu, 28 Aug 2014)
Log Message:
-----------
BaseTools: Fix BaseTools C compiler flags for Xcode 5

-fno-merge-constants is not supported by clang, and it warns it will turn into
  a hard error in the future.
-Wno-deprecated-declarations removes warnings about obsolete libraries that
  are not secure.
-Wno-self-assign removes warnings from LZMA code.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anderw Fish <afish@apple.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

Modified Paths:
--------------
    trunk/edk2/BaseTools/Source/C/Makefiles/header.makefile

Modified: trunk/edk2/BaseTools/Source/C/Makefiles/header.makefile

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.


------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/

Comments

Olivier Martin Sept. 1, 2014, 1:05 p.m. UTC | #1
Sorry, I mixed the machine configurations. It builds fine on my old
distribution, but not on our build server:
- gcc (GCC) 3.4.2
- RHEL 5.8 (20 February 2012)


> -----Original Message-----
> From: Olivier Martin [mailto:Olivier.Martin@arm.com]
> Sent: 01 September 2014 12:28
> To: Andrew Fish; edk2-devel@lists.sourceforge.net
> Subject: [edk2] FW: SF.net SVN: edk2:[15938]
> trunk/edk2/BaseTools/Source/C/Makefiles/header. makefile
> 
> This commit breaks my BaseTools build:
> 
> gcc  -c -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-
> deprecated-declarations -Wno-self-assign -nostdlib -c -g  -I .. -I
> ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I
> ../Common/ -I .. -I . -I ../Include/X64/  BasePeCoff.c -o BasePeCoff.o
> cc1: error: unrecognized command line option "-Wno-self-assign"
> 
> GCC version: gcc (Ubuntu 4.4.3-4ubuntu5.1) 4.4.3
> Distribution: Ubuntu 10.04.3 LTS
> 
> I know I am using an old distribution...
> 
> 
> -----Original Message-----
> From: andrewfish@users.sourceforge.net
> [mailto:andrewfish@users.sourceforge.net]
> Sent: 28 August 2014 06:14
> To: edk2-commits@lists.sourceforge.net
> Subject: SF.net SVN: edk2:[15938]
> trunk/edk2/BaseTools/Source/C/Makefiles/header. makefile
> 
> Revision: 15938
>           http://sourceforge.net/p/edk2/code/15938
> Author:   andrewfish
> Date:     2014-08-28 05:13:37 +0000 (Thu, 28 Aug 2014)
> Log Message:
> -----------
> BaseTools: Fix BaseTools C compiler flags for Xcode 5
> 
> -fno-merge-constants is not supported by clang, and it warns it will
> turn into
>   a hard error in the future.
> -Wno-deprecated-declarations removes warnings about obsolete libraries
> that
>   are not secure.
> -Wno-self-assign removes warnings from LZMA code.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Anderw Fish <afish@apple.com>
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> Modified Paths:
> --------------
>     trunk/edk2/BaseTools/Source/C/Makefiles/header.makefile
> 
> Modified: trunk/edk2/BaseTools/Source/C/Makefiles/header.makefile
> ===================================================================
> --- trunk/edk2/BaseTools/Source/C/Makefiles/header.makefile     2014-
> 08-28 05:13:05 UTC (rev 15937)
> +++ trunk/edk2/BaseTools/Source/C/Makefiles/header.makefile     2014-
> 08-28 05:13:37 UTC (rev 15938)
> @@ -41,7 +41,7 @@
> 
>  INCLUDE = $(TOOL_INCLUDE) -I $(MAKEROOT) -I $(MAKEROOT)/Include/Common
> -I $(MAKEROOT)/Include/ -I $(MAKEROOT)/Include/IndustryStandard -I
> $(MAKEROOT)/Common/ -I .. -I . $(ARCH_INCLUDE)
>  CPPFLAGS = $(INCLUDE)
> -CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -fno-merge-constants -
> nostdlib -Wall -Werror -c -g
> +CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-
> deprecated-declarations -Wno-self-assign -nostdlib -c -g
>  LFLAGS =
> 
>  ifeq ($(ARCH), IA32)
> 
> This was sent by the SourceForge.net collaborative development
> platform, the world's largest Open Source development site.
> 
> 
> -----------------------------------------------------------------------
> -------
> Slashdot TV.
> Video for Nerds.  Stuff that matters.
> http://tv.slashdot.org/
> _______________________________________________
> edk2-commits mailing list
> edk2-commits@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-commits
> 
> 
> -- IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy
> the information in any medium.  Thank you.
> 
> ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ,
> Registered in England & Wales, Company No:  2557590
> ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1
> 9NJ, Registered in England & Wales, Company No:  2548782
> 
> 
> -----------------------------------------------------------------------
> -------
> Slashdot TV.
> Video for Nerds.  Stuff that matters.
> http://tv.slashdot.org/
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel





------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
diff mbox

Patch

===================================================================
--- trunk/edk2/BaseTools/Source/C/Makefiles/header.makefile     2014-08-28 05:13:05 UTC (rev 15937)
+++ trunk/edk2/BaseTools/Source/C/Makefiles/header.makefile     2014-08-28 05:13:37 UTC (rev 15938)
@@ -41,7 +41,7 @@ 

 INCLUDE = $(TOOL_INCLUDE) -I $(MAKEROOT) -I $(MAKEROOT)/Include/Common -I $(MAKEROOT)/Include/ -I $(MAKEROOT)/Include/IndustryStandard -I $(MAKEROOT)/Common/ -I .. -I . $(ARCH_INCLUDE)
 CPPFLAGS = $(INCLUDE)
-CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -fno-merge-constants -nostdlib -Wall -Werror -c -g
+CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -nostdlib -c -g
 LFLAGS =

 ifeq ($(ARCH), IA32)