| Message ID | 20210116090656.11752-11-chunfeng.yun@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | None | expand |
Hello! On 16.01.2021 12:06, Chunfeng Yun wrote: > This is used to fix dtbs_check warning > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > index 5b9ec032ce8d..4cfa09b0ca3c 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > @@ -740,8 +740,8 @@ > status = "disabled"; > }; > > - u3phy: usb-phy@1a0c4000 { > - compatible = "mediatek,mt7622-u3phy", > + u3phy: t-phy@1a0c4000 { What is "t-phy"? Perhaps you should have used just "phy" here... > + compatible = "mediatek,mt7622-tphy", > "mediatek,generic-tphy-v1"; > reg = <0 0x1a0c4000 0 0x700>; > #address-cells = <2>; > @@ -875,8 +875,9 @@ > status = "disabled"; > }; > > - sata_phy: sata-phy@1a243000 { > - compatible = "mediatek,generic-tphy-v1"; > + sata_phy: t-phy@1a243000 { Same here... > + compatible = "mediatek,mt7622-tphy", > + "mediatek,generic-tphy-v1"; > #address-cells = <2>; > #size-cells = <2>; > ranges; MBR, Sergei
On Sat, 2021-01-16 at 12:36 +0300, Sergei Shtylyov wrote: > Hello! > > On 16.01.2021 12:06, Chunfeng Yun wrote: > > > This is used to fix dtbs_check warning > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > index 5b9ec032ce8d..4cfa09b0ca3c 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > @@ -740,8 +740,8 @@ > > status = "disabled"; > > }; > > > > - u3phy: usb-phy@1a0c4000 { > > - compatible = "mediatek,mt7622-u3phy", > > + u3phy: t-phy@1a0c4000 { > > What is "t-phy"? Perhaps you should have used just "phy" here... At first I use "phy", but it causes dt_binding_check fail: "'#phy-cells' is a required property" Due to we only need add '#phy-cells' for each subnode (usb-phy, pcie-phy or sata-phy), but not for parent one, I change the parent node name as "t-phy" which is a glue layer node, not a real phy. I also prefer to "phy", but seems dt_binding_check can't distinguish this case. Thanks > > > + compatible = "mediatek,mt7622-tphy", > > "mediatek,generic-tphy-v1"; > > reg = <0 0x1a0c4000 0 0x700>; > > #address-cells = <2>; > > @@ -875,8 +875,9 @@ > > status = "disabled"; > > }; > > > > - sata_phy: sata-phy@1a243000 { > > - compatible = "mediatek,generic-tphy-v1"; > > + sata_phy: t-phy@1a243000 { > > Same here... > > > + compatible = "mediatek,mt7622-tphy", > > + "mediatek,generic-tphy-v1"; > > #address-cells = <2>; > > #size-cells = <2>; > > ranges; > > MBR, Sergei
diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi index 5b9ec032ce8d..4cfa09b0ca3c 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi @@ -740,8 +740,8 @@ status = "disabled"; }; - u3phy: usb-phy@1a0c4000 { - compatible = "mediatek,mt7622-u3phy", + u3phy: t-phy@1a0c4000 { + compatible = "mediatek,mt7622-tphy", "mediatek,generic-tphy-v1"; reg = <0 0x1a0c4000 0 0x700>; #address-cells = <2>; @@ -875,8 +875,9 @@ status = "disabled"; }; - sata_phy: sata-phy@1a243000 { - compatible = "mediatek,generic-tphy-v1"; + sata_phy: t-phy@1a243000 { + compatible = "mediatek,mt7622-tphy", + "mediatek,generic-tphy-v1"; #address-cells = <2>; #size-cells = <2>; ranges;
This is used to fix dtbs_check warning Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.18.0