From patchwork Thu Sep 4 07:34:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 36681 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yk0-f198.google.com (mail-yk0-f198.google.com [209.85.160.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1C50F202E4 for ; Thu, 4 Sep 2014 07:35:45 +0000 (UTC) Received: by mail-yk0-f198.google.com with SMTP id q200sf30327522ykb.9 for ; Thu, 04 Sep 2014 00:35:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=k4tuGotSOA9s6vzYpYesXA2UoowKyUXBbSMtJFphRYo=; b=OSKFbldbIc9hy3WOxMjAnK1NBH55wnzCGAI7TLy2voQM7dv9QhVvp+FRF5K0jX/5cd 6h+dvb8OEYMWPB4Xu3Aww2xgZsjPkXpmTSvM92fXZWi45S40+V0YYHQvRCZ2pYGTRXvi Wd5EYPnPuRdUs6sySDwrCNkfx+UEVqASSldY+bDH7VcWIkwd5SvIyDKYiwPvc5MyH0xL s+oQgK6Ah8o6muG2VTdWsE5MqnhxW5tcza0eA42YJGGEd7jaCfvfmAJ8qrFEQkKOe7JK zmUqyJCl6NgsMWooCBdifLlRnKpQ6GclaRdy2A2zFf7E0ouP4DgZyom6C+3uxiaunF3k SIzQ== X-Gm-Message-State: ALoCoQkco/pRXnPXG6uQtluzckYWG4wXMO3NitovcCQBlIMa1Mgt48/i2CmkFmaPfPErf7QvAfl1 X-Received: by 10.236.2.196 with SMTP id 44mr1437990yhf.51.1409816144798; Thu, 04 Sep 2014 00:35:44 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.16.232 with SMTP id 95ls143762qgb.94.gmail; Thu, 04 Sep 2014 00:35:44 -0700 (PDT) X-Received: by 10.220.49.10 with SMTP id t10mr2056134vcf.34.1409816144728; Thu, 04 Sep 2014 00:35:44 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id kl5si2044766vdb.26.2014.09.04.00.35.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 04 Sep 2014 00:35:44 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id im17so10091202vcb.4 for ; Thu, 04 Sep 2014 00:35:44 -0700 (PDT) X-Received: by 10.52.129.165 with SMTP id nx5mr853882vdb.25.1409816144649; Thu, 04 Sep 2014 00:35:44 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp794511vcb; Thu, 4 Sep 2014 00:35:44 -0700 (PDT) X-Received: by 10.70.50.170 with SMTP id d10mr3563069pdo.33.1409816143548; Thu, 04 Sep 2014 00:35:43 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id er3si1996247pbb.53.2014.09.04.00.35.37 for ; Thu, 04 Sep 2014 00:35:38 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756765AbaIDHf3 (ORCPT + 26 others); Thu, 4 Sep 2014 03:35:29 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:33214 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbaIDHfZ (ORCPT ); Thu, 4 Sep 2014 03:35:25 -0400 Received: by mail-wi0-f170.google.com with SMTP id cc10so7094104wib.3 for ; Thu, 04 Sep 2014 00:35:24 -0700 (PDT) X-Received: by 10.180.38.114 with SMTP id f18mr3459878wik.24.1409816124711; Thu, 04 Sep 2014 00:35:24 -0700 (PDT) Received: from lmenx30s.lme.st.com (LPuteaux-656-01-48-212.w82-127.abo.wanadoo.fr. [82.127.83.212]) by mx.google.com with ESMTPSA id s2sm18495311wjz.8.2014.09.04.00.35.22 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 04 Sep 2014 00:35:23 -0700 (PDT) From: Vincent Guittot To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, preeti@linux.vnet.ibm.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org Cc: riel@redhat.com, Morten.Rasmussen@arm.com, efault@gmx.de, nicolas.pitre@linaro.org, linaro-kernel@lists.linaro.org, daniel.lezcano@linaro.org, dietmar.eggemann@arm.com, Vincent Guittot Subject: Re: [PATCH v5 09/11] sched: add usage_load_avg Date: Thu, 4 Sep 2014 09:34:39 +0200 Message-Id: <1409816079-10131-1-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1409051215-16788-10-git-send-email-vincent.guittot@linaro.org> References: <1409051215-16788-10-git-send-email-vincent.guittot@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: vincent.guittot@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The update of update_rq_runnable_avg interface is missing for CONFIG_FAIR_GROUP_SCHED in the original patch "[PATCH v5 09/12] sched: add usage_load_avg" Signed-off-by: Vincent Guittot --- Hi Peter, Do you prefer that I sent a new version of "[PATCH v5 09/12] sched: add usage_load_avg" patch with the fix or this fix is enough ? Regards, Vincent kernel/sched/fair.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 1fd2131..cbe3eff 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2462,7 +2462,8 @@ static inline void __update_group_entity_contrib(struct sched_entity *se) static inline void update_rq_runnable_avg(struct rq *rq, int runnable) { - __update_entity_runnable_avg(rq_clock_task(rq), &rq->avg, runnable); + __update_entity_runnable_avg(rq_clock_task(rq), &rq->avg, runnable, + runnable); __update_tg_runnable_avg(&rq->avg, &rq->cfs); } #else /* CONFIG_FAIR_GROUP_SCHED */