[v3,5/6] drivers: crypto: qce: Remover src_tbl from qce_cipher_reqctx

Message ID 20210120184843.3217775-6-thara.gopinath@linaro.org
State Superseded
Headers show
Series
  • Regression fixes/clean ups in the Qualcomm crypto engine driver
Related show

Commit Message

Thara Gopinath Jan. 20, 2021, 6:48 p.m.
src_table is unused and hence remove it from struct qce_cipher_reqctx

Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>

---
 drivers/crypto/qce/cipher.h | 1 -
 1 file changed, 1 deletion(-)

-- 
2.25.1

Comments

Bjorn Andersson Jan. 25, 2021, 4:32 p.m. | #1
On Wed 20 Jan 12:48 CST 2021, Thara Gopinath wrote:

> src_table is unused and hence remove it from struct qce_cipher_reqctx

> 

> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>

> ---

>  drivers/crypto/qce/cipher.h | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/drivers/crypto/qce/cipher.h b/drivers/crypto/qce/cipher.h

> index cffa9fc628ff..850f257d00f3 100644

> --- a/drivers/crypto/qce/cipher.h

> +++ b/drivers/crypto/qce/cipher.h

> @@ -40,7 +40,6 @@ struct qce_cipher_reqctx {

>  	struct scatterlist result_sg;

>  	struct sg_table dst_tbl;

>  	struct scatterlist *dst_sg;

> -	struct sg_table src_tbl;


Please also remove the associated kerneldoc entry.

Regards,
Bjorn

>  	struct scatterlist *src_sg;

>  	unsigned int cryptlen;

>  	struct skcipher_request fallback_req;	// keep at the end

> -- 

> 2.25.1

>

Patch

diff --git a/drivers/crypto/qce/cipher.h b/drivers/crypto/qce/cipher.h
index cffa9fc628ff..850f257d00f3 100644
--- a/drivers/crypto/qce/cipher.h
+++ b/drivers/crypto/qce/cipher.h
@@ -40,7 +40,6 @@  struct qce_cipher_reqctx {
 	struct scatterlist result_sg;
 	struct sg_table dst_tbl;
 	struct scatterlist *dst_sg;
-	struct sg_table src_tbl;
 	struct scatterlist *src_sg;
 	unsigned int cryptlen;
 	struct skcipher_request fallback_req;	// keep at the end