| Message ID | 1409858602-28035-1-git-send-email-anders.roxell@linaro.org |
|---|---|
| State | New |
| Headers | show |
This patch will break odp apps which use helpers. Maxim. On 09/04/2014 11:23 PM, Anders Roxell wrote: > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > platform/linux-dpdk/Makefile.am | 2 +- > platform/linux-generic/Makefile.am | 2 +- > platform/linux-keystone2/Makefile.am | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/platform/linux-dpdk/Makefile.am b/platform/linux-dpdk/Makefile.am > index a59435f..3787dc9 100644 > --- a/platform/linux-dpdk/Makefile.am > +++ b/platform/linux-dpdk/Makefile.am > @@ -52,7 +52,7 @@ include_HEADERS = \ > $(top_srcdir)/platform/linux-generic/include/api/odp_timer.h \ > $(top_srcdir)/platform/linux-generic/include/api/odp_version.h > > -subdirheadersdir = $(includedir)/helper > +subdirheadersdir = $(includedir) > subdirheaders_HEADERS = \ > $(top_srcdir)/helper/include/odph_chksum.h \ > $(top_srcdir)/helper/include/odph_eth.h \ > diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am > index 25c82ea..7b4522e 100644 > --- a/platform/linux-generic/Makefile.am > +++ b/platform/linux-generic/Makefile.am > @@ -40,7 +40,7 @@ include_HEADERS = \ > $(top_srcdir)/platform/linux-generic/include/api/odp_pktio_netmap.h \ > $(top_srcdir)/platform/linux-generic/include/api/odp_pktio_socket.h > > -subdirheadersdir = $(includedir)/helper > +subdirheadersdir = $(includedir) > subdirheaders_HEADERS = \ > $(top_srcdir)/helper/include/odph_chksum.h \ > $(top_srcdir)/helper/include/odph_eth.h \ > diff --git a/platform/linux-keystone2/Makefile.am b/platform/linux-keystone2/Makefile.am > index 027c035..54bce26 100644 > --- a/platform/linux-keystone2/Makefile.am > +++ b/platform/linux-keystone2/Makefile.am > @@ -55,7 +55,7 @@ include_HEADERS = \ > $(top_srcdir)/platform/linux-generic/include/api/odp_timer.h \ > $(top_srcdir)/platform/linux-generic/include/api/odp_version.h > > -subdirheadersdir = $(includedir)/helper > +subdirheadersdir = $(includedir) > subdirheaders_HEADERS = \ > $(top_srcdir)/helper/include/odph_chksum.h \ > $(top_srcdir)/helper/include/odph_eth.h \
Isn't that the point of the pre 1.0 SW so that we reorganize as we evolve to some thing we say will remain stable? On Sep 9, 2014 6:08 PM, "Maxim Uvarov" <maxim.uvarov@linaro.org> wrote: > This patch will break odp apps which use helpers. > > Maxim. > > On 09/04/2014 11:23 PM, Anders Roxell wrote: > >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> --- >> platform/linux-dpdk/Makefile.am | 2 +- >> platform/linux-generic/Makefile.am | 2 +- >> platform/linux-keystone2/Makefile.am | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/platform/linux-dpdk/Makefile.am b/platform/linux-dpdk/ >> Makefile.am >> index a59435f..3787dc9 100644 >> --- a/platform/linux-dpdk/Makefile.am >> +++ b/platform/linux-dpdk/Makefile.am >> @@ -52,7 +52,7 @@ include_HEADERS = \ >> $(top_srcdir)/platform/linux- >> generic/include/api/odp_timer.h \ >> $(top_srcdir)/platform/linux-generic/include/api/odp_ >> version.h >> -subdirheadersdir = $(includedir)/helper >> +subdirheadersdir = $(includedir) >> subdirheaders_HEADERS = \ >> $(top_srcdir)/helper/include/odph_chksum.h \ >> $(top_srcdir)/helper/include/odph_eth.h \ >> diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/ >> Makefile.am >> index 25c82ea..7b4522e 100644 >> --- a/platform/linux-generic/Makefile.am >> +++ b/platform/linux-generic/Makefile.am >> @@ -40,7 +40,7 @@ include_HEADERS = \ >> $(top_srcdir)/platform/linux- >> generic/include/api/odp_pktio_netmap.h \ >> $(top_srcdir)/platform/linux- >> generic/include/api/odp_pktio_socket.h >> -subdirheadersdir = $(includedir)/helper >> +subdirheadersdir = $(includedir) >> subdirheaders_HEADERS = \ >> $(top_srcdir)/helper/include/odph_chksum.h \ >> $(top_srcdir)/helper/include/odph_eth.h \ >> diff --git a/platform/linux-keystone2/Makefile.am >> b/platform/linux-keystone2/Makefile.am >> index 027c035..54bce26 100644 >> --- a/platform/linux-keystone2/Makefile.am >> +++ b/platform/linux-keystone2/Makefile.am >> @@ -55,7 +55,7 @@ include_HEADERS = \ >> $(top_srcdir)/platform/linux- >> generic/include/api/odp_timer.h \ >> $(top_srcdir)/platform/linux-generic/include/api/odp_ >> version.h >> -subdirheadersdir = $(includedir)/helper >> +subdirheadersdir = $(includedir) >> subdirheaders_HEADERS = \ >> $(top_srcdir)/helper/include/odph_chksum.h \ >> $(top_srcdir)/helper/include/odph_eth.h \ >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
Pre v1.0 changes may be incompatible but the author should coordinate with affected modules to ensure that when applied the result is an ODP that compiles and is functional. Bill On Wednesday, September 10, 2014, Mike Holmes <mike.holmes@linaro.org> wrote: > Isn't that the point of the pre 1.0 SW so that we reorganize as we evolve > to some thing we say will remain stable? > On Sep 9, 2014 6:08 PM, "Maxim Uvarov" <maxim.uvarov@linaro.org > <javascript:_e(%7B%7D,'cvml','maxim.uvarov@linaro.org');>> wrote: > >> This patch will break odp apps which use helpers. >> >> Maxim. >> >> On 09/04/2014 11:23 PM, Anders Roxell wrote: >> >>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org >>> <javascript:_e(%7B%7D,'cvml','anders.roxell@linaro.org');>> >>> --- >>> platform/linux-dpdk/Makefile.am | 2 +- >>> platform/linux-generic/Makefile.am | 2 +- >>> platform/linux-keystone2/Makefile.am | 2 +- >>> 3 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/platform/linux-dpdk/Makefile.am b/platform/linux-dpdk/ >>> Makefile.am >>> index a59435f..3787dc9 100644 >>> --- a/platform/linux-dpdk/Makefile.am >>> +++ b/platform/linux-dpdk/Makefile.am >>> @@ -52,7 +52,7 @@ include_HEADERS = \ >>> $(top_srcdir)/platform/linux- >>> generic/include/api/odp_timer.h \ >>> $(top_srcdir)/platform/linux-generic/include/api/odp_ >>> version.h >>> -subdirheadersdir = $(includedir)/helper >>> +subdirheadersdir = $(includedir) >>> subdirheaders_HEADERS = \ >>> $(top_srcdir)/helper/include/odph_chksum.h \ >>> $(top_srcdir)/helper/include/odph_eth.h \ >>> diff --git a/platform/linux-generic/Makefile.am >>> b/platform/linux-generic/Makefile.am >>> index 25c82ea..7b4522e 100644 >>> --- a/platform/linux-generic/Makefile.am >>> +++ b/platform/linux-generic/Makefile.am >>> @@ -40,7 +40,7 @@ include_HEADERS = \ >>> $(top_srcdir)/platform/linux- >>> generic/include/api/odp_pktio_netmap.h \ >>> $(top_srcdir)/platform/linux- >>> generic/include/api/odp_pktio_socket.h >>> -subdirheadersdir = $(includedir)/helper >>> +subdirheadersdir = $(includedir) >>> subdirheaders_HEADERS = \ >>> $(top_srcdir)/helper/include/odph_chksum.h \ >>> $(top_srcdir)/helper/include/odph_eth.h \ >>> diff --git a/platform/linux-keystone2/Makefile.am >>> b/platform/linux-keystone2/Makefile.am >>> index 027c035..54bce26 100644 >>> --- a/platform/linux-keystone2/Makefile.am >>> +++ b/platform/linux-keystone2/Makefile.am >>> @@ -55,7 +55,7 @@ include_HEADERS = \ >>> $(top_srcdir)/platform/linux- >>> generic/include/api/odp_timer.h \ >>> $(top_srcdir)/platform/linux-generic/include/api/odp_ >>> version.h >>> -subdirheadersdir = $(includedir)/helper >>> +subdirheadersdir = $(includedir) >>> subdirheaders_HEADERS = \ >>> $(top_srcdir)/helper/include/odph_chksum.h \ >>> $(top_srcdir)/helper/include/odph_eth.h \ >>> >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> <javascript:_e(%7B%7D,'cvml','lng-odp@lists.linaro.org');> >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >
On 2014-09-10 18:27, Bill Fischofer wrote: > Pre v1.0 changes may be incompatible but the author should coordinate with > affected modules to ensure that when applied the result is an ODP that > compiles and is functional. I disagree with you here. I don't think the author of this patch has to do that. However, the author of the apps that uses ODP should _only_ use released versions of ODP and not be on latest. If they are on latest they should know that things will/can change. Cheers, Anders > > Bill > > On Wednesday, September 10, 2014, Mike Holmes <mike.holmes@linaro.org> > wrote: > > > Isn't that the point of the pre 1.0 SW so that we reorganize as we evolve > > to some thing we say will remain stable? > > On Sep 9, 2014 6:08 PM, "Maxim Uvarov" <maxim.uvarov@linaro.org > > <javascript:_e(%7B%7D,'cvml','maxim.uvarov@linaro.org');>> wrote: > > > >> This patch will break odp apps which use helpers. > >> > >> Maxim. > >> > >> On 09/04/2014 11:23 PM, Anders Roxell wrote: > >> > >>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org > >>> <javascript:_e(%7B%7D,'cvml','anders.roxell@linaro.org');>> > >>> --- > >>> platform/linux-dpdk/Makefile.am | 2 +- > >>> platform/linux-generic/Makefile.am | 2 +- > >>> platform/linux-keystone2/Makefile.am | 2 +- > >>> 3 files changed, 3 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/platform/linux-dpdk/Makefile.am b/platform/linux-dpdk/ > >>> Makefile.am > >>> index a59435f..3787dc9 100644 > >>> --- a/platform/linux-dpdk/Makefile.am > >>> +++ b/platform/linux-dpdk/Makefile.am > >>> @@ -52,7 +52,7 @@ include_HEADERS = \ > >>> $(top_srcdir)/platform/linux- > >>> generic/include/api/odp_timer.h \ > >>> $(top_srcdir)/platform/linux-generic/include/api/odp_ > >>> version.h > >>> -subdirheadersdir = $(includedir)/helper > >>> +subdirheadersdir = $(includedir) > >>> subdirheaders_HEADERS = \ > >>> $(top_srcdir)/helper/include/odph_chksum.h \ > >>> $(top_srcdir)/helper/include/odph_eth.h \ > >>> diff --git a/platform/linux-generic/Makefile.am > >>> b/platform/linux-generic/Makefile.am > >>> index 25c82ea..7b4522e 100644 > >>> --- a/platform/linux-generic/Makefile.am > >>> +++ b/platform/linux-generic/Makefile.am > >>> @@ -40,7 +40,7 @@ include_HEADERS = \ > >>> $(top_srcdir)/platform/linux- > >>> generic/include/api/odp_pktio_netmap.h \ > >>> $(top_srcdir)/platform/linux- > >>> generic/include/api/odp_pktio_socket.h > >>> -subdirheadersdir = $(includedir)/helper > >>> +subdirheadersdir = $(includedir) > >>> subdirheaders_HEADERS = \ > >>> $(top_srcdir)/helper/include/odph_chksum.h \ > >>> $(top_srcdir)/helper/include/odph_eth.h \ > >>> diff --git a/platform/linux-keystone2/Makefile.am > >>> b/platform/linux-keystone2/Makefile.am > >>> index 027c035..54bce26 100644 > >>> --- a/platform/linux-keystone2/Makefile.am > >>> +++ b/platform/linux-keystone2/Makefile.am > >>> @@ -55,7 +55,7 @@ include_HEADERS = \ > >>> $(top_srcdir)/platform/linux- > >>> generic/include/api/odp_timer.h \ > >>> $(top_srcdir)/platform/linux-generic/include/api/odp_ > >>> version.h > >>> -subdirheadersdir = $(includedir)/helper > >>> +subdirheadersdir = $(includedir) > >>> subdirheaders_HEADERS = \ > >>> $(top_srcdir)/helper/include/odph_chksum.h \ > >>> $(top_srcdir)/helper/include/odph_eth.h \ > >>> > >> > >> > >> _______________________________________________ > >> lng-odp mailing list > >> lng-odp@lists.linaro.org > >> <javascript:_e(%7B%7D,'cvml','lng-odp@lists.linaro.org');> > >> http://lists.linaro.org/mailman/listinfo/lng-odp > >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp
I agree, there is no way we could evolve if any changes must also go fix the hopefully increaseing number of apps and tests before they are accepted. We do need to plan out some more fixed points to release but I am not sure if we need to make feature releases or time based releases. I think api, apps and tests may all be on their schedule a but I believe it is the test suite that may be the gating factor for major api releases I.e. when the 1.0 test suite is complete and the public implementations pass it is 1.0 On Sep 11, 2014 10:12 AM, "Anders Roxell" <anders.roxell@linaro.org> wrote: > > On 2014-09-10 18:27, Bill Fischofer wrote: > > Pre v1.0 changes may be incompatible but the author should coordinate with > > affected modules to ensure that when applied the result is an ODP that > > compiles and is functional. > > I disagree with you here. > I don't think the author of this patch has to do that. > However, the author of the apps that uses ODP should _only_ use released > versions of ODP and not be on latest. > If they are on latest they should know that things will/can change. > > Cheers, > Anders > > > > > Bill > > > > On Wednesday, September 10, 2014, Mike Holmes <mike.holmes@linaro.org> > > wrote: > > > > > Isn't that the point of the pre 1.0 SW so that we reorganize as we evolve > > > to some thing we say will remain stable? > > > On Sep 9, 2014 6:08 PM, "Maxim Uvarov" <maxim.uvarov@linaro.org > > > <javascript:_e(%7B%7D,'cvml','maxim.uvarov@linaro.org');>> wrote: > > > > > >> This patch will break odp apps which use helpers. > > >> > > >> Maxim. > > >> > > >> On 09/04/2014 11:23 PM, Anders Roxell wrote: > > >> > > >>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org > > >>> <javascript:_e(%7B%7D,'cvml','anders.roxell@linaro.org');>> > > >>> --- > > >>> platform/linux-dpdk/Makefile.am | 2 +- > > >>> platform/linux-generic/Makefile.am | 2 +- > > >>> platform/linux-keystone2/Makefile.am | 2 +- > > >>> 3 files changed, 3 insertions(+), 3 deletions(-) > > >>> > > >>> diff --git a/platform/linux-dpdk/Makefile.am b/platform/linux-dpdk/ > > >>> Makefile.am > > >>> index a59435f..3787dc9 100644 > > >>> --- a/platform/linux-dpdk/Makefile.am > > >>> +++ b/platform/linux-dpdk/Makefile.am > > >>> @@ -52,7 +52,7 @@ include_HEADERS = \ > > >>> $(top_srcdir)/platform/linux- > > >>> generic/include/api/odp_timer.h \ > > >>> $(top_srcdir)/platform/linux-generic/include/api/odp_ > > >>> version.h > > >>> -subdirheadersdir = $(includedir)/helper > > >>> +subdirheadersdir = $(includedir) > > >>> subdirheaders_HEADERS = \ > > >>> $(top_srcdir)/helper/include/odph_chksum.h \ > > >>> $(top_srcdir)/helper/include/odph_eth.h \ > > >>> diff --git a/platform/linux-generic/Makefile.am > > >>> b/platform/linux-generic/Makefile.am > > >>> index 25c82ea..7b4522e 100644 > > >>> --- a/platform/linux-generic/Makefile.am > > >>> +++ b/platform/linux-generic/Makefile.am > > >>> @@ -40,7 +40,7 @@ include_HEADERS = \ > > >>> $(top_srcdir)/platform/linux- > > >>> generic/include/api/odp_pktio_netmap.h \ > > >>> $(top_srcdir)/platform/linux- > > >>> generic/include/api/odp_pktio_socket.h > > >>> -subdirheadersdir = $(includedir)/helper > > >>> +subdirheadersdir = $(includedir) > > >>> subdirheaders_HEADERS = \ > > >>> $(top_srcdir)/helper/include/odph_chksum.h \ > > >>> $(top_srcdir)/helper/include/odph_eth.h \ > > >>> diff --git a/platform/linux-keystone2/Makefile.am > > >>> b/platform/linux-keystone2/Makefile.am > > >>> index 027c035..54bce26 100644 > > >>> --- a/platform/linux-keystone2/Makefile.am > > >>> +++ b/platform/linux-keystone2/Makefile.am > > >>> @@ -55,7 +55,7 @@ include_HEADERS = \ > > >>> $(top_srcdir)/platform/linux- > > >>> generic/include/api/odp_timer.h \ > > >>> $(top_srcdir)/platform/linux-generic/include/api/odp_ > > >>> version.h > > >>> -subdirheadersdir = $(includedir)/helper > > >>> +subdirheadersdir = $(includedir) > > >>> subdirheaders_HEADERS = \ > > >>> $(top_srcdir)/helper/include/odph_chksum.h \ > > >>> $(top_srcdir)/helper/include/odph_eth.h \ > > >>> > > >> > > >> > > >> _______________________________________________ > > >> lng-odp mailing list > > >> lng-odp@lists.linaro.org > > >> <javascript:_e(%7B%7D,'cvml','lng-odp@lists.linaro.org');> > > >> http://lists.linaro.org/mailman/listinfo/lng-odp > > >> > > > > > > _______________________________________________ > > lng-odp mailing list > > lng-odp@lists.linaro.org > > http://lists.linaro.org/mailman/listinfo/lng-odp > > > -- > Anders Roxell > anders.roxell@linaro.org > M: +46 709 71 42 85 | IRC: roxell
diff --git a/platform/linux-dpdk/Makefile.am b/platform/linux-dpdk/Makefile.am index a59435f..3787dc9 100644 --- a/platform/linux-dpdk/Makefile.am +++ b/platform/linux-dpdk/Makefile.am @@ -52,7 +52,7 @@ include_HEADERS = \ $(top_srcdir)/platform/linux-generic/include/api/odp_timer.h \ $(top_srcdir)/platform/linux-generic/include/api/odp_version.h -subdirheadersdir = $(includedir)/helper +subdirheadersdir = $(includedir) subdirheaders_HEADERS = \ $(top_srcdir)/helper/include/odph_chksum.h \ $(top_srcdir)/helper/include/odph_eth.h \ diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am index 25c82ea..7b4522e 100644 --- a/platform/linux-generic/Makefile.am +++ b/platform/linux-generic/Makefile.am @@ -40,7 +40,7 @@ include_HEADERS = \ $(top_srcdir)/platform/linux-generic/include/api/odp_pktio_netmap.h \ $(top_srcdir)/platform/linux-generic/include/api/odp_pktio_socket.h -subdirheadersdir = $(includedir)/helper +subdirheadersdir = $(includedir) subdirheaders_HEADERS = \ $(top_srcdir)/helper/include/odph_chksum.h \ $(top_srcdir)/helper/include/odph_eth.h \ diff --git a/platform/linux-keystone2/Makefile.am b/platform/linux-keystone2/Makefile.am index 027c035..54bce26 100644 --- a/platform/linux-keystone2/Makefile.am +++ b/platform/linux-keystone2/Makefile.am @@ -55,7 +55,7 @@ include_HEADERS = \ $(top_srcdir)/platform/linux-generic/include/api/odp_timer.h \ $(top_srcdir)/platform/linux-generic/include/api/odp_version.h -subdirheadersdir = $(includedir)/helper +subdirheadersdir = $(includedir) subdirheaders_HEADERS = \ $(top_srcdir)/helper/include/odph_chksum.h \ $(top_srcdir)/helper/include/odph_eth.h \
Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- platform/linux-dpdk/Makefile.am | 2 +- platform/linux-generic/Makefile.am | 2 +- platform/linux-keystone2/Makefile.am | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)