[net-next,v2,5/5] net: ipa: disable IEOB interrupts before clearing

Message ID 20210121114821.26495-6-elder@linaro.org
State New
Headers show
  • net: ipa: NAPI poll updates
Related show

Commit Message

Alex Elder Jan. 21, 2021, 11:48 a.m.
Currently in gsi_isr_ieob(), event ring IEOB interrupts are disabled
one at a time.  The loop disables the IEOB interrupt for all event
rings represented in the event mask.  Instead, just disable them all
at once.

Disable them all *before* clearing the interrupt condition.  This
guarantees we'll schedule NAPI for each event once, before another
IEOB interrupt could be signaled.

Signed-off-by: Alex Elder <elder@linaro.org>

 drivers/net/ipa/gsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index 0391f5a207c9f..f79cf3c327c1c 100644
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -1205,6 +1205,7 @@  static void gsi_isr_ieob(struct gsi *gsi)
 	u32 event_mask;
 	event_mask = ioread32(gsi->virt + GSI_CNTXT_SRC_IEOB_IRQ_OFFSET);
+	gsi_irq_ieob_disable(gsi, event_mask);
 	iowrite32(event_mask, gsi->virt + GSI_CNTXT_SRC_IEOB_IRQ_CLR_OFFSET);
 	while (event_mask) {
@@ -1212,7 +1213,6 @@  static void gsi_isr_ieob(struct gsi *gsi)
 		event_mask ^= BIT(evt_ring_id);
-		gsi_irq_ieob_disable_one(gsi, evt_ring_id);