[v5,3/7] dt-bindings: arm: cpus: Document 'qcom,freq-domain' property

Message ID 20210121195250.492500-4-angelogioacchino.delregno@somainline.org
State New
Headers show
Series
  • Untitled series #95881
Related show

Commit Message

AngeloGioacchino Del Regno Jan. 21, 2021, 7:52 p.m.
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>


Add devicetree documentation for 'qcom,freq-domain' property specific
to Qualcomm CPUs. This property is used to reference the CPUFREQ node
along with Domain ID (0/1).

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

---
 Documentation/devicetree/bindings/arm/cpus.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.30.0

Comments

Rob Herring Feb. 5, 2021, 9:46 p.m. | #1
On Thu, Jan 21, 2021 at 08:52:46PM +0100, AngeloGioacchino Del Regno wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 
> Add devicetree documentation for 'qcom,freq-domain' property specific
> to Qualcomm CPUs. This property is used to reference the CPUFREQ node
> along with Domain ID (0/1).
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> ---
>  Documentation/devicetree/bindings/arm/cpus.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
> index 14cd727d3c4b..1d60975df23a 100644
> --- a/Documentation/devicetree/bindings/arm/cpus.yaml
> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
> @@ -290,6 +290,12 @@ properties:
>  
>        * arm/msm/qcom,kpss-acc.txt
>  
> +  qcom,freq-domain:

What happened to having a standard property here? There were 1 or 2 
other cases of doing the same thing.

> +    $ref: '/schemas/types.yaml#/definitions/phandle-array'
> +    description: |
> +      CPUs supporting freq-domain must set their "qcom,freq-domain" property
> +      with phandle to a cpufreq_hw node followed by the Domain ID(0/1).
> +
>    rockchip,pmu:
>      $ref: '/schemas/types.yaml#/definitions/phandle'
>      description: |
> -- 
> 2.30.0
>
AngeloGioacchino Del Regno Feb. 5, 2021, 10:22 p.m. | #2
Il 05/02/21 22:46, Rob Herring ha scritto:
> On Thu, Jan 21, 2021 at 08:52:46PM +0100, AngeloGioacchino Del Regno wrote:

>> From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

>>

>> Add devicetree documentation for 'qcom,freq-domain' property specific

>> to Qualcomm CPUs. This property is used to reference the CPUFREQ node

>> along with Domain ID (0/1).

>>

>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

>> ---

>>   Documentation/devicetree/bindings/arm/cpus.yaml | 6 ++++++

>>   1 file changed, 6 insertions(+)

>>

>> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml

>> index 14cd727d3c4b..1d60975df23a 100644

>> --- a/Documentation/devicetree/bindings/arm/cpus.yaml

>> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml

>> @@ -290,6 +290,12 @@ properties:

>>   

>>         * arm/msm/qcom,kpss-acc.txt

>>   

>> +  qcom,freq-domain:

> 

> What happened to having a standard property here? There were 1 or 2

> other cases of doing the same thing.

> 


The original discussion didn't have any more replies, so I thought to
bring it back on the table.
I have no idea about what are the other cases, but if you can suggest
a different property name (just "frequency-domain"?) I can send a new
one with the suggested one!

Though, since I don't know about other cases, how would this get
described?

frequency-domain:
"CPUs supporting frequency-domain must set this property with phandle
  to the appropriate [domain node or cpufreq node?] followed by the
  Domain ID"

Would this be fine?

Thanks,
- Angelo

>> +    $ref: '/schemas/types.yaml#/definitions/phandle-array'

>> +    description: |

>> +      CPUs supporting freq-domain must set their "qcom,freq-domain" property

>> +      with phandle to a cpufreq_hw node followed by the Domain ID(0/1).

>> +

>>     rockchip,pmu:

>>       $ref: '/schemas/types.yaml#/definitions/phandle'

>>       description: |

>> -- 

>> 2.30.0

>>

Patch

diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
index 14cd727d3c4b..1d60975df23a 100644
--- a/Documentation/devicetree/bindings/arm/cpus.yaml
+++ b/Documentation/devicetree/bindings/arm/cpus.yaml
@@ -290,6 +290,12 @@  properties:
 
       * arm/msm/qcom,kpss-acc.txt
 
+  qcom,freq-domain:
+    $ref: '/schemas/types.yaml#/definitions/phandle-array'
+    description: |
+      CPUs supporting freq-domain must set their "qcom,freq-domain" property
+      with phandle to a cpufreq_hw node followed by the Domain ID(0/1).
+
   rockchip,pmu:
     $ref: '/schemas/types.yaml#/definitions/phandle'
     description: |