diff mbox

[edk2,v7,16/24] ArmVirtualizationPkg: introduce gEarlyPL011BaseAddressGuid

Message ID 1409918214-29584-17-git-send-email-ard.biesheuvel@linaro.org
State New
Headers show

Commit Message

Ard Biesheuvel Sept. 5, 2014, 11:56 a.m. UTC 
From: Laszlo Ersek <lersek@redhat.com>

This GUID will identify a customized HOB that carries the base address of
the PL011 serial port, for clients that cannot access PCDs.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 .../ArmVirtualizationPkg/ArmVirtualizationPkg.dec  |  1 +
 .../Include/Guid/EarlyPL011BaseAddress.h           | 27 ++++++++++++++++++++++
 2 files changed, 28 insertions(+)
 create mode 100644 ArmPlatformPkg/ArmVirtualizationPkg/Include/Guid/EarlyPL011BaseAddress.h

Comments

Laszlo Ersek Sept. 6, 2014, 9:04 p.m. UTC | #1 
On 09/05/14 13:56, Ard Biesheuvel wrote:
> From: Laszlo Ersek <lersek@redhat.com>
> 
> This GUID will identify a customized HOB that carries the base address of
> the PL011 serial port, for clients that cannot access PCDs.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  .../ArmVirtualizationPkg/ArmVirtualizationPkg.dec  |  1 +
>  .../Include/Guid/EarlyPL011BaseAddress.h           | 27 ++++++++++++++++++++++
>  2 files changed, 28 insertions(+)
>  create mode 100644 ArmPlatformPkg/ArmVirtualizationPkg/Include/Guid/EarlyPL011BaseAddress.h
> 
> diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationPkg.dec b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationPkg.dec
> index 8d51182d716b..c07fce94a479 100644
> --- a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationPkg.dec
> +++ b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationPkg.dec
> @@ -32,6 +32,7 @@
>  
>  [Guids.common]
>    gArmVirtualizationTokenSpaceGuid = { 0x0B6F5CA7, 0x4F53, 0x445A, { 0xB7, 0x6E, 0x2E, 0x36, 0x5B, 0x80, 0x63, 0x66 } }
> +  gEarlyPL011BaseAddressGuid       = { 0xB199DEA9, 0xFD5C, 0x4A84, { 0x80, 0x82, 0x2F, 0x41, 0x70, 0x78, 0x03, 0x05 } }
>  
>  [PcdsFixedAtBuild]
>    #
> diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/Include/Guid/EarlyPL011BaseAddress.h b/ArmPlatformPkg/ArmVirtualizationPkg/Include/Guid/EarlyPL011BaseAddress.h
> new file mode 100644
> index 000000000000..7eecf94b8c05
> --- /dev/null
> +++ b/ArmPlatformPkg/ArmVirtualizationPkg/Include/Guid/EarlyPL011BaseAddress.h
> @@ -0,0 +1,27 @@
> +/** @file
> +  GUID for the HOB that caches the base address of the PL011 serial port, for
> +  when PCD access is not available.
> +
> +  Copyright (C) 2014, Red Hat, Inc.
> +
> +  This program and the accompanying materials are licensed and made available
> +  under the terms and conditions of the BSD License that accompanies this
> +  distribution. The full text of the license may be found at
> +  http://opensource.org/licenses/bsd-license.php.
> +
> +  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT
> +  WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +
> +**/
> +
> +#ifndef __EARLY_PL011_BASE_ADDRESS_H__
> +#define __EARLY_PL011_BASE_ADDRESS_H__
> +
> +#define EARLY_PL011_BASE_ADDRESS_GUID { \
> +          0xB199DEA9, 0xFD5C, 0x4A84, \
> +          { 0x80, 0x82, 0x2F, 0x41, 0x70, 0x78, 0x03, 0x05 } \
> +        }
> +
> +extern EFI_GUID gEarlyPL011BaseAddressGuid;
> +
> +#endif
> 

Thanks for including this. (Can't ACK it because it's from me.)

I briefly wondered if saying "for when PCD access is not available" was
still up-to-date -- and I do believe so. The by-design self-containment
requirements of SerialPortLib (that we inferred the hard way) establish
just that fact. In that sense, the word "Early" doesn't denote time
here, it denotes abstraction level.

Thanks!
Laszlo

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
diff mbox

Patch

diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationPkg.dec b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationPkg.dec
index 8d51182d716b..c07fce94a479 100644
--- a/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationPkg.dec
+++ b/ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationPkg.dec
@@ -32,6 +32,7 @@ 
 
 [Guids.common]
   gArmVirtualizationTokenSpaceGuid = { 0x0B6F5CA7, 0x4F53, 0x445A, { 0xB7, 0x6E, 0x2E, 0x36, 0x5B, 0x80, 0x63, 0x66 } }
+  gEarlyPL011BaseAddressGuid       = { 0xB199DEA9, 0xFD5C, 0x4A84, { 0x80, 0x82, 0x2F, 0x41, 0x70, 0x78, 0x03, 0x05 } }
 
 [PcdsFixedAtBuild]
   #
diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/Include/Guid/EarlyPL011BaseAddress.h b/ArmPlatformPkg/ArmVirtualizationPkg/Include/Guid/EarlyPL011BaseAddress.h
new file mode 100644
index 000000000000..7eecf94b8c05
--- /dev/null
+++ b/ArmPlatformPkg/ArmVirtualizationPkg/Include/Guid/EarlyPL011BaseAddress.h
@@ -0,0 +1,27 @@ 
+/** @file
+  GUID for the HOB that caches the base address of the PL011 serial port, for
+  when PCD access is not available.
+
+  Copyright (C) 2014, Red Hat, Inc.
+
+  This program and the accompanying materials are licensed and made available
+  under the terms and conditions of the BSD License that accompanies this
+  distribution. The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php.
+
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT
+  WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#ifndef __EARLY_PL011_BASE_ADDRESS_H__
+#define __EARLY_PL011_BASE_ADDRESS_H__
+
+#define EARLY_PL011_BASE_ADDRESS_GUID { \
+          0xB199DEA9, 0xFD5C, 0x4A84, \
+          { 0x80, 0x82, 0x2F, 0x41, 0x70, 0x78, 0x03, 0x05 } \
+        }
+
+extern EFI_GUID gEarlyPL011BaseAddressGuid;
+
+#endif