diff mbox series

tools: mkeficapsule: fill reserved members of structure

Message ID 20210122014349.20644-1-takahiro.akashi@linaro.org
State Accepted
Commit f7cd8b7b55fdd4501bc6e405b2251236cf30969e
Headers show
Series tools: mkeficapsule: fill reserved members of structure | expand

Commit Message

AKASHI Takahiro Jan. 22, 2021, 1:43 a.m. UTC
Fill reserved members of efi_firmware_management_capsule_image_header
structure with zero's for safety.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>

Fixes: CID 316354
---
 tools/mkeficapsule.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.28.0

Comments

Heinrich Schuchardt Jan. 22, 2021, 5:41 a.m. UTC | #1
On 1/22/21 2:43 AM, AKASHI Takahiro wrote:
> Fill reserved members of efi_firmware_management_capsule_image_header

> structure with zero's for safety.

>

> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>

> Fixes: CID 316354


Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>


> ---

>   tools/mkeficapsule.c | 3 +++

>   1 file changed, 3 insertions(+)

>

> diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c

> index 270943fc90ae..36f693f09644 100644

> --- a/tools/mkeficapsule.c

> +++ b/tools/mkeficapsule.c

> @@ -310,6 +310,9 @@ static int create_fwbin(char *path, char *bin, efi_guid_t *guid,

>   	image.version = 0x00000003;

>   	memcpy(&image.update_image_type_id, guid, sizeof(*guid));

>   	image.update_image_index = index;

> +	image.reserved[0] = 0;

> +	image.reserved[1] = 0;

> +	image.reserved[2] = 0;

>   	image.update_image_size = bin_stat.st_size;

>   	image.update_vendor_code_size = 0; /* none */

>   	image.update_hardware_instance = instance;

>
diff mbox series

Patch

diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c
index 270943fc90ae..36f693f09644 100644
--- a/tools/mkeficapsule.c
+++ b/tools/mkeficapsule.c
@@ -310,6 +310,9 @@  static int create_fwbin(char *path, char *bin, efi_guid_t *guid,
 	image.version = 0x00000003;
 	memcpy(&image.update_image_type_id, guid, sizeof(*guid));
 	image.update_image_index = index;
+	image.reserved[0] = 0;
+	image.reserved[1] = 0;
+	image.reserved[2] = 0;
 	image.update_image_size = bin_stat.st_size;
 	image.update_vendor_code_size = 0; /* none */
 	image.update_hardware_instance = instance;