| Message ID | 1611307424-109090-1-git-send-email-abaci-bugfix@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: megaraid_sas: remove redundant NULL check | expand |
On Fri, Jan 22, 2021 at 05:23:44PM +0800, Yang Li wrote: > Fix below warnings reported by coccicheck: > ./drivers/scsi/megaraid/megaraid_sas_fusion.c:3924:3-8: WARNING: NULL > check before some freeing functions is not needed. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com> > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +-- Please always use scripts/get_maintainer.pl to determine who to send patches to, and what mailing list, otherwise they will just be ignored, like this one :( thanks, greg k-h
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index fd60728..38fc946 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -3920,8 +3920,7 @@ static irqreturn_t megasas_isr_fusion(int irq, void *devp) { unsigned int i; for (i = 0; i < instance->drv_buf_alloc; i++) { - if (instance->crash_buf[i]) - vfree(instance->crash_buf[i]); + vfree(instance->crash_buf[i]); } instance->drv_buf_index = 0; instance->drv_buf_alloc = 0;
Fix below warnings reported by coccicheck: ./drivers/scsi/megaraid/megaraid_sas_fusion.c:3924:3-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com> --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)