| Message ID | 1410185442-907-6-git-send-email-rogerq@ti.com |
|---|---|
| State | New |
| Headers | show |
Hello. On 9/8/2014 6:10 PM, Roger Quadros wrote: > The SoC supports 2 DCAN nodes. Add them. > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > arch/arm/boot/dts/dra7.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index 370009e..4ce1a4f 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi [...] > @@ -1267,6 +1269,34 @@ > ti,irqs-skip = <10 133 139 140>; > ti,irqs-safe-map = <0>; > }; > + > + dcan1: d_can@481cc000 { The ePAPR standard has something to say here: >> The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model. If appropriate, the name should be one of the following choices: • can >> > + compatible = "bosch,d_can"; > + ti,hwmods = "dcan1"; > + reg = <0x4ae3c000 0x2000>, > + <0x558 0x4>; /* index to RAMINIT reg within syscon */ > + raminit-syscon = <&dra7_ctrl_core>; > + raminit-start-bit = <3>; > + raminit-done-bit = <1>; > + raminit-pulse; Hm, aren't the above 4 properties vendor specific? If so, they should start with a vendor prefix and comma. > + interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&dcan1_sys_clk_mux>; > + status = "disabled"; > + }; WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 09/08/2014 07:40 PM, Sergei Shtylyov wrote: > Hello. > > On 9/8/2014 6:10 PM, Roger Quadros wrote: > >> The SoC supports 2 DCAN nodes. Add them. > >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> arch/arm/boot/dts/dra7.dtsi | 30 ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) > >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index 370009e..4ce1a4f 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi > [...] >> @@ -1267,6 +1269,34 @@ >> ti,irqs-skip = <10 133 139 140>; >> ti,irqs-safe-map = <0>; >> }; >> + >> + dcan1: d_can@481cc000 { > > The ePAPR standard has something to say here: > >>> > The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model. If appropriate, the name should be one of the following choices: > > • can Right. I'll fix it up. >>> > >> + compatible = "bosch,d_can"; >> + ti,hwmods = "dcan1"; >> + reg = <0x4ae3c000 0x2000>, >> + <0x558 0x4>; /* index to RAMINIT reg within syscon */ >> + raminit-syscon = <&dra7_ctrl_core>; >> + raminit-start-bit = <3>; >> + raminit-done-bit = <1>; >> + raminit-pulse; > > Hm, aren't the above 4 properties vendor specific? If so, they should start with a vendor prefix and comma. At least for now I don't know about any other platform other than TI using a RAMINIT register outside the CAN register space. However the mechanism is generic enough and not limited to TI platforms. I don't mind vendor prefix or not, but would like to hear the opinion of the CAN maintainers as to what they would prefer. > >> + interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&dcan1_sys_clk_mux>; >> + status = "disabled"; >> + }; > cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/09/2014 10:30 AM, Roger Quadros wrote: >>> + compatible = "bosch,d_can"; >>> + ti,hwmods = "dcan1"; >>> + reg = <0x4ae3c000 0x2000>, >>> + <0x558 0x4>; /* index to RAMINIT reg within syscon */ >>> + raminit-syscon = <&dra7_ctrl_core>; >>> + raminit-start-bit = <3>; >>> + raminit-done-bit = <1>; >>> + raminit-pulse; >> >> Hm, aren't the above 4 properties vendor specific? If so, they should start with a vendor prefix and comma. > > At least for now I don't know about any other platform other than TI using a RAMINIT register outside the > CAN register space. However the mechanism is generic enough and not limited to TI platforms. > > I don't mind vendor prefix or not, but would like to hear the opinion of the CAN maintainers as to what they would prefer. I don't know of any c_can/d_can implementation outside of TI that implements the raminit outside of the register space. So a "ti," prefix seems appropriate. Marc
Hi Marc, On 09/09/2014 11:34 AM, Marc Kleine-Budde wrote: > On 09/09/2014 10:30 AM, Roger Quadros wrote: >>>> + compatible = "bosch,d_can"; >>>> + ti,hwmods = "dcan1"; >>>> + reg = <0x4ae3c000 0x2000>, >>>> + <0x558 0x4>; /* index to RAMINIT reg within syscon */ >>>> + raminit-syscon = <&dra7_ctrl_core>; >>>> + raminit-start-bit = <3>; >>>> + raminit-done-bit = <1>; >>>> + raminit-pulse; >>> >>> Hm, aren't the above 4 properties vendor specific? If so, they should start with a vendor prefix and comma. >> >> At least for now I don't know about any other platform other than TI using a RAMINIT register outside the >> CAN register space. However the mechanism is generic enough and not limited to TI platforms. >> >> I don't mind vendor prefix or not, but would like to hear the opinion of the CAN maintainers as to what they would prefer. > > I don't know of any c_can/d_can implementation outside of TI that > implements the raminit outside of the register space. So a "ti," prefix > seems appropriate. > Fine, I'll re-spin this with the "ti," prefix. Thanks. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 370009e..4ce1a4f 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi @@ -34,6 +34,8 @@ serial3 = &uart4; serial4 = &uart5; serial5 = &uart6; + d_can0 = &dcan1; + d_can1 = &dcan2; }; timer { @@ -1267,6 +1269,34 @@ ti,irqs-skip = <10 133 139 140>; ti,irqs-safe-map = <0>; }; + + dcan1: d_can@481cc000 { + compatible = "bosch,d_can"; + ti,hwmods = "dcan1"; + reg = <0x4ae3c000 0x2000>, + <0x558 0x4>; /* index to RAMINIT reg within syscon */ + raminit-syscon = <&dra7_ctrl_core>; + raminit-start-bit = <3>; + raminit-done-bit = <1>; + raminit-pulse; + interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&dcan1_sys_clk_mux>; + status = "disabled"; + }; + + dcan2: d_can@481d0000 { + compatible = "bosch,d_can"; + ti,hwmods = "dcan2"; + reg = <0x48480000 0x2000>, + <0x558 0x4>; /* index to RAMINIT reg within syscon */ + raminit-syscon = <&dra7_ctrl_core>; + raminit-start-bit = <5>; + raminit-done-bit = <2>; + raminit-pulse; + interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&sys_clkin1>; + status = "disabled"; + }; }; };
The SoC supports 2 DCAN nodes. Add them. Signed-off-by: Roger Quadros <rogerq@ti.com> --- arch/arm/boot/dts/dra7.dtsi | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)