| Message ID | 20140910111728.GG28488@arm.com |
|---|---|
| State | New |
| Headers | show |
Will, On Wed, Sep 10, 2014 at 4:17 AM, Will Deacon <will.deacon@arm.com> wrote: > On Mon, Sep 08, 2014 at 03:05:40PM +0100, Javier Martinez Canillas wrote: >> Hello Will, > > Hi Javier, > >> Since many folks don't agree that hacking different subsystems is the way >> forward I'll hold the patches and don't post them. The sunxi thread [0] >> already shows how different people have strong opposite positions on the >> correct approach to handle this. >> >> For now you can just disable the tps65090 PMIC support by not enabling the >> CONFIG_REGULATOR_TPS65090 kconfig symbol on your kernel config. That will give >> you exactly the same behavior that before tps65090 support was added to the >> Snow DT on commit b16be76 ("ARM: dts: add tps65090 power regulator for >> exynos5250-snow") which AFAIU was good enough for your workflow. > > Disabling the regulator support gives me my framebuffer back, thanks. Yay! Is this good enough to tide you over until DRM support lands? > I > then get stuck mounting my root filesystem over sd card because it's > reported as read-only. The following hack solved the issue, but I'm not > exactly sure where this regression has come from (whether this is a board > quirk or pinctrl is really misconfigured). This is a regression that was introduced by: 9795a84 mmc: dw_mmc: remove dw_mci_of_cd_gpio/wp_gpio() In "exynos5250-cros-common.dtsi" you can see that the "wp-gpios = <&gpc2 1 0>;" is still listed under the slot node. Nobody is looking there anymore. This is fixed in linux-next by: aaa25a5 ARM: dts: unuse the slot-node and deprecate the supports-highspeed for dw-mmc in exynos I'll let Kukjin decide what he wants to do about the regression in v3.17 (how to deal with conflicts, backporting, etc). -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Sep 10, 2014 at 05:03:52PM +0100, Doug Anderson wrote: > On Wed, Sep 10, 2014 at 4:17 AM, Will Deacon <will.deacon@arm.com> wrote: > > On Mon, Sep 08, 2014 at 03:05:40PM +0100, Javier Martinez Canillas wrote: > >> Since many folks don't agree that hacking different subsystems is the way > >> forward I'll hold the patches and don't post them. The sunxi thread [0] > >> already shows how different people have strong opposite positions on the > >> correct approach to handle this. > >> > >> For now you can just disable the tps65090 PMIC support by not enabling the > >> CONFIG_REGULATOR_TPS65090 kconfig symbol on your kernel config. That will give > >> you exactly the same behavior that before tps65090 support was added to the > >> Snow DT on commit b16be76 ("ARM: dts: add tps65090 power regulator for > >> exynos5250-snow") which AFAIU was good enough for your workflow. > > > > Disabling the regulator support gives me my framebuffer back, thanks. > > Yay! Is this good enough to tide you over until DRM support lands? I'm a happy camper as long as it doesn't break again. It looks like I've started another discussion as to whether simplefb breakages count as regressions. > > I > > then get stuck mounting my root filesystem over sd card because it's > > reported as read-only. The following hack solved the issue, but I'm not > > exactly sure where this regression has come from (whether this is a board > > quirk or pinctrl is really misconfigured). > > This is a regression that was introduced by: > > 9795a84 mmc: dw_mmc: remove dw_mci_of_cd_gpio/wp_gpio() > > In "exynos5250-cros-common.dtsi" you can see that the "wp-gpios = > <&gpc2 1 0>;" is still listed under the slot node. Nobody is looking > there anymore. > > This is fixed in linux-next by: > > aaa25a5 ARM: dts: unuse the slot-node and deprecate the > supports-highspeed for dw-mmc in exynos Thanks for the patch info. > I'll let Kukjin decide what he wants to do about the regression in > v3.17 (how to deal with conflicts, backporting, etc). Kukjin, please can you see about getting this merged? Not being able to mount my root filesystem is less than ideal. Will -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index f2b8c41..932d82e 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -231,6 +231,7 @@ }; mmc@12220000 { + disable-wp; status = "okay"; };