| Message ID | 20140912083045.GA31701@localhost |
|---|---|
| State | New |
| Headers | show |
On 12 September 2014 10:30, Stuart Haslam <stuart.haslam@arm.com> wrote: > On Thu, Sep 11, 2014 at 07:45:31PM +0100, Bill Fischofer wrote: > > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> > > Reviewed-by: Stuart Haslam <stuart.haslam@arm.com> > Applied, thanks. > > As it fixes the display issues. I've just one minor nit below which > could be fixed up while applying the patch. > > Also I just noticed a stray ; which makes it into the output > > diff --git a/classification_design.dox b/classification_design.dox > index 58ffb51..03714ca 100644 > --- a/classification_design.dox > +++ b/classification_design.dox > @@ -760,7 +760,7 @@ typedef struct odp_pmr_match_t { > > /** An opaque handle to a composite packet match rule-set */ > typedef struct odp_pmr_set_s *odp_pmr_set_t; > -@endverbatim; > +@endverbatim > > The above structure is used with the following APIs to implement > table-based PMRs: > > > Conforming ODP implementations SHOULD implement efficient flow set > management routines such as these: > > > > -~~~~~{.c} > > +@verbatim > > /** > > * Set of header fields that take part in flow signature hash > calculation: > > * bit positions per 'odp_cos_hdr_flow_fields_e' enumeration. > > It's not shown in this patch but the comments here are still missing a > closing / > > -- > Stuart. > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
Thanks for the sharp eyes, Stuart. And thank you Anders. Bill On Fri, Sep 12, 2014 at 3:40 AM, Anders Roxell <anders.roxell@linaro.org> wrote: > > > On 12 September 2014 10:30, Stuart Haslam <stuart.haslam@arm.com> wrote: > >> On Thu, Sep 11, 2014 at 07:45:31PM +0100, Bill Fischofer wrote: >> > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> >> >> Reviewed-by: Stuart Haslam <stuart.haslam@arm.com> >> > > Applied, thanks. > > >> >> As it fixes the display issues. I've just one minor nit below which >> could be fixed up while applying the patch. >> >> Also I just noticed a stray ; which makes it into the output >> >> diff --git a/classification_design.dox b/classification_design.dox >> index 58ffb51..03714ca 100644 >> --- a/classification_design.dox >> +++ b/classification_design.dox >> @@ -760,7 +760,7 @@ typedef struct odp_pmr_match_t { >> >> /** An opaque handle to a composite packet match rule-set */ >> typedef struct odp_pmr_set_s *odp_pmr_set_t; >> -@endverbatim; >> +@endverbatim >> >> The above structure is used with the following APIs to implement >> table-based PMRs: >> >> > Conforming ODP implementations SHOULD implement efficient flow set >> management routines such as these: >> > >> > -~~~~~{.c} >> > +@verbatim >> > /** >> > * Set of header fields that take part in flow signature hash >> calculation: >> > * bit positions per 'odp_cos_hdr_flow_fields_e' enumeration. >> >> It's not shown in this patch but the comments here are still missing a >> closing / >> >> -- >> Stuart. >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp > >
diff --git a/classification_design.dox b/classification_design.dox index 58ffb51..03714ca 100644 --- a/classification_design.dox +++ b/classification_design.dox @@ -760,7 +760,7 @@ typedef struct odp_pmr_match_t { /** An opaque handle to a composite packet match rule-set */ typedef struct odp_pmr_set_s *odp_pmr_set_t; -@endverbatim; +@endverbatim The above structure is used with the following APIs to implement table-based PMRs: